update upsert

Author: davidkhala

frame/davidkhala/data/frame/pandas/__init__.py

@@ -7,21 +7,20 @@ def upsert(df: pd.DataFrame, *primary_keys: str, record: dict, verify_integrity=
 
     if original_index: df = df.reset_index()
 
-    condition = pd.Series(True, index=df.index)
+    condition = pd.Series(False, index=df.index)
     for key in primary_keys:
         if key not in df.columns:
             raise KeyError(f"Primary key '{key}' not found in DataFrame columns")
-        condition &= (df[key] == record[key])
+        condition |= (df[key] == record[key])
 
-    match_indices = df[condition].index
-
-    if not match_indices.empty:
+    match_row_i = df[condition].index
+    if not match_row_i.empty:
         for col, value in record.items():
             if col in df.columns:
-                df.loc[match_indices, col] = value
+                df.loc[match_row_i, col] = value
             else:
                 df[col] = None
-                df.loc[match_indices, col] = value
+                df.loc[match_row_i, col] = value
     else:
         new_row = pd.DataFrame([record])
         df = pd.concat([df, new_row], ignore_index=True)

frame/tests/pandas_test.py

@@ -53,6 +53,15 @@ def test_single_index2(self):
         self.assertEqual(2, len(df.columns))
         self.assertEqual(1, len(df.index.names))
 
+    def test_single_index3(self):
+        df = self.single_index_df
+        prim_key = df.index.name
+        new_record = {'name': 'Charlie', 'score': 95, prim_key: 3}
+        df = upsert(df, record =new_record)
+
+        self.assertEqual(3,len(df)) # should insert
+
+
     def test_empty(self):
         df = pandas.DataFrame()
         prim_key = 'id'