Skip to content

Commit e616a4c

Browse files
committed
Some events don't have keyIdentifier
This was throwing an error for me on some events.
1 parent ab63bc1 commit e616a4c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

content_scripts/vimium_frontend.coffee

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -359,8 +359,8 @@ onKeydown = (event) ->
359359

360360
# handle special keys, and normal input keys with modifiers being pressed. don't handle shiftKey alone (to
361361
# avoid / being interpreted as ?
362-
if (((event.metaKey || event.ctrlKey || event.altKey) && event.keyCode > 31) ||
363-
event.keyIdentifier.slice(0, 2) != "U+")
362+
if (((event.metaKey || event.ctrlKey || event.altKey) && event.keyCode > 31) || (
363+
event.keyIdentifier && event.keyIdentifier.slice(0, 2) != "U+"))
364364
keyChar = KeyboardUtils.getKeyChar(event)
365365
# Again, ignore just modifiers. Maybe this should replace the keyCode>31 condition.
366366
if (keyChar != "")

0 commit comments

Comments
 (0)