Allow parsing of strings as numbers

Author: dbrans

demo/examples.js

@@ -18,7 +18,7 @@ export default [
   {
     description: 'Japanese yen doesn\'t use a minor unit',
     numberFormat: new Intl.NumberFormat('ja-JP', { style: 'currency', currency: 'JPY' }),
-    defaultValue: -123456,
+    defaultValue: '-1234',
   },
   {
     description: 'Percent',

src/abstract-number-format-input/__test__/index.test.js

@@ -9,14 +9,19 @@ const simpleAllowNull = formattedNumber(numberFormat, true);
 describe('format', () => {
   it('formats null, undefined, empty string as empty string', () => {
     [undefined, null, '', undefined].forEach(value =>
-        expect(simpleAllowNull.format(value)).toBe('')
+            expect(simpleAllowNull.format(value)).toBe('')
     );
   });
 
-  it('Throws if value is not a finite number', () => {
-    [false, 'booya', '123', true].forEach(value =>
-        expect(simpleAllowNull.format.bind(null, value)).toThrow('Invariant')
-    );
+  it('parses strings before formatting them', () => {
+    expect(simpleAllowNull.format('123')).toBe('123.00');
+  });
+
+  it('Throws if value is not a finite number or string number', () => {
+    // TODO: '2booya2' should throw.
+    [false, '2-2', true].forEach(value => {
+      expect(simpleAllowNull.format.bind(null, value)).toThrow('Invariant');
+    });
   });
 
   it('Formats a finite number to a string using numberFormat', () => {
@@ -86,4 +91,3 @@ describe('flipSign', () => {
     expect(simpleFormatted.flipSign( '-1.23')).toBe(1.23);
   });
 });
-

src/abstract-number-format-input/index.js

@@ -47,7 +47,8 @@ export default function formattedNumberReducer(numberFormat) {
   }
 
   function format(number) {
-    if (number === null || number === undefined || number === '') return '';
+    if (number === null || number === undefined) return '';
+    if (typeof number === 'string') return format(parse(number));
     invariant(Number.isFinite(number), `Illegal number value: ${JSON.stringify(number)}`);
     return addTrailingZeros(numberFormat.format(number));
   }

src/abstract-number-format-input/util/__test__/parseNumber.test.js

@@ -49,6 +49,7 @@ describe('parse', () => {
   });
 
   it('throws when magnitude is unparsable', () => {
+    // TODO: '2booya2' should throw.
     ['-', '.', '-.', '3-3', '3.3-'].forEach(val => {
       expect(parseNumber.bind(null, val, defaultDecimalChar)).toThrow('Invariant');
     });