config call sites (#4169)

* update config use structured logging

* WIP

* minor cleanup

* fixed merge error

* added in ShowException

* added todo to remove defaults after dropping 3.6

* removed todo that is obsolete

Author: emmyoop

core/dbt/config/profile.py

@@ -15,7 +15,8 @@
 from dbt.exceptions import ValidationException
 from dbt.exceptions import RuntimeException
 from dbt.exceptions import validator_error_message
-from dbt.logger import GLOBAL_LOGGER as logger
+from dbt.events.types import MissingProfileTarget
+from dbt.events.functions import fire_event
 from dbt.utils import coerce_dict_str
 
 from .renderer import ProfileRenderer
@@ -293,10 +294,7 @@ def render_profile(
             target_name = renderer.render_value(raw_profile['target'])
         else:
             target_name = 'default'
-            logger.debug(
-                "target not specified in profile '{}', using '{}'"
-                .format(profile_name, target_name)
-            )
+            fire_event(MissingProfileTarget(profile_name=profile_name, target_name=target_name))
 
         raw_profile_data = cls._get_profile_data(
             raw_profile, profile_name, target_name

core/dbt/config/runtime.py

@@ -19,7 +19,8 @@
 from dbt.contracts.connection import AdapterRequiredConfig, Credentials
 from dbt.contracts.graph.manifest import ManifestMetadata
 from dbt.contracts.relation import ComponentName
-from dbt.logger import GLOBAL_LOGGER as logger
+from dbt.events.types import ProfileLoadError, ProfileNotFound
+from dbt.events.functions import fire_event
 from dbt.ui import warning_tag
 
 from dbt.contracts.project import Configuration, UserConfig
@@ -544,13 +545,8 @@ def _get_rendered_profile(
                 args, profile_renderer, profile_name
             )
         except (DbtProjectError, DbtProfileError) as exc:
-            logger.debug(
-                'Profile not loaded due to error: {}', exc, exc_info=True
-            )
-            logger.info(
-                'No profile "{}" found, continuing with no target',
-                profile_name
-            )
+            fire_event(ProfileLoadError(exc=exc))
+            fire_event(ProfileNotFound(profile_name=profile_name))
             # return the poisoned form
             profile = UnsetProfile()
             # disable anonymous usage statistics

core/dbt/config/utils.py

@@ -1,8 +1,9 @@
 from typing import Dict, Any
 
 from dbt.clients import yaml_helper
+from dbt.events.functions import fire_event
 from dbt.exceptions import raise_compiler_error, ValidationException
-from dbt.logger import GLOBAL_LOGGER as logger
+from dbt.events.types import InvalidVarsYAML
 
 
 def parse_cli_vars(var_string: str) -> Dict[str, Any]:
@@ -17,7 +18,5 @@ def parse_cli_vars(var_string: str) -> Dict[str, Any]:
                 "The --vars argument must be a YAML dictionary, but was "
                 "of type '{}'".format(type_name))
     except ValidationException:
-        logger.error(
-            "The YAML provided in the --vars argument is not valid.\n"
-        )
+        fire_event(InvalidVarsYAML())
         raise

core/dbt/events/types.py

@@ -1,6 +1,6 @@
 from abc import ABCMeta, abstractmethod
 from dataclasses import dataclass
-from typing import Any, List
+from typing import Any, List, Optional
 
 
 # types to represent log levels
@@ -304,6 +304,36 @@ def cli_msg(self) -> str:
         return self.msg
 
 
+@dataclass
+class MissingProfileTarget(InfoLevel, CliEventABC):
+    profile_name: str
+    target_name: str
+
+    def cli_msg(self) -> str:
+        return f"target not specified in profile '{self.profile_name}', using '{self.target_name}'"
+
+
+@dataclass
+class ProfileLoadError(ShowException, DebugLevel, CliEventABC):
+    exc: Exception
+
+    def cli_msg(self) -> str:
+        return f"Profile not loaded due to error: {self.exc}"
+
+
+@dataclass
+class ProfileNotFound(InfoLevel, CliEventABC):
+    profile_name: Optional[str]
+
+    def cli_msg(self) -> str:
+        return f'No profile "{self.profile_name}" found, continuing with no target'
+
+
+class InvalidVarsYAML(ErrorLevel, CliEventABC):
+    def cli_msg(self) -> str:
+        return "The YAML provided in the --vars argument is not valid.\n"
+
+
 @dataclass
 class NewConnectionOpening(DebugLevel, CliEventABC):
     connection_state: str
@@ -364,3 +394,7 @@ def cli_msg(self) -> str:
     NewConnectionOpening(connection_state='')
     TimingInfoCollected()
     MergedFromState(nbr_merged=0, sample=[])
+    MissingProfileTarget(profile_name='', target_name='')
+    ProfileLoadError(exc=Exception(''))
+    ProfileNotFound(profile_name='')
+    InvalidVarsYAML()