Skip to content

add add_catalog_integration call even if we have a pre-existing manifest#12262

Merged
colin-rogers-dbt merged 3 commits intomainfrom
add-catalog-integration-all-the-time
Dec 10, 2025
Merged

add add_catalog_integration call even if we have a pre-existing manifest#12262
colin-rogers-dbt merged 3 commits intomainfrom
add-catalog-integration-all-the-time

Conversation

@colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Dec 9, 2025

Resolves #

Problem

If a manifest is passed to dbt-core we may not be updating the adapter to ensure it has the expected catalog integration.

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Dec 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review December 9, 2025 20:22
@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner December 9, 2025 20:22
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.03%. Comparing base (9cd6a23) to head (88755b2).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12262   +/-   ##
=======================================
  Coverage   92.02%   92.03%           
=======================================
  Files         203      203           
  Lines       24986    24988    +2     
=======================================
+ Hits        22994    22998    +4     
+ Misses       1992     1990    -2     
Flag Coverage Δ
integration 88.99% <50.00%> (+0.07%) ⬆️
unit 65.29% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 65.29% <0.00%> (-0.01%) ⬇️
Integration Tests 88.99% <50.00%> (+0.07%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gshank
gshank previously approved these changes Dec 9, 2025
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're going to need a changelog though :-)

MichelleArk
MichelleArk previously approved these changes Dec 9, 2025
@colin-rogers-dbt colin-rogers-dbt merged commit 9e9f5b8 into main Dec 10, 2025
101 of 102 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the add-catalog-integration-all-the-time branch December 10, 2025 17:35
@colin-rogers-dbt colin-rogers-dbt added the backport 1.10.latest Tag for PR to be backported to the 1.10.latest branch label Dec 17, 2025
github-actions bot pushed a commit that referenced this pull request Dec 17, 2025
…est (#12262)

* add add_catalog_integration call even if we have a pre-existing manifest

* add changelog

(cherry picked from commit 9e9f5b8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.10.latest Tag for PR to be backported to the 1.10.latest branch cla:yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants