From a1e049667789f1afc0feec778f278fa2c02f5aa4 Mon Sep 17 00:00:00 2001 From: Emily Rockman Date: Mon, 21 Aug 2023 16:40:20 -0500 Subject: [PATCH 1/2] update the implementation template --- .../ISSUE_TEMPLATE/implementation-ticket.yml | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/implementation-ticket.yml b/.github/ISSUE_TEMPLATE/implementation-ticket.yml index b1c9d3d5c5e..0dd1d9969ed 100644 --- a/.github/ISSUE_TEMPLATE/implementation-ticket.yml +++ b/.github/ISSUE_TEMPLATE/implementation-ticket.yml @@ -1,7 +1,7 @@ name: 🛠️ Implementation description: This is an implementation ticket intended for use by the maintainers of dbt-core title: "[] " -labels: ["user_docs"] +labels: ["user docs"] body: - type: markdown attributes: @@ -11,7 +11,7 @@ body: label: Housekeeping description: > A couple friendly reminders: - 1. Remove the `user_docs` label if the scope of this work does not require changes to https://docs.getdbt.com/docs: no end-user interface (e.g. yml spec, CLI, error messages, etc) or functional changes + 1. Remove the `user docs` label if the scope of this work does not require changes to https://docs.getdbt.com/docs: no end-user interface (e.g. yml spec, CLI, error messages, etc) or functional changes 2. Link any blocking issues in the "Blocked on" field under the "Core devs & maintainers" project. options: - label: I am a maintainer of dbt-core @@ -32,9 +32,20 @@ body: required: true - type: textarea attributes: - label: Impact to Adapters + label: Impact to Other Teams description: | - Will this require changes to adapter repos? Include details of the kinds of changes required (new tests, code changes, related tickets) + Will this change impact other teams? Include details of the kinds of changes required (new tests, code changes, related tickets) and _add the relevant `Impact[team]` label_. + placeholder: | + Example: This change impacts `dbt-redshift` because the tests will need to be modified. The `Impact[Adapter]` label has been added. + validations: + required: true + - type: textarea + attributes: + label: Will backports be required? + description: | + Will this change need to be backported to previous versions? Add details, possible blockers to backporting and _add the relevant backport labels `backport 1.x.latest`_ + placeholder: | + Example: Backport to 1.6.latest, 1.5.latest and 1.4.latest. Since 1.4 isn't using click, the backport may be complicated. The `backport 1.6.latest`, `backport 1.5.latest` and `backport 1.4.latest` labels have been added. validations: required: true - type: textarea From f922615e14c177b9ae1870f62589b34bd723c959 Mon Sep 17 00:00:00 2001 From: Emily Rockman <emily.rockman@dbtlabs.com> Date: Mon, 21 Aug 2023 16:50:00 -0500 Subject: [PATCH 2/2] add colon --- .github/ISSUE_TEMPLATE/implementation-ticket.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/implementation-ticket.yml b/.github/ISSUE_TEMPLATE/implementation-ticket.yml index 0dd1d9969ed..e5bfaaa45e5 100644 --- a/.github/ISSUE_TEMPLATE/implementation-ticket.yml +++ b/.github/ISSUE_TEMPLATE/implementation-ticket.yml @@ -34,9 +34,9 @@ body: attributes: label: Impact to Other Teams description: | - Will this change impact other teams? Include details of the kinds of changes required (new tests, code changes, related tickets) and _add the relevant `Impact[team]` label_. + Will this change impact other teams? Include details of the kinds of changes required (new tests, code changes, related tickets) and _add the relevant `Impact:[team]` label_. placeholder: | - Example: This change impacts `dbt-redshift` because the tests will need to be modified. The `Impact[Adapter]` label has been added. + Example: This change impacts `dbt-redshift` because the tests will need to be modified. The `Impact:[Adapter]` label has been added. validations: required: true - type: textarea