Fixed IE bug

Author: Nicholas C. Zakas

encodings/base64/base64.htm

@@ -33,6 +33,12 @@ <h1>Base64 Encoding/Decoding Tests</h1>
 
         name : "Base 64 Encoding Tests",
 
+        _should: {
+            error: {
+                testInvalidChar: new Error("Can't base64 encode non-ASCII characters.")
+            }
+        },
+
         //---------------------------------------------------------------------
         // Tests
         //---------------------------------------------------------------------
@@ -51,6 +57,10 @@ <h1>Base64 Encoding/Decoding Tests</h1>
             var expected = "TWFuIGlzIGRpc3Rpbmd1aXNoZWQsIG5vdCBvbmx5IGJ5IGhpcyByZWFzb24sIGJ1dCBieSB0aGlzIHNpbmd1bGFyIHBhc3Npb24gZnJvbSBvdGhlciBhbmltYWxzLCB3aGljaCBpcyBhIGx1c3Qgb2YgdGhlIG1pbmQsIHRoYXQgYnkgYSBwZXJzZXZlcmFuY2Ugb2YgZGVsaWdodCBpbiB0aGUgY29udGludWVkIGFuZCBpbmRlZmF0aWdhYmxlIGdlbmVyYXRpb24gb2Yga25vd2xlZGdlLCBleGNlZWRzIHRoZSBzaG9ydCB2ZWhlbWVuY2Ugb2YgYW55IGNhcm5hbCBwbGVhc3VyZS4=";
             var result = base64Encode("Man is distinguished, not only by his reason, but by this singular passion from other animals, which is a lust of the mind, that by a perseverance of delight in the continued and indefatigable generation of knowledge, exceeds the short vehemence of any carnal pleasure.");
             assert.areEqual(expected, result);
+        },
+        
+        testInvalidChar: function(){
+            base64Encode(String.fromCharCode(256) + "Hello!");
         }
     }));
 

encodings/base64/base64.js

@@ -65,6 +65,11 @@ function base64Encode(text){
         quantaCount,
         bits = [],
         result = [];
+        
+    //verify that there are no characters out of range
+    if (/([^\u0000-\u00ff])/.test(text)){
+        throw new Error("Can't base64 encode non-ASCII characters.");
+    }
 
     //create an array of binary digits representing the text
     while(i < text.length){
@@ -75,7 +80,7 @@ function base64Encode(text){
 
     //figure out how many 24-bit quanta are in the array
     quantaCount = Math.floor(bits.length / 24);
-   
+
     //encode all bits
     encodeBits: while(true){
 
@@ -84,7 +89,7 @@ function base64Encode(text){
             for (j=0; j < 4; j++){
                 part = bits.splice(0, 6).join("");
                 index = parseInt(part,2);
-                result.push(digits[index]);
+                result.push(digits.charAt(index));
             }
         }