Skip to content

Support KtLint 0.34+ #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nedtwigg merged 9 commits into from
Oct 7, 2019
Merged

Support KtLint 0.34+ #469

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3812713
Update relevant ktlint refs to pinterest
ZacSweers Oct 6, 2019
2fcbf34
Invoke format(Params) on KtLint 0.34+
ZacSweers Oct 6, 2019
22cedbb
Partially revert 3812713
ZacSweers Oct 6, 2019
c70f878
Fix nested class name
ZacSweers Oct 6, 2019
9c5c264
Add updated comment to test
ZacSweers Oct 6, 2019
9774046
Run spotless apply
ZacSweers Oct 6, 2019
a2166b7
Merge branch 'master' into z/updateKtLint
nedtwigg Oct 6, 2019
ce495c3
Update changelogs.
nedtwigg Oct 6, 2019
7832883
Clean a couple comments and formatting
ZacSweers Oct 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clean a couple comments and formatting
  • Loading branch information
@ZacSweers
ZacSweers committed Oct 6, 2019
commit 7832883b5fec20a9998a5849f93a7a4eba2f8938
4 changes: 2 additions & 2 deletions lib/src/main/java/com/diffplug/spotless/kotlin/KtLintStep.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,12 @@ FormatterFunc createFormat() throws Exception {
if (useParams) {
//
// In KtLint 0.34+ there is a new "format(params: Params)" function. We create an
// instance of the Params class with our configuration and call it here.
// instance of the Params class with our configuration and invoke it here.
//

// grab the Params class
Class<?> paramsClass = classLoader.loadClass(pkg + ".ktlint.core.KtLint$Params");
// and its format method
// and its constructor
Constructor<?> constructor = paramsClass.getConstructor(
/* fileName, nullable */ String.class,
/* text */ String.class,
Expand Down