Skip to content

Commit 3523064

Browse files
committed
Uses default error key if specified key doesn't exist
1 parent 54dff36 commit 3523064

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaMultiPartRequest.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,11 @@ protected String buildErrorMessage(Throwable e, Object[] args) {
120120
if (LOG.isDebugEnabled()) {
121121
LOG.debug("Preparing error message for key: [#0]", errorKey);
122122
}
123-
return LocalizedTextUtil.findText(this.getClass(), errorKey, defaultLocale, e.getMessage(), args);
123+
if (LocalizedTextUtil.findText(this.getClass(), errorKey, defaultLocale, null, new Object[0]) == null) {
124+
return LocalizedTextUtil.findText(this.getClass(), "struts.messages.error.uploading", defaultLocale, null, new Object[] { e.getMessage() });
125+
} else {
126+
return LocalizedTextUtil.findText(this.getClass(), errorKey, defaultLocale, null, args);
127+
}
124128
}
125129

126130
protected void processUpload(HttpServletRequest request, String saveDir) throws FileUploadException, UnsupportedEncodingException {

core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaStreamMultiPartRequest.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,11 @@ private String buildErrorMessage(Throwable e, Object[] args) {
539539
String errorKey = "struts.message.upload.error." + e.getClass().getSimpleName();
540540
if (LOG.isDebugEnabled())
541541
LOG.debug("Preparing error message for key: [#0]", errorKey);
542-
return LocalizedTextUtil.findText(this.getClass(), errorKey, defaultLocale, e.getMessage(), args);
542+
if (LocalizedTextUtil.findText(this.getClass(), errorKey, defaultLocale, null, new Object[0]) == null) {
543+
return LocalizedTextUtil.findText(this.getClass(), "struts.messages.error.uploading", defaultLocale, null, new Object[] { e.getMessage() });
544+
} else {
545+
return LocalizedTextUtil.findText(this.getClass(), errorKey, defaultLocale, null, args);
546+
}
543547
}
544548

545549
/**

core/src/main/java/org/apache/struts2/dispatcher/multipart/MultiPartRequestWrapper.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,11 @@ protected String buildErrorMessage(Throwable e, Object[] args) {
108108
if (LOG.isDebugEnabled()) {
109109
LOG.debug("Preparing error message for key: [#0]", errorKey);
110110
}
111-
return LocalizedTextUtil.findText(this.getClass(), errorKey, defaultLocale, e.getMessage(), args);
111+
if (LocalizedTextUtil.findText(this.getClass(), errorKey, getLocale(), null, new Object[0]) == null) {
112+
return LocalizedTextUtil.findText(this.getClass(), "struts.messages.error.uploading", defaultLocale, null, new Object[] { e.getMessage() });
113+
} else {
114+
return LocalizedTextUtil.findText(this.getClass(), errorKey, defaultLocale, null, args);
115+
}
112116
}
113117

114118
/**

0 commit comments

Comments
 (0)