Add init support in 3.7 schema
#1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvin-lubecki
requested changes
Jun 18, 2018
cli/compose/loader/loader_test.go
Outdated
| image: alpine | ||
| init: true`) | ||
| assert.NilError(t, err) | ||
| assert.Check(t, is.DeepEqual(config, &types.Config{ |
Contributor
There was a problem hiding this comment.
I think you can just check the Init value, checking the equality on all the Config is a little bit extreme here:
assert.Equal(t, isconfig.Services[0].Init, &booleanTrue)You may argue that then you have to check Services length before, but I think we can skip it 😇
Contributor
There was a problem hiding this comment.
Then you can refactor the test with these 3 cases using Table Tests.
thaJeztah
approved these changes
Jun 18, 2018
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
but agree that just checking for the boolean may be sufficient in the tests
This was referenced Jun 23, 2018
Member
|
ping @silvin-lubecki PTAL; is the test a blocker for you, or ok to merge as-is? |
> Run an init inside the container that forwards signals and reaps processes This is supported on `run` and now on Swarm services too, so it's also possible to have in on a composefile :). Signed-off-by: Vincent Demeester <[email protected]>
Signed-off-by: Silvin Lubecki <[email protected]>
silvin-lubecki
force-pushed
the
init-in-composefile
branch
from
581287a to
3805674
Compare
vdemeester
commented
Jun 25, 2018
Collaborator
Author
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
LGTM on @silvin-lubecki commit 👼
silvin-lubecki
approved these changes
Jun 25, 2018
This was referenced Jun 25, 2018
This was referenced Jul 10, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supported on
runand now on Swarm services too, so it's alsopossible to have in on a composefile :).
Signed-off-by: Vincent Demeester [email protected]
follow up to #479
fixes #51
fixes moby/moby#34639
fixes moby/swarmkit#2173
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)