[18.09 backport] fix annotations on --template-driver #1788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Ferquel <[email protected]> (cherry picked from commit 470afe1) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sune Keller <[email protected]> (cherry picked from commit 217308d) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
ping @tiborvass @silvin-lubecki @vdemeester PTAL |
Codecov Report
@@ Coverage Diff @@
## 18.09 #1788 +/- ##
=======================================
Coverage 54.22% 54.22%
=======================================
Files 290 290
Lines 19428 19428
=======================================
Hits 10535 10535
Misses 8214 8214
Partials 679 679 |
tiborvass
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of;
relates to #896