From fcd7975b129aaf3173af23049fd8ad29bed55849 Mon Sep 17 00:00:00 2001
From: Viktor Hofer <viktor.hofer@microsoft.com>
Date: Thu, 20 Apr 2023 11:51:51 +0200
Subject: [PATCH 1/3] Add an opt-in target to flag .NETStandard1.x dependencies

The .NETStandard1.x dependency graph is extremely big and results in dependency scan utilities flagging the brought in packages (in case of vulnerabilities). All the .NETStandard1.x packages except for Microsoft.NETCore.Platforms haven't shipped for years anymore and are considered deprecated.

Provide an opt-in target that can be enabled either per project or per repository (usually the later).
---
 ...ameworkFilters.BeforeCommonTargets.targets | 63 +++++++++++++++++++
 1 file changed, 63 insertions(+)

diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/TargetFrameworkFilters.BeforeCommonTargets.targets b/src/Microsoft.DotNet.Arcade.Sdk/tools/TargetFrameworkFilters.BeforeCommonTargets.targets
index edf08dba40c..6bb81b493a3 100644
--- a/src/Microsoft.DotNet.Arcade.Sdk/tools/TargetFrameworkFilters.BeforeCommonTargets.targets
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/TargetFrameworkFilters.BeforeCommonTargets.targets
@@ -16,5 +16,68 @@
     <!-- If nothing left to build, exclude it! -->
     <ExcludeFromBuild Condition="'$(_FilteredTargetFrameworks)' == ''">true</ExcludeFromBuild>
   </PropertyGroup>
+  
+  <!-- Opt-in target to verify that a project doesn't bring in the .NET Standard 1.x dependency graph
+       (usually transitively) via old dependencies. -->        
+  <Target Name="FlagNetStandard1xDependencies"
+          Condition="'$(FlagNetStandard1xDependencies)' == 'true'"
+          AfterTargets="ResolvePackageAssets">
+    <ItemGroup>
+      <NetStandard1xPackage Include="
+        Microsoft.Win32.Primitives;
+        System.AppContext;
+        System.Collections;
+        System.Collections.Concurrent;
+        System.Console;
+        System.Diagnostics.Debug;
+        System.Diagnostics.Tools;
+        System.Diagnostics.Tracing;
+        System.Globalization;
+        System.Globalization.Calendars;
+        System.IO;
+        System.IO.Compression;
+        System.IO.Compression.ZipFile;
+        System.IO.FileSystem;
+        System.IO.FileSystem.Primitives;
+        System.Linq;
+        System.Linq.Expressions;
+        System.Net.Http;
+        System.Net.Primitives;
+        System.Net.Sockets;
+        System.ObjectModel;
+        System.Reflection;
+        System.Reflection.Extensions;
+        System.Reflection.Primitives;
+        System.Resources.ResourceManager;
+        System.Runtime;
+        System.Runtime.Extensions;
+        System.Runtime.Handles;
+        System.Runtime.InteropServices;
+        System.Runtime.InteropServices.RuntimeInformation;
+        System.Runtime.Numerics;
+        System.Security.Cryptography.Algorithms;
+        System.Security.Cryptography.Encoding;
+        System.Security.Cryptography.Primitives;
+        System.Security.Cryptography.X509Certificates;
+        System.Text.Encoding;
+        System.Text.Encoding.Extensions;
+        System.Text.RegularExpressions;
+        System.Threading;
+        System.Threading.Tasks;
+        System.Threading.Timer;
+        System.Xml.ReaderWriter;
+        System.Xml.XDocument" />
+    </ItemGroup>
+
+    <ItemGroup>
+      <NonFoundNetStandard1xPackage Include="@(PackageDependencies)"
+                                    Exclude="@(NetStandard1xPackage)" />
+      <FoundNetStandard1xPackage Include="@(PackageDependencies)"
+                                 Exclude="@(NonFoundNetStandard1xPackage)" />
+    </ItemGroup>
+
+    <Error Text="The following .NET Standard 1.x packages are referenced and must be removed: %0D%0A- @(FoundNetStandard1xPackage, '%0D%0A- ')%0D%0AConsult the project.assets.json files to find the parent dependencies."
+           Condition="'@(FoundNetStandard1xPackage)' != ''" />
+  </Target>
 
 </Project>

From e38bb37002b946a2e31b6777b2471896c448918e Mon Sep 17 00:00:00 2001
From: Viktor Hofer <viktor.hofer@microsoft.com>
Date: Thu, 20 Apr 2023 11:56:31 +0200
Subject: [PATCH 2/3] Update TargetFrameworkFilters.BeforeCommonTargets.targets

---
 .../tools/TargetFrameworkFilters.BeforeCommonTargets.targets    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/TargetFrameworkFilters.BeforeCommonTargets.targets b/src/Microsoft.DotNet.Arcade.Sdk/tools/TargetFrameworkFilters.BeforeCommonTargets.targets
index 6bb81b493a3..d4fe2a7ac03 100644
--- a/src/Microsoft.DotNet.Arcade.Sdk/tools/TargetFrameworkFilters.BeforeCommonTargets.targets
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/TargetFrameworkFilters.BeforeCommonTargets.targets
@@ -20,7 +20,7 @@
   <!-- Opt-in target to verify that a project doesn't bring in the .NET Standard 1.x dependency graph
        (usually transitively) via old dependencies. -->        
   <Target Name="FlagNetStandard1xDependencies"
-          Condition="'$(FlagNetStandard1xDependencies)' == 'true'"
+          Condition="'$(FlagNetStandard1XDependencies)' == 'true'"
           AfterTargets="ResolvePackageAssets">
     <ItemGroup>
       <NetStandard1xPackage Include="

From 96cc60ec45804b6f5dd070cf43b1077a3acd75ef Mon Sep 17 00:00:00 2001
From: Viktor Hofer <viktor.hofer@microsoft.com>
Date: Thu, 20 Apr 2023 16:49:55 +0200
Subject: [PATCH 3/3] Update ArcadeSdk.md

---
 Documentation/ArcadeSdk.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/ArcadeSdk.md b/Documentation/ArcadeSdk.md
index e458268869f..1f8a066a135 100644
--- a/Documentation/ArcadeSdk.md
+++ b/Documentation/ArcadeSdk.md
@@ -1041,6 +1041,8 @@ If set to `true` calls to GetResourceString receive a default resource string va
 #### `GenerateResxSourceOmitGetResourceString` (bool)
 If set to `true` the GetResourceString method is not included in the generated class and must be specified in a separate source file.
 
+#### `FlagNetStandard1XDependencies` (bool)
+If set to `true` the `FlagNetStandard1xDependencies` target validates that the dependency graph doesn't contain any netstandard1.x packages.
 
 <!-- Begin Generated Content: Doc Feedback -->
 <sub>Was this helpful? [![Yes](https://helix.dot.net/f/ip/5?p=Documentation%5CArcadeSdk.md)](https://helix.dot.net/f/p/5?p=Documentation%5CArcadeSdk.md) [![No](https://helix.dot.net/f/in)](https://helix.dot.net/f/n/5?p=Documentation%5CArcadeSdk.md)</sub>