From ccb4c4b8f7d8255eb1e727172de2bc4c91125b03 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 30 Oct 2025 17:39:49 +0000 Subject: [PATCH 1/2] Initial plan From 5a2b995d471f0c891ffc2b3f8da9a85e8c1046ad Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 30 Oct 2025 17:46:24 +0000 Subject: [PATCH 2/2] Remove fake passwords from ExpressionResolverTests test data Co-authored-by: karolz-ms <15271049+karolz-ms@users.noreply.github.com> --- .../Aspire.Hosting.Tests/ExpressionResolverTests.cs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/Aspire.Hosting.Tests/ExpressionResolverTests.cs b/tests/Aspire.Hosting.Tests/ExpressionResolverTests.cs index b9b06627a9d..0a686f28ff9 100644 --- a/tests/Aspire.Hosting.Tests/ExpressionResolverTests.cs +++ b/tests/Aspire.Hosting.Tests/ExpressionResolverTests.cs @@ -153,12 +153,12 @@ public async Task ExpressionResolverGeneratesCorrectEndpointStrings(string exprN [InlineData(true, "http://127.0.0.1:18889", "http://aspire.dev.internal:18889")] [InlineData(false, "http://[::1]:18889", "http://[::1]:18889")] [InlineData(true, "http://[::1]:18889", "http://aspire.dev.internal:18889")] - [InlineData(false, "Server=localhost,1433;User ID=sa;Password=xxx;Database=yyy", "Server=localhost,1433;User ID=sa;Password=xxx;Database=yyy")] - [InlineData(true, "Server=localhost,1433;User ID=sa;Password=xxx;Database=yyy", "Server=aspire.dev.internal,1433;User ID=sa;Password=xxx;Database=yyy")] - [InlineData(false, "Server=127.0.0.1,1433;User ID=sa;Password=xxx;Database=yyy", "Server=127.0.0.1,1433;User ID=sa;Password=xxx;Database=yyy")] - [InlineData(true, "Server=127.0.0.1,1433;User ID=sa;Password=xxx;Database=yyy", "Server=aspire.dev.internal,1433;User ID=sa;Password=xxx;Database=yyy")] - [InlineData(false, "Server=[::1],1433;User ID=sa;Password=xxx;Database=yyy", "Server=[::1],1433;User ID=sa;Password=xxx;Database=yyy")] - [InlineData(true, "Server=[::1],1433;User ID=sa;Password=xxx;Database=yyy", "Server=aspire.dev.internal,1433;User ID=sa;Password=xxx;Database=yyy")] + [InlineData(false, "Server=localhost,1433;User ID=sa;Database=yyy", "Server=localhost,1433;User ID=sa;Database=yyy")] + [InlineData(true, "Server=localhost,1433;User ID=sa;Database=yyy", "Server=aspire.dev.internal,1433;User ID=sa;Database=yyy")] + [InlineData(false, "Server=127.0.0.1,1433;User ID=sa;Database=yyy", "Server=127.0.0.1,1433;User ID=sa;Database=yyy")] + [InlineData(true, "Server=127.0.0.1,1433;User ID=sa;Database=yyy", "Server=aspire.dev.internal,1433;User ID=sa;Database=yyy")] + [InlineData(false, "Server=[::1],1433;User ID=sa;Database=yyy", "Server=[::1],1433;User ID=sa;Database=yyy")] + [InlineData(true, "Server=[::1],1433;User ID=sa;Database=yyy", "Server=aspire.dev.internal,1433;User ID=sa;Database=yyy")] public async Task HostUrlPropertyGetsResolved(bool targetIsContainer, string hostUrlVal, string expectedValue) { var builder = DistributedApplication.CreateBuilder();