From 1925d778b6897b331fcaf5f8212c048eb7228c17 Mon Sep 17 00:00:00 2001 From: Benjamin Goose Date: Wed, 23 Oct 2024 07:24:46 +0200 Subject: [PATCH 1/2] Don't pass the gauge description as a unit --- .../Aspire.Confluent.Kafka/ConfluentKafkaMetrics.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Components/Aspire.Confluent.Kafka/ConfluentKafkaMetrics.cs b/src/Components/Aspire.Confluent.Kafka/ConfluentKafkaMetrics.cs index bcffec2c153..3d55a456c1a 100644 --- a/src/Components/Aspire.Confluent.Kafka/ConfluentKafkaMetrics.cs +++ b/src/Components/Aspire.Confluent.Kafka/ConfluentKafkaMetrics.cs @@ -27,9 +27,9 @@ public ConfluentKafkaMetrics(IMeterFactory meterFactory) { _meter = meterFactory.Create(ConfluentKafkaCommon.MeterName); - _meter.CreateObservableGauge(Gauges.ReplyQueue, GetReplyQMeasurements, Descriptions.ReplyQueue); - _meter.CreateObservableGauge(Gauges.MessageCount, GetMessageCountMeasurements, Descriptions.MessageCount); - _meter.CreateObservableGauge(Gauges.MessageSize, GetMessageSizeMeasurements, Descriptions.MessageSize); + _meter.CreateObservableGauge(Gauges.ReplyQueue, GetReplyQMeasurements, description: Descriptions.ReplyQueue); + _meter.CreateObservableGauge(Gauges.MessageCount, GetMessageCountMeasurements, description: Descriptions.MessageCount); + _meter.CreateObservableGauge(Gauges.MessageSize, GetMessageSizeMeasurements, description: Descriptions.MessageSize); Tx = _meter.CreateCounter(Counters.Tx, Descriptions.Tx); TxBytes = _meter.CreateCounter(Counters.TxBytes, Descriptions.TxBytes); From 296cd8b9e583ffa232f51ce9dbb1fcb3f0a71c40 Mon Sep 17 00:00:00 2001 From: Benjamin Goose Date: Wed, 23 Oct 2024 07:52:30 +0200 Subject: [PATCH 2/2] Don't pass counter descriptions as a unit either --- .../ConfluentKafkaMetrics.cs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/Components/Aspire.Confluent.Kafka/ConfluentKafkaMetrics.cs b/src/Components/Aspire.Confluent.Kafka/ConfluentKafkaMetrics.cs index 3d55a456c1a..3f0922cff83 100644 --- a/src/Components/Aspire.Confluent.Kafka/ConfluentKafkaMetrics.cs +++ b/src/Components/Aspire.Confluent.Kafka/ConfluentKafkaMetrics.cs @@ -31,14 +31,14 @@ public ConfluentKafkaMetrics(IMeterFactory meterFactory) _meter.CreateObservableGauge(Gauges.MessageCount, GetMessageCountMeasurements, description: Descriptions.MessageCount); _meter.CreateObservableGauge(Gauges.MessageSize, GetMessageSizeMeasurements, description: Descriptions.MessageSize); - Tx = _meter.CreateCounter(Counters.Tx, Descriptions.Tx); - TxBytes = _meter.CreateCounter(Counters.TxBytes, Descriptions.TxBytes); - TxMessages = _meter.CreateCounter(Counters.TxMessages, Descriptions.TxMessages); - TxMessageBytes = _meter.CreateCounter(Counters.TxMessageBytes, Descriptions.TxMessageBytes); - Rx = _meter.CreateCounter(Counters.Rx, Descriptions.Rx); - RxBytes = _meter.CreateCounter(Counters.RxBytes, Descriptions.RxBytes); - RxMessages = _meter.CreateCounter(Counters.RxMessages, Descriptions.RxMessages); - RxMessageBytes = _meter.CreateCounter(Counters.RxMessageBytes, Descriptions.RxMessageBytes); + Tx = _meter.CreateCounter(Counters.Tx, description: Descriptions.Tx); + TxBytes = _meter.CreateCounter(Counters.TxBytes, description: Descriptions.TxBytes); + TxMessages = _meter.CreateCounter(Counters.TxMessages, description: Descriptions.TxMessages); + TxMessageBytes = _meter.CreateCounter(Counters.TxMessageBytes, description: Descriptions.TxMessageBytes); + Rx = _meter.CreateCounter(Counters.Rx, description: Descriptions.Rx); + RxBytes = _meter.CreateCounter(Counters.RxBytes, description: Descriptions.RxBytes); + RxMessages = _meter.CreateCounter(Counters.RxMessages, description: Descriptions.RxMessages); + RxMessageBytes = _meter.CreateCounter(Counters.RxMessageBytes, description: Descriptions.RxMessageBytes); } public static class Gauges