Expose Type.GetTypeCode() and Type.Delimiter

Author: Pallavi Taneja

src/System.Runtime/ref/System.Runtime.cs

@@ -1883,6 +1883,7 @@ public abstract partial class Type
     {
         public static readonly System.Type[] EmptyTypes;
         public static readonly object Missing;
+        public static readonly char Delimiter;
         internal Type() { }
         public abstract string AssemblyQualifiedName { get; }
         public abstract string FullName { get; }
@@ -1906,6 +1907,7 @@ internal Type() { }
         public static System.Type GetType(string typeName) { return default(System.Type); }
         public static System.Type GetType(string typeName, bool throwOnError) { return default(System.Type); }
         public static System.Type GetType(string typeName, bool throwOnError, bool ignoreCase) { return default(System.Type); }
+        public static System.TypeCode GetTypeCode(System.Type type) { return default(System.TypeCode);  }
         public static System.Type GetTypeFromHandle(System.RuntimeTypeHandle handle) { return default(System.Type); }
         public abstract System.Type MakeArrayType();
         public abstract System.Type MakeArrayType(int rank);

src/System.Runtime/tests/System.Runtime.Tests.csproj

@@ -119,7 +119,17 @@
   </ItemGroup>
   <ItemGroup>
     <!-- Compile tests against the System.Runtime contract, but copy our local-built implementation for testing -->
+	<ProjectReference Include="..\ref\System.Runtime.csproj">
+      <Project>{446de6f0-47a0-4c2f-a918-768a76ccf461}</Project>
+      <Name>System.Runtime</Name>
+      <!-- Don't copy the reference assembly to output -->
+      <Private>false</Private>
+      <UndefineProperties>OSGroup</UndefineProperties>
+    </ProjectReference>
     <ProjectReference Include="..\src\System.Runtime.csproj">
+      <Project>{1e689c1b-690c-4799-bde9-6e7990585894}</Project>
+      <Name>System.Runtime.CoreCLR</Name>
+      <!-- Don't reference implementation assembly, but do deploy it. -->
       <ReferenceOutputAssembly>false</ReferenceOutputAssembly>
       <OutputItemType>Content</OutputItemType>
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>

src/System.Runtime/tests/System/Type.cs

@@ -254,4 +254,37 @@ public static void TestGetTypeByNameInvalid(string typeName, Type expectedExcept
 
         Assert.Throws(expectedException, () => Type.GetType(typeName, throwOnError: true, ignoreCase: false));
     }
+
+    [Fact]
+    public static void Delimiter()
+    {
+        Assert.NotNull(Type.Delimiter);
+    }
+
+    [Theory]
+    [InlineData(typeof(bool), TypeCode.Boolean)]
+    [InlineData(typeof(byte), TypeCode.Byte)]
+    [InlineData(typeof(char), TypeCode.Char)]
+    [InlineData(typeof(DateTime), TypeCode.DateTime)]
+    [InlineData(typeof(decimal), TypeCode.Decimal)]
+    [InlineData(typeof(double), TypeCode.Double)]
+    [InlineData(null, TypeCode.Empty)]
+    [InlineData(typeof(short), TypeCode.Int16)]
+    [InlineData(typeof(int), TypeCode.Int32)]
+    [InlineData(typeof(long), TypeCode.Int64)]
+    [InlineData(typeof(object), TypeCode.Object)]
+    [InlineData(typeof(System.Nullable), TypeCode.Object)]
+    [InlineData(typeof(Nullable<int>), TypeCode.Object)]
+    [InlineData(typeof(Dictionary<,>), TypeCode.Object)]
+    [InlineData(typeof(Exception), TypeCode.Object)]
+    [InlineData(typeof(sbyte), TypeCode.SByte)]
+    [InlineData(typeof(float), TypeCode.Single)]
+    [InlineData(typeof(string), TypeCode.String)]
+    [InlineData(typeof(ushort), TypeCode.UInt16)]
+    [InlineData(typeof(uint), TypeCode.UInt32)]
+    [InlineData(typeof(ulong), TypeCode.UInt64)]
+    public static void GetTypeCode(Type t, TypeCode typeCode)
+    {
+        Assert.Equal(typeCode, Type.GetTypeCode(t));
+    }
 }

src/System.Runtime/tests/project.json

@@ -5,7 +5,6 @@
     "System.Console": "4.0.0-rc3-23910",
     "System.Globalization": "4.0.10",
     "System.Reflection": "4.0.10",
-    "System.Runtime": "4.0.20",
     "System.Runtime.Extensions": "4.0.10",
     "System.Runtime.InteropServices": "4.0.20",
     "System.Runtime.InteropServices.RuntimeInformation": "4.0.0-rc3-23910",