From 3de14e0eb6b794b0dd350fb621fcde420d9aeaa1 Mon Sep 17 00:00:00 2001 From: Robert Jessop Date: Wed, 20 Nov 2024 14:09:00 +0000 Subject: [PATCH] fix: System.Reflection.Metadata.Document.Name can throw BadImageFormatException --- src/Docfx.Dotnet/SymbolUrlResolver.SourceLink.cs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/Docfx.Dotnet/SymbolUrlResolver.SourceLink.cs b/src/Docfx.Dotnet/SymbolUrlResolver.SourceLink.cs index adc14d64930..d7ba0c49a09 100644 --- a/src/Docfx.Dotnet/SymbolUrlResolver.SourceLink.cs +++ b/src/Docfx.Dotnet/SymbolUrlResolver.SourceLink.cs @@ -89,8 +89,15 @@ public SourceLinkProvider(PEReader peReader, MetadataReaderProvider pdbReaderPro private string? TryGetSourceLinkUrl(DocumentHandle handle) { var document = _pdbReader.GetDocument(handle); - if (document.Name.IsNil) + try + { + if (document.Name.IsNil) + return null; + } + catch (BadImageFormatException) + { return null; + } var documentName = _pdbReader.GetString(document.Name); if (documentName is null)