Skip to content

Conversation

@albert-du
Copy link
Contributor

Summary

Adds F# snippets for System.Activator

@albert-du albert-du requested a review from a team as a code owner November 24, 2021 04:38
@ghost
Copy link

ghost commented Nov 24, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@opbld32
Copy link

opbld32 commented Nov 24, 2021

Docs Build status updates of commit be19bc4:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System/Activator.xml ⚠️Warning View Details
samples/snippets/fsharp/VS_Snippets_CLR/ActivatorX/fs/ActivatorX.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/ActivatorX/fs/ActivatorX.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/ActivatorX/fs/source2.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activation.createinstance~~1/fs/remarks.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activation.createinstance~~1/fs/remarks.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/CreateInstance5.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/PersonInfo/PersonInfo.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/createinstance.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/createinstance2.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/createinstanceex1.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/createinstanceex1a.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/personinfo.fs ✅Succeeded View

xml/System/Activator.xml

  • Line 0, Column 0: [Warning: invalid-code] It looks like your code snippet was not rendered. Try range instead.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld34
Copy link

opbld34 commented Nov 24, 2021

Docs Build status updates of commit 8b0bef5:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/fsharp/VS_Snippets_CLR/ActivatorX/fs/ActivatorX.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/ActivatorX/fs/ActivatorX.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/ActivatorX/fs/source2.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activation.createinstance~~1/fs/remarks.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activation.createinstance~~1/fs/remarks.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/CreateInstance5.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/PersonInfo/PersonInfo.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/createinstance.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/createinstance2.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/createinstanceex1.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/createinstanceex1a.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/personinfo.fs ✅Succeeded View
xml/System/Activator.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@albert-du
Copy link
Contributor Author

@dsyme could you review this?

@opbld33
Copy link

opbld33 commented Nov 25, 2021

Docs Build status updates of commit cb5c61f:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/fsharp/VS_Snippets_CLR/ActivatorX/fs/ActivatorX.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR/ActivatorX/fs/ActivatorX.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR/ActivatorX/fs/source2.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activation.createinstance~~1/fs/remarks.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activation.createinstance~~1/fs/remarks.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/CreateInstance5.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/PersonInfo/PersonInfo.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/createinstance.fsproj ✅Succeeded
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/createinstance2.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/createinstanceex1.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/createinstanceex1a.fs ✅Succeeded View
samples/snippets/fsharp/VS_Snippets_CLR_System/system.activator.createinstance/fs/personinfo.fs ✅Succeeded View
xml/System/Activator.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@albert-du
Copy link
Contributor Author

@BillWagner ready

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @albert-du

These are great. I'll :shipit: now.

@BillWagner BillWagner merged commit d10d4a5 into dotnet:main Nov 29, 2021
@albert-du albert-du deleted the system-activator-fsharp-snippets branch January 19, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants