diff --git a/benchmarks/CompilerServiceBenchmarks/CompilerServiceBenchmarks.fsproj b/benchmarks/CompilerServiceBenchmarks/CompilerServiceBenchmarks.fsproj
index 513ff0d4ec2..2fb509e4c14 100644
--- a/benchmarks/CompilerServiceBenchmarks/CompilerServiceBenchmarks.fsproj
+++ b/benchmarks/CompilerServiceBenchmarks/CompilerServiceBenchmarks.fsproj
@@ -9,7 +9,7 @@
net472
true
true
- $(SystemValueTuplePackageVersion)
+ $(SystemValueTupleVersion)
diff --git a/eng/Versions.props b/eng/Versions.props
index c2c31d5f6a7..44c7900aec1 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -60,114 +60,115 @@
https://vside.myget.org/F/devcore/api/v3/index.json;
- $([System.IO.File]::ReadAllText('$(MSBuildThisFileDirectory)..\RoslynPackageVersion.txt').Trim())
+ $([System.IO.File]::ReadAllText('$(MSBuildThisFileDirectory)..\RoslynPackageVersion.txt').Trim())
- 1.5.0
- 4.3.0
- 4.0.0
- 4.3.0
- 4.3.0
- 4.3.0
- 4.3.0
- 4.3.0
- 4.5.2
- 4.3.0
- 4.3.0
- 4.3.0
- 1.6.0
- 4.3.0
- 1.5.0
- 4.3.0
- 4.3.0
- 4.3.0
- 4.3.0
- 4.3.0
- 4.3.0
- 4.3.0
- 4.3.0
- 4.3.0
- 4.3.0
- 4.4.0
+ 1.5.0
+ 4.3.0
+ 4.0.0
+ 4.3.0
+ 4.3.0
+ 4.3.0
+ 4.3.0
+ 4.3.0
+ 4.5.2
+ 4.3.0
+ 4.3.0
+ 4.3.0
+ 1.6.0
+ 4.3.0
+ 1.5.0
+ 4.3.0
+ 4.3.0
+ 4.3.0
+ 4.3.0
+ 4.3.0
+ 4.3.0
+ 4.3.0
+ 4.3.0
+ 4.3.0
+ 4.3.0
+ 4.4.0
- $(RoslynPackageVersion)
- $(RoslynPackageVersion)
- $(RoslynPackageVersion)
- $(RoslynPackageVersion)
- $(RoslynPackageVersion)
+ $(RoslynVersion)
+ $(RoslynVersion)
+ $(RoslynVersion)
+ $(RoslynVersion)
+ $(RoslynVersion)
+ $(RoslynVersion)
16.0.461
- $(MicrosoftBuildOverallPackagesVersion)
- $(MicrosoftBuildOverallPackagesVersion)
- $(MicrosoftBuildOverallPackagesVersion)
- $(MicrosoftBuildOverallPackagesVersion)
+ $(MicrosoftBuildOverallPackagesVersion)
+ $(MicrosoftBuildOverallPackagesVersion)
+ $(MicrosoftBuildOverallPackagesVersion)
+ $(MicrosoftBuildOverallPackagesVersion)
- 8.0.1
- 14.0.25420
- 16.0.467
- 16.0.467
- 1.1.4322
- 16.0.467
- 16.0.28727
- 16.0.28729
- 16.0.467
- 16.0.467
- 16.0.467
- 8.0.50728
- 7.10.6071
- 16.0.28729
- 8.0.50728
+ 8.0.1
+ 14.0.25420
+ 16.0.467
+ 16.0.467
+ 1.1.4322
+ 16.0.467
+ 16.0.28727
+ 16.0.28729
+ 16.0.467
+ 16.0.467
+ 16.0.467
+ 8.0.50728
+ 7.10.6071
+ 16.0.28729
+ 8.0.50728
16.0.201-pre-g7d366164d0
2.3.6152103
- 14.3.25407
- 16.0.28729
- 16.0.28729
- 16.0.28729
- 10.0.30319
- 11.0.50727
- 15.0.25123-Dev15Preview
- 7.10.6072
- 8.0.50728
- 9.0.30730
- 10.0.30320
- 11.0.61031
- 12.0.30111
- 16.0.467
- 7.10.6071
- 8.0.50728
- 10.0.30320
- 12.0.30112
- 16.0.467
- 16.0.467
- 16.0.102
- 16.0.28729
- 15.3.58
- 9.0.30729
+ 14.3.25407
+ 16.0.28729
+ 16.0.28729
+ 16.0.28729
+ 10.0.30319
+ 11.0.50727
+ 15.0.25123-Dev15Preview
+ 7.10.6072
+ 8.0.50728
+ 9.0.30730
+ 10.0.30320
+ 11.0.61031
+ 12.0.30111
+ 16.0.467
+ 7.10.6071
+ 8.0.50728
+ 10.0.30320
+ 12.0.30112
+ 16.0.467
+ 16.0.467
+ 16.0.102
+ 16.0.28729
+ 15.3.58
+ 9.0.30729
16.0.2264
- 12.0.4
- 7.0.4
- 8.0.4
- 11.0.4
- 7.0.4
+ 12.0.4
+ 7.0.4
+ 8.0.4
+ 11.0.4
+ 7.0.4
- 0.2.0
- 1.0.0
- 1.0.147
+ 0.2.0
+ 1.0.0
+ 1.0.147
- 3.0.0-alpha4
+ 3.0.0-alpha4
4.3.0.0
- 1.0.30
- 8.0.0-alpha
- 2.7.0
- 2.0.3
- 15.8.0
- 1.0.0
- 4.3.0
- 9.0.1
- 3.11.0
- 3.11.2
- 3.11.0
- 2.1.36
- 1.0.0-beta2-dev3
- 5.22.2.1
+ 1.0.30
+ 8.0.0-alpha
+ 2.7.0
+ 2.0.3
+ 15.8.0
+ 1.0.0
+ 4.3.0
+ 9.0.1
+ 3.11.0
+ 3.11.2
+ 3.11.0
+ 2.1.36
+ 1.0.0-beta2-dev3
+ 5.22.2.1
diff --git a/setup/Swix/Microsoft.FSharp.Compiler.MSBuild/Microsoft.FSharp.Compiler.MSBuild.csproj b/setup/Swix/Microsoft.FSharp.Compiler.MSBuild/Microsoft.FSharp.Compiler.MSBuild.csproj
index a702f827717..cc9d75a2887 100644
--- a/setup/Swix/Microsoft.FSharp.Compiler.MSBuild/Microsoft.FSharp.Compiler.MSBuild.csproj
+++ b/setup/Swix/Microsoft.FSharp.Compiler.MSBuild/Microsoft.FSharp.Compiler.MSBuild.csproj
@@ -16,7 +16,7 @@
-
+
diff --git a/src/fsharp/fsc/fsc.fsproj b/src/fsharp/fsc/fsc.fsproj
index 8ddb082c56a..9cec3fb3140 100644
--- a/src/fsharp/fsc/fsc.fsproj
+++ b/src/fsharp/fsc/fsc.fsproj
@@ -35,11 +35,11 @@
-
-
-
-
-
+
+
+
+
+
diff --git a/src/fsharp/fsi/fsi.fsproj b/src/fsharp/fsi/fsi.fsproj
index 94c2e5a4013..8cb693c4207 100644
--- a/src/fsharp/fsi/fsi.fsproj
+++ b/src/fsharp/fsi/fsi.fsproj
@@ -46,14 +46,14 @@
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
diff --git a/src/fsharp/service/service.fs b/src/fsharp/service/service.fs
index ea4de105c7f..3ca4f8a248f 100644
--- a/src/fsharp/service/service.fs
+++ b/src/fsharp/service/service.fs
@@ -2431,11 +2431,11 @@ type BackgroundCompiler(legacyReferenceResolver, projectCacheSize, keepAssemblyC
RequireCompilationThread ctok
match incrementalBuildersCache.TryGet (ctok, options) with
| Some (builderOpt,creationErrors,_) ->
- Logger.Log LogCompilerFunctionId.Service_IncrementalBuildersCache_BuildingNewCache
+ Logger.Log LogCompilerFunctionId.Service_IncrementalBuildersCache_GettingCache
let decrement = IncrementalBuilder.KeepBuilderAlive builderOpt
return builderOpt,creationErrors, decrement
| None ->
- Logger.Log LogCompilerFunctionId.Service_IncrementalBuildersCache_GettingCache
+ Logger.Log LogCompilerFunctionId.Service_IncrementalBuildersCache_BuildingNewCache
let! (builderOpt,creationErrors,_) as info = CreateOneIncrementalBuilder (ctok, options, userOpName)
incrementalBuildersCache.Set (ctok, options, info)
let decrement = IncrementalBuilder.KeepBuilderAlive builderOpt
diff --git a/src/fsharp/xlf/FSComp.txt.es.xlf b/src/fsharp/xlf/FSComp.txt.es.xlf
index 0669749702c..c4852f3606e 100644
--- a/src/fsharp/xlf/FSComp.txt.es.xlf
+++ b/src/fsharp/xlf/FSComp.txt.es.xlf
@@ -109,7 +109,7 @@
All branches of a pattern match expression must return values of the same type as the first branch, which here is '{0}'. This branch returns a value of type '{1}'.
- Todas las ramas de una expresión de coincidencia de patrón deben devolver valores del mismo tipo. La primera rama devolvió un valor de tipo "{0}", pero esta rama devolvió un valor de tipo "\{1 \}".
+ All branches of a pattern match expression must return values of the same type as the first branch, which here is '{0}'. This branch returns a value of type '{1}'.
diff --git a/tests/Directory.Build.targets b/tests/Directory.Build.targets
index 4bf59eb4aa6..e28338a5d44 100644
--- a/tests/Directory.Build.targets
+++ b/tests/Directory.Build.targets
@@ -3,10 +3,10 @@
-
-
-
-
+
+
+
+
diff --git a/tests/FSharp.Build.UnitTests/FSharp.Build.UnitTests.fsproj b/tests/FSharp.Build.UnitTests/FSharp.Build.UnitTests.fsproj
index cc43c8810f8..7c6ea79b387 100644
--- a/tests/FSharp.Build.UnitTests/FSharp.Build.UnitTests.fsproj
+++ b/tests/FSharp.Build.UnitTests/FSharp.Build.UnitTests.fsproj
@@ -20,15 +20,15 @@
-
+
-
-
-
-
-
+
+
+
+
+
diff --git a/tests/FSharp.Core.UnitTests/FSharp.Core.UnitTests.fsproj b/tests/FSharp.Core.UnitTests/FSharp.Core.UnitTests.fsproj
index 9724cf930c3..24a2132e9c2 100644
--- a/tests/FSharp.Core.UnitTests/FSharp.Core.UnitTests.fsproj
+++ b/tests/FSharp.Core.UnitTests/FSharp.Core.UnitTests.fsproj
@@ -90,7 +90,7 @@
-
+
diff --git a/tests/fsharp/FSharpSuite.Tests.fsproj b/tests/fsharp/FSharpSuite.Tests.fsproj
index 44645a569b1..56240b466b4 100644
--- a/tests/fsharp/FSharpSuite.Tests.fsproj
+++ b/tests/fsharp/FSharpSuite.Tests.fsproj
@@ -51,12 +51,12 @@
-
-
-
-
-
-
+
+
+
+
+
+
diff --git a/vsintegration/Directory.Build.targets b/vsintegration/Directory.Build.targets
index af547ce3c0c..bc5c6d7195c 100644
--- a/vsintegration/Directory.Build.targets
+++ b/vsintegration/Directory.Build.targets
@@ -7,17 +7,17 @@
-
-
-
-
-
+
+
+
+
+
-
-
-
+
+
+
diff --git a/vsintegration/Utils/LanguageServiceProfiling/LanguageServiceProfiling.fsproj b/vsintegration/Utils/LanguageServiceProfiling/LanguageServiceProfiling.fsproj
index a61ba873ce9..1b2f4b81dde 100644
--- a/vsintegration/Utils/LanguageServiceProfiling/LanguageServiceProfiling.fsproj
+++ b/vsintegration/Utils/LanguageServiceProfiling/LanguageServiceProfiling.fsproj
@@ -5,7 +5,7 @@
Exe
true
true
- $(SystemValueTuplePackageVersion)
+ $(SystemValueTupleVersion)
true
diff --git a/vsintegration/Vsix/VisualFSharpFull/VisualFSharpFull.csproj b/vsintegration/Vsix/VisualFSharpFull/VisualFSharpFull.csproj
index dc670ae39f3..cfe668403ca 100644
--- a/vsintegration/Vsix/VisualFSharpFull/VisualFSharpFull.csproj
+++ b/vsintegration/Vsix/VisualFSharpFull/VisualFSharpFull.csproj
@@ -23,7 +23,7 @@
License.txt
true
-
+
PreserveNewest
FSharp.Data.TypeProviders.dll
true
@@ -259,8 +259,8 @@
-
-
+
+
diff --git a/vsintegration/src/FSharp.Editor/FSharp.Editor.fsproj b/vsintegration/src/FSharp.Editor/FSharp.Editor.fsproj
index d6b712757b0..e43e61af58a 100644
--- a/vsintegration/src/FSharp.Editor/FSharp.Editor.fsproj
+++ b/vsintegration/src/FSharp.Editor/FSharp.Editor.fsproj
@@ -8,7 +8,7 @@
$(NoWarn);44
true
true
- $(SystemValueTuplePackageVersion)
+ $(SystemValueTupleVersion)
$(OtherFlags) --warnon:1182 --subsystemversion:6.00
false
@@ -131,37 +131,37 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/vsintegration/src/FSharp.Editor/LanguageService/FSharpProjectOptionsManager.fs b/vsintegration/src/FSharp.Editor/LanguageService/FSharpProjectOptionsManager.fs
index 9d9542087a0..3f966c31048 100644
--- a/vsintegration/src/FSharp.Editor/LanguageService/FSharpProjectOptionsManager.fs
+++ b/vsintegration/src/FSharp.Editor/LanguageService/FSharpProjectOptionsManager.fs
@@ -116,16 +116,15 @@ type private FSharpProjectOptionsReactor (workspace: VisualStudioWorkspace, sett
let cpsCommandLineOptions = new ConcurrentDictionary()
let cache = Dictionary()
- let singleFileCache = Dictionary()
+ let singleFileCache = Dictionary()
- let rec tryComputeOptionsByFile (document: Document) cancellationToken (loadTime: DateTime option) =
+ let rec tryComputeOptionsByFile (document: Document) (ct: CancellationToken) =
async {
- let! fileStamp = document.GetTextVersionAsync(cancellationToken) |> Async.AwaitTask
+ let! fileStamp = document.GetTextVersionAsync(ct) |> Async.AwaitTask
match singleFileCache.TryGetValue(document.Id) with
| false, _ ->
- let! sourceText = document.GetTextAsync(cancellationToken) |> Async.AwaitTask
- let loadTime = defaultArg loadTime DateTime.Now
- let! scriptProjectOptions, _ = checkerProvider.Checker.GetProjectOptionsFromScript(document.FilePath, sourceText.ToFSharpSourceText(), loadTime)
+ let! sourceText = document.GetTextAsync(ct) |> Async.AwaitTask
+ let! scriptProjectOptions, _ = checkerProvider.Checker.GetProjectOptionsFromScript(document.FilePath, sourceText.ToFSharpSourceText())
let projectOptions =
if isScriptFile document.FilePath then
scriptProjectOptions
@@ -145,25 +144,23 @@ type private FSharpProjectOptionsReactor (workspace: VisualStudioWorkspace, sett
Stamp = Some(int64 (fileStamp.GetHashCode()))
}
- cancellationToken.ThrowIfCancellationRequested()
-
checkerProvider.Checker.CheckProjectInBackground(projectOptions, userOpName="checkOptions")
let parsingOptions, _ = checkerProvider.Checker.GetParsingOptionsFromProjectOptions(projectOptions)
- singleFileCache.[document.Id] <- (fileStamp, loadTime, parsingOptions, projectOptions)
+ singleFileCache.[document.Id] <- (fileStamp, parsingOptions, projectOptions)
return Some(parsingOptions, projectOptions)
- | true, (fileStamp2, loadTime2, parsingOptions, projectOptions) ->
+ | true, (fileStamp2, parsingOptions, projectOptions) ->
if fileStamp <> fileStamp2 then
singleFileCache.Remove(document.Id) |> ignore
- return! tryComputeOptionsByFile document cancellationToken (Some loadTime2)
+ return! tryComputeOptionsByFile document ct
else
return Some(parsingOptions, projectOptions)
}
- let rec tryComputeOptions (project: Project) (cancellationToken: CancellationToken) =
+ let rec tryComputeOptions (project: Project) =
async {
let projectId = project.Id
match cache.TryGetValue(projectId) with
@@ -179,7 +176,7 @@ type private FSharpProjectOptionsReactor (workspace: VisualStudioWorkspace, sett
for projectReference in project.ProjectReferences do
let referencedProject = project.Solution.GetProject(projectReference.ProjectId)
if referencedProject.Language = FSharpConstants.FSharpLanguageName then
- match! tryComputeOptions referencedProject cancellationToken with
+ match! tryComputeOptions referencedProject with
| None -> canBail <- true
| Some(_, projectOptions) -> referencedProjects.Add(referencedProject.OutputFilePath, projectOptions)
@@ -229,8 +226,6 @@ type private FSharpProjectOptionsReactor (workspace: VisualStudioWorkspace, sett
Stamp = Some(int64 (project.Version.GetHashCode()))
}
- cancellationToken.ThrowIfCancellationRequested()
-
// This can happen if we didn't receive the callback from HandleCommandLineChanges yet.
if Array.isEmpty projectOptions.SourceFiles then
return None
@@ -246,7 +241,7 @@ type private FSharpProjectOptionsReactor (workspace: VisualStudioWorkspace, sett
| true, (oldProject, parsingOptions, projectOptions) ->
if isProjectInvalidated oldProject project settings then
cache.Remove(projectId) |> ignore
- return! tryComputeOptions project cancellationToken
+ return! tryComputeOptions project
else
return Some(parsingOptions, projectOptions)
}
@@ -255,30 +250,38 @@ type private FSharpProjectOptionsReactor (workspace: VisualStudioWorkspace, sett
async {
while true do
match! agent.Receive() with
- | FSharpProjectOptionsMessage.TryGetOptionsByDocument(document, reply, cancellationToken) ->
- try
- // For now, disallow miscellaneous workspace since we are using the hacky F# miscellaneous files project.
- if document.Project.Solution.Workspace.Kind = WorkspaceKind.MiscellaneousFiles then
- reply.Reply(None)
- elif document.Project.Name = FSharpConstants.FSharpMiscellaneousFilesName then
- let! options = tryComputeOptionsByFile document cancellationToken None
- reply.Reply(options)
- else
- let! options = tryComputeOptions document.Project cancellationToken
- reply.Reply(options)
- with
- | _ ->
- reply.Reply(None)
- | FSharpProjectOptionsMessage.TryGetOptionsByProject(project, reply, cancellationToken) ->
- try
- if project.Solution.Workspace.Kind = WorkspaceKind.MiscellaneousFiles || project.Name = FSharpConstants.FSharpMiscellaneousFilesName then
- reply.Reply(None)
- else
- let! options = tryComputeOptions project cancellationToken
- reply.Reply(options)
- with
- | _ ->
- reply.Reply(None)
+ | FSharpProjectOptionsMessage.TryGetOptionsByDocument(document, reply, ct) ->
+ if ct.IsCancellationRequested then
+ reply.Reply None
+ else
+ try
+ // For now, disallow miscellaneous workspace since we are using the hacky F# miscellaneous files project.
+ if document.Project.Solution.Workspace.Kind = WorkspaceKind.MiscellaneousFiles then
+ reply.Reply None
+ elif document.Project.Name = FSharpConstants.FSharpMiscellaneousFilesName then
+ let! options = tryComputeOptionsByFile document ct
+ reply.Reply options
+ else
+ let! options = tryComputeOptions document.Project
+ reply.Reply options
+ with
+ | _ ->
+ reply.Reply None
+
+ | FSharpProjectOptionsMessage.TryGetOptionsByProject(project, reply, ct) ->
+ if ct.IsCancellationRequested then
+ reply.Reply None
+ else
+ try
+ if project.Solution.Workspace.Kind = WorkspaceKind.MiscellaneousFiles || project.Name = FSharpConstants.FSharpMiscellaneousFilesName then
+ reply.Reply None
+ else
+ let! options = tryComputeOptions project
+ reply.Reply options
+ with
+ | _ ->
+ reply.Reply None
+
| FSharpProjectOptionsMessage.ClearOptions(projectId) ->
cache.Remove(projectId) |> ignore
| FSharpProjectOptionsMessage.ClearSingleFileOptionsCache(documentId) ->
@@ -287,11 +290,11 @@ type private FSharpProjectOptionsReactor (workspace: VisualStudioWorkspace, sett
let agent = MailboxProcessor.Start((fun agent -> loop agent), cancellationToken = cancellationTokenSource.Token)
- member __.TryGetOptionsByProjectAsync(project, cancellationToken) =
- agent.PostAndAsyncReply(fun reply -> FSharpProjectOptionsMessage.TryGetOptionsByProject(project, reply, cancellationToken))
+ member __.TryGetOptionsByProjectAsync(project, ct) =
+ agent.PostAndAsyncReply(fun reply -> FSharpProjectOptionsMessage.TryGetOptionsByProject(project, reply, ct))
- member __.TryGetOptionsByDocumentAsync(document, cancellationToken) =
- agent.PostAndAsyncReply(fun reply -> FSharpProjectOptionsMessage.TryGetOptionsByDocument(document, reply, cancellationToken))
+ member __.TryGetOptionsByDocumentAsync(document, ct) =
+ agent.PostAndAsyncReply(fun reply -> FSharpProjectOptionsMessage.TryGetOptionsByDocument(document, reply, ct))
member __.ClearOptionsByProjectId(projectId) =
agent.Post(FSharpProjectOptionsMessage.ClearOptions(projectId))
diff --git a/vsintegration/src/FSharp.LanguageService.Base/FSharp.LanguageService.Base.csproj b/vsintegration/src/FSharp.LanguageService.Base/FSharp.LanguageService.Base.csproj
index 58115e56eb0..9396c8c41b7 100644
--- a/vsintegration/src/FSharp.LanguageService.Base/FSharp.LanguageService.Base.csproj
+++ b/vsintegration/src/FSharp.LanguageService.Base/FSharp.LanguageService.Base.csproj
@@ -46,22 +46,22 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/vsintegration/src/FSharp.LanguageService/FSharp.LanguageService.fsproj b/vsintegration/src/FSharp.LanguageService/FSharp.LanguageService.fsproj
index 77dfb2dcc15..cf72f552163 100644
--- a/vsintegration/src/FSharp.LanguageService/FSharp.LanguageService.fsproj
+++ b/vsintegration/src/FSharp.LanguageService/FSharp.LanguageService.fsproj
@@ -8,7 +8,7 @@
$(NoWarn);44
true
true
- $(SystemValueTuplePackageVersion)
+ $(SystemValueTupleVersion)
$(OtherFlags) --warnon:1182 --subsystemversion:6.00
false
@@ -59,28 +59,28 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectBase.files b/vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectBase.files
index 09bea264a03..4343af2f328 100644
--- a/vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectBase.files
+++ b/vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectBase.files
@@ -16,22 +16,22 @@
global
- $(FSharpSourcesRoot)\..\packages\Microsoft.Build.Framework.$(MicrosoftBuildFrameworkPackageVersion)\lib\net46\Microsoft.Build.Framework.dll
+ $(FSharpSourcesRoot)\..\packages\Microsoft.Build.Framework.$(MicrosoftBuildFrameworkVersion)\lib\net46\Microsoft.Build.Framework.dll
- $(FSharpSourcesRoot)\..\packages\Microsoft.Build.$(MicrosoftBuildPackageVersion)\lib\net46\Microsoft.Build.dll
+ $(FSharpSourcesRoot)\..\packages\Microsoft.Build.$(MicrosoftBuildVersion)\lib\net46\Microsoft.Build.dll
- $(FSharpSourcesRoot)\..\packages\Microsoft.Build.Utilities.Core.$(MicrosoftBuildUtilitiesCorePackageVersion)\lib\net46\Microsoft.Build.Utilities.Core.dll
+ $(FSharpSourcesRoot)\..\packages\Microsoft.Build.Utilities.Core.$(MicrosoftBuildUtilitiesCoreVersion)\lib\net46\Microsoft.Build.Utilities.Core.dll
- $(FSharpSourcesRoot)\..\packages\Microsoft.Build.Tasks.Core.$(MicrosoftBuildTasksCorePackageVersion)\lib\net46\Microsoft.Build.Tasks.Core.dll
+ $(FSharpSourcesRoot)\..\packages\Microsoft.Build.Tasks.Core.$(MicrosoftBuildTasksCoreVersion)\lib\net46\Microsoft.Build.Tasks.Core.dll
- $(FSharpSourcesRoot)\..\packages\Microsoft.Build.Tasks.Core.$(MicrosoftBuildTasksCorePackageVersion)\lib\net46\Microsoft.Build.Tasks.Core.dll
+ $(FSharpSourcesRoot)\..\packages\Microsoft.Build.Tasks.Core.$(MicrosoftBuildTasksCoreVersion)\lib\net46\Microsoft.Build.Tasks.Core.dll
- $(FSharpSourcesRoot)\..\packages\System.IO.Compression.$(SystemIoCompressionPackageVersion)\lib\net46\System.IO.Compression.dll
+ $(FSharpSourcesRoot)\..\packages\System.IO.Compression.$(SystemIoCompressionVersion)\lib\net46\System.IO.Compression.dll
diff --git a/vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectSystem.Base.csproj b/vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectSystem.Base.csproj
index 9e3ebadbb0b..1604a94f3bd 100644
--- a/vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectSystem.Base.csproj
+++ b/vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectSystem.Base.csproj
@@ -44,23 +44,23 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/vsintegration/src/FSharp.ProjectSystem.FSharp/ProjectSystem.fsproj b/vsintegration/src/FSharp.ProjectSystem.FSharp/ProjectSystem.fsproj
index 6c2b6091402..a161faab968 100644
--- a/vsintegration/src/FSharp.ProjectSystem.FSharp/ProjectSystem.fsproj
+++ b/vsintegration/src/FSharp.ProjectSystem.FSharp/ProjectSystem.fsproj
@@ -8,7 +8,7 @@
$(NoWarn);52;62;75
true
true
- $(SystemValueTuplePackageVersion)
+ $(SystemValueTupleVersion)
$(OtherFlags) --warnon:1182 --subsystemversion:6.00
false
@@ -104,24 +104,24 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/FSharp.PropertiesPages.vbproj b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/FSharp.PropertiesPages.vbproj
index 62f44ba24d6..e192cccbf90 100644
--- a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/FSharp.PropertiesPages.vbproj
+++ b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/FSharp.PropertiesPages.vbproj
@@ -42,21 +42,21 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.cs.xlf b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.cs.xlf
index a678a4bcfeb..860555f3440 100644
--- a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.cs.xlf
+++ b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.cs.xlf
@@ -1828,8 +1828,9 @@ CONSIDER: get this from CodeDom
{0} x {1}
- {0} x {1}
+ {0} x {1}
Format string for showing a graphic's size
+
# {0} = width (as an integer)
# {1} = height (as an integer)
#Example, for a bitmap of width=123, height = 456, the English version of this string would be "123x456"
diff --git a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.de.xlf b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.de.xlf
index 662133483e3..65b4328fdc2 100644
--- a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.de.xlf
+++ b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.de.xlf
@@ -1828,8 +1828,9 @@ CONSIDER: get this from CodeDom
{0} x {1}
- {0} x {1}
+ {0} x {1}
Format string for showing a graphic's size
+
# {0} = width (as an integer)
# {1} = height (as an integer)
#Example, for a bitmap of width=123, height = 456, the English version of this string would be "123x456"
diff --git a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.es.xlf b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.es.xlf
index 41dbc88f0bd..1153755c3dd 100644
--- a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.es.xlf
+++ b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.es.xlf
@@ -1828,8 +1828,9 @@ CONSIDER: get this from CodeDom
{0} x {1}
- {0} x {1}
+ {0} x {1}
Format string for showing a graphic's size
+
# {0} = width (as an integer)
# {1} = height (as an integer)
#Example, for a bitmap of width=123, height = 456, the English version of this string would be "123x456"
diff --git a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.fr.xlf b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.fr.xlf
index 0f1e16e95f2..cd60e9f07e9 100644
--- a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.fr.xlf
+++ b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.fr.xlf
@@ -1828,8 +1828,9 @@ CONSIDER: get this from CodeDom
{0} x {1}
- {0} x {1}
+ {0} x {1}
Format string for showing a graphic's size
+
# {0} = width (as an integer)
# {1} = height (as an integer)
#Example, for a bitmap of width=123, height = 456, the English version of this string would be "123x456"
diff --git a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.it.xlf b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.it.xlf
index 8902030751c..dd58cb9a119 100644
--- a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.it.xlf
+++ b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.it.xlf
@@ -1828,8 +1828,9 @@ CONSIDER: get this from CodeDom
{0} x {1}
- {0} x {1}
+ {0} x {1}
Format string for showing a graphic's size
+
# {0} = width (as an integer)
# {1} = height (as an integer)
#Example, for a bitmap of width=123, height = 456, the English version of this string would be "123x456"
diff --git a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.ja.xlf b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.ja.xlf
index a39e49dfa0d..bdb896a5c83 100644
--- a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.ja.xlf
+++ b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.ja.xlf
@@ -1828,8 +1828,9 @@ CONSIDER: get this from CodeDom
{0} x {1}
- {0} x {1}
+ {0} x {1}
Format string for showing a graphic's size
+
# {0} = width (as an integer)
# {1} = height (as an integer)
#Example, for a bitmap of width=123, height = 456, the English version of this string would be "123x456"
diff --git a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.ko.xlf b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.ko.xlf
index e7191ac3c4a..6f540b54250 100644
--- a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.ko.xlf
+++ b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.ko.xlf
@@ -1828,8 +1828,9 @@ CONSIDER: get this from CodeDom
{0} x {1}
- {0} x {1}
+ {0} x {1}
Format string for showing a graphic's size
+
# {0} = width (as an integer)
# {1} = height (as an integer)
#Example, for a bitmap of width=123, height = 456, the English version of this string would be "123x456"
diff --git a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.pl.xlf b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.pl.xlf
index d0675bd2fcb..73bef853b9f 100644
--- a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.pl.xlf
+++ b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.pl.xlf
@@ -1828,8 +1828,9 @@ CONSIDER: get this from CodeDom
{0} x {1}
- {0} x {1}
+ {0} x {1}
Format string for showing a graphic's size
+
# {0} = width (as an integer)
# {1} = height (as an integer)
#Example, for a bitmap of width=123, height = 456, the English version of this string would be "123x456"
diff --git a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.pt-BR.xlf b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.pt-BR.xlf
index acfade88845..3e8a1693485 100644
--- a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.pt-BR.xlf
+++ b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.pt-BR.xlf
@@ -1828,8 +1828,9 @@ CONSIDER: get this from CodeDom
{0} x {1}
- {0} x {1}
+ {0} x {1}
Format string for showing a graphic's size
+
# {0} = width (as an integer)
# {1} = height (as an integer)
#Example, for a bitmap of width=123, height = 456, the English version of this string would be "123x456"
diff --git a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.ru.xlf b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.ru.xlf
index 355d363084e..2b5303d91de 100644
--- a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.ru.xlf
+++ b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.ru.xlf
@@ -1828,8 +1828,9 @@ CONSIDER: get this from CodeDom
{0} x {1}
- {0} x {1}
+ {0} x {1}
Format string for showing a graphic's size
+
# {0} = width (as an integer)
# {1} = height (as an integer)
#Example, for a bitmap of width=123, height = 456, the English version of this string would be "123x456"
diff --git a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.tr.xlf b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.tr.xlf
index 86ac32f4b37..73a72b806a2 100644
--- a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.tr.xlf
+++ b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.tr.xlf
@@ -1828,8 +1828,9 @@ CONSIDER: get this from CodeDom
{0} x {1}
- {0} x {1}
+ {0} x {1}
Format string for showing a graphic's size
+
# {0} = width (as an integer)
# {1} = height (as an integer)
#Example, for a bitmap of width=123, height = 456, the English version of this string would be "123x456"
diff --git a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.zh-Hans.xlf b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.zh-Hans.xlf
index 0537632d5fc..474f99a3dcd 100644
--- a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.zh-Hans.xlf
+++ b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.zh-Hans.xlf
@@ -1828,8 +1828,9 @@ CONSIDER: get this from CodeDom
{0} x {1}
- {0} x {1}
+ {0} x {1}
Format string for showing a graphic's size
+
# {0} = width (as an integer)
# {1} = height (as an integer)
#Example, for a bitmap of width=123, height = 456, the English version of this string would be "123x456"
diff --git a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.zh-Hant.xlf b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.zh-Hant.xlf
index 17c64ffefb9..16b7339b2a4 100644
--- a/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.zh-Hant.xlf
+++ b/vsintegration/src/FSharp.ProjectSystem.PropertyPages/Resources/xlf/Microsoft.VisualStudio.Editors.Designer.zh-Hant.xlf
@@ -1828,8 +1828,9 @@ CONSIDER: get this from CodeDom
{0} x {1}
- {0} x {1}
+ {0} x {1}
Format string for showing a graphic's size
+
# {0} = width (as an integer)
# {1} = height (as an integer)
#Example, for a bitmap of width=123, height = 456, the English version of this string would be "123x456"
diff --git a/vsintegration/src/FSharp.VS.FSI/FSharp.VS.FSI.fsproj b/vsintegration/src/FSharp.VS.FSI/FSharp.VS.FSI.fsproj
index f6deaa32daf..28e4f314f5a 100644
--- a/vsintegration/src/FSharp.VS.FSI/FSharp.VS.FSI.fsproj
+++ b/vsintegration/src/FSharp.VS.FSI/FSharp.VS.FSI.fsproj
@@ -7,7 +7,7 @@
$(NoWarn);47;75
true
true
- $(SystemValueTuplePackageVersion)
+ $(SystemValueTupleVersion)
$(OtherFlags) --subsystemversion:6.00
false
@@ -57,23 +57,23 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/vsintegration/tests/GetTypesVS.UnitTests/GetTypesVS.UnitTests.fsproj b/vsintegration/tests/GetTypesVS.UnitTests/GetTypesVS.UnitTests.fsproj
index 546c29c18cc..d44b41fab37 100644
--- a/vsintegration/tests/GetTypesVS.UnitTests/GetTypesVS.UnitTests.fsproj
+++ b/vsintegration/tests/GetTypesVS.UnitTests/GetTypesVS.UnitTests.fsproj
@@ -20,10 +20,10 @@
-
-
-
-
+
+
+
+
diff --git a/vsintegration/tests/Salsa/VisualFSharp.Salsa.fsproj b/vsintegration/tests/Salsa/VisualFSharp.Salsa.fsproj
index ee8cd6a9d30..f7eea70d974 100644
--- a/vsintegration/tests/Salsa/VisualFSharp.Salsa.fsproj
+++ b/vsintegration/tests/Salsa/VisualFSharp.Salsa.fsproj
@@ -7,7 +7,7 @@
$(NoWarn);45;47;52;58;75
true
true
- $(SystemValueTuplePackageVersion)
+ $(SystemValueTupleVersion)
true
false
@@ -49,23 +49,23 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/vsintegration/tests/UnitTests/VisualFSharp.UnitTests.fsproj b/vsintegration/tests/UnitTests/VisualFSharp.UnitTests.fsproj
index 413e40c118a..37538625168 100644
--- a/vsintegration/tests/UnitTests/VisualFSharp.UnitTests.fsproj
+++ b/vsintegration/tests/UnitTests/VisualFSharp.UnitTests.fsproj
@@ -10,7 +10,7 @@
NO_PROJECTCRACKER;$(DefineConstants)
true
true
- $(SystemValueTuplePackageVersion)
+ $(SystemValueTupleVersion)
true
true
false
@@ -221,40 +221,40 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+