Skip to content

Commit 1e0addc

Browse files
Merge pull request #12434 from eerhardt/RuntimeBuildDotNetHostPackages
Add DotNetHost runtime patch.
2 parents 34b2e93 + a1772c7 commit 1e0addc

File tree

1 file changed

+29
-0
lines changed

1 file changed

+29
-0
lines changed
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
2+
From: Eric Erhardt <[email protected]>
3+
Date: Mon, 18 Oct 2021 15:47:39 -0500
4+
Subject: [PATCH] DotNetHost packages are not created during source-build
5+
6+
The subset `host.pkg` is not producing the DotNetHost* NuGet packages. This is because the "Pack" target is getting invoked on the pkgprojs, but pkgprojs expect the "Build" target to be called. Since the "Pack" target is overriden in the Directory.Build.targets to be empty, no one is calling the "Build" target on the pkgprojs.
7+
8+
In an official build, a later subset `packs.tests` comes through and builds `Microsoft.DotNet.CoreSetup.Packaging.Tests.csproj`, which explicitly calls "Build" on the pkgprojs. So official builds still get these packages produced.
9+
10+
In source-build, we are no longer building the `packs.tests` subset, so the packages are not produced.
11+
12+
See also:
13+
* https://github.com/dotnet/runtime/pull/60575
14+
* https://github.com/dotnet/runtime/pull/60577
15+
---
16+
src/installer/Directory.Build.targets | 2 +-
17+
1 file changed, 1 insertion(+), 1 deletion(-)
18+
19+
diff --git a/src/installer/Directory.Build.targets b/src/installer/Directory.Build.targets
20+
index c6e8cf1a140..dccb8277ba7 100644
21+
--- a/src/installer/Directory.Build.targets
22+
+++ b/src/installer/Directory.Build.targets
23+
@@ -15,5 +15,5 @@
24+
<Import Project="..\..\Directory.Build.targets" />
25+
26+
<!-- Provide default targets which can be hooked onto or overridden as necessary -->
27+
- <Target Name="Pack" />
28+
+ <Target Name="Pack" DependsOnTargets="Build" />
29+
</Project>

0 commit comments

Comments
 (0)