Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/msbuild
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: eb5ebc2
Choose a base ref
...
head repository: dotnet/msbuild
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 762ae6c
Choose a head ref
  • 19 commits
  • 60 files changed
  • 8 contributors

Commits on Dec 2, 2022

  1. Configuration menu
    Copy the full SHA
    f3a9a69 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Configuration menu
    Copy the full SHA
    8b6341a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    296ba00 View commit details
    Browse the repository at this point in the history
  3. Add null check

    JanKrivanek committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    c1e837b View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Configuration menu
    Copy the full SHA
    884fde8 View commit details
    Browse the repository at this point in the history
  2. Fix wording

    JanKrivanek committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    202a929 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    95706ab View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Fix platform constraint

    JanKrivanek committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    870155c View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Clarify wiki

    JanKrivanek committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    93504d7 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Configuration menu
    Copy the full SHA
    b94eadd View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. [main] Update dependencies from dotnet/roslyn (#8236)

    * Update dependencies from https://github.com/dotnet/roslyn build 20221208.26
    
    Microsoft.Net.Compilers.Toolset
     From Version 4.4.0-2.22458.3 -> To Version 4.5.0-2.22608.26
    
    * Un-ref InternableString.Simple
    
    This triggered some C# compiler errors with newer versions of the
    compiler:
    
    ```
    S:\msbuild\src\StringTools\InternableString.Simple.cs(130,39): error CS8170: Struct members cannot return 'this' or other instance members by reference [S:\msbuild\src\StringTools\StringTools.csproj::TargetFramework=net35]
    S:\msbuild\src\StringTools\InternableString.Simple.cs(130,20): error CS8347: Cannot use a result of 'InternableString.Enumerator.Enumerator(ref InternableString)' in this context because it may expose variables referenced by parameter 'spanBuilder' outside of their declaration scope [S:\msbuild\src\StringTools\StringTools.csproj::TargetFramework=net35]
    ```
    
    Since this implementation is purely for the MSBuildTaskHost net35
    compatibility case and self-describes as "inefficient", I think it's ok
    to make it a regular non-ref struct.
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    Co-authored-by: Rainer Sigwald <[email protected]>
    3 people authored Dec 19, 2022
    Configuration menu
    Copy the full SHA
    ffdbe69 View commit details
    Browse the repository at this point in the history
  2. Switched options in doc

    JanKrivanek committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    ee5fc55 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Public api analyzer change (#8116)

    Fixes-ish #7903
    
    Context
    Our previous analyzer is not helpful due to #7903. This switches to using a more modern api analyzer.
    
    Notes
    The note that inspired this suggested including a version as well, but the documentation I found didn't mention a version.
    Forgind authored Dec 20, 2022
    Configuration menu
    Copy the full SHA
    20a9d5e View commit details
    Browse the repository at this point in the history
  2. Create FancyLogger opt-in/out mechanism (#8178)

    * Added FancyLogger
    
    Fixes #
    
    Context
    For the average user, the current ConsoleLogger does not provide the required amount of information about the build, as it either shows too little information (with low verbosity levels) or too much information that it is very difficult to find (with high verbosity levels).
    A better approach would be having the log update to show the necessary amount of information for the current performing action (be it a project, target or task) and hiding additional data for actions that completed successfully; thus reducing the amount of irrelevant info.
    Likewise the addition of formatting (bold, italics, color) using ANSI escape codes provides the user with a much better experience.
    A progress tracker for the build is also considered.
    
    This PR focuses only on the opt-in/out mechanism for the feature.
    
    Changes Made
    Created a new FancyLogger class.
    Created a ANSIBuilder static class with helper methods for ANSI formatting and graphics
    Added the /fancylogger and /flg command line switches for enabling the FancyLogger
    Added the $MSBUILDFANCYLOGGER environment variable for enabling the FancyLogger
    Testing
    Notes
    
    Co-authored-by: Rainer Sigwald <[email protected]>
    edvilme and rainersigwald authored Dec 20, 2022
    Configuration menu
    Copy the full SHA
    a6f6699 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. Merge pull request #8213 from JanKrivanek/proto/bl-embed-symlinks

    Add support for symlink files embedding to binlog
    JanKrivanek authored Jan 3, 2023
    Configuration menu
    Copy the full SHA
    ac0911a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7bcf45e View commit details
    Browse the repository at this point in the history
  3. Fix tests on unix

    JanKrivanek committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    98dfcde View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Update .vsconfig to remove .NET Core 2.1 component (#8256)

    .NET Core 2.1 is out of support and is not used in the projects in MSBuild.sln. Removing the "Microsoft.Net.Core.Component.SDK.2.1" ID from the .vsconfig file will stop Visual Studio from complaining when .NET Core 2.1 is not installed.
    
    Fixes #8255
    
    Context
    Developer issue while working with MSBuild.sln in Visual Studio.
    
    Changes Made
    Remove one line from .vsconfig file
    
    Testing
    Tested opening the solution before and after the .vsconfig change.
    jrdodds authored Jan 4, 2023
    Configuration menu
    Copy the full SHA
    955c470 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #8277 from JanKrivanek/proto/item-include-paths-fix

    Make target items paths crossplatform
    JanKrivanek authored Jan 4, 2023
    Configuration menu
    Copy the full SHA
    762ae6c View commit details
    Browse the repository at this point in the history
Loading