supporting SocketsHttpHandler

Author: amiru3f

src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Usage/ProvideHttpClientHandlerMaxResponseHeaderLengthValueCorrectly.cs

@@ -41,25 +41,31 @@ public override void Initialize(AnalysisContext context)
 
             context.RegisterCompilationStartAction(context =>
             {
-                var propertySymbol = context.Compilation
+                var httpClientHandlerPropSymbol = context.Compilation
                                     .GetOrCreateTypeByMetadataName(WellKnownTypeNames.SystemNetHttpHttpClientHandler)
                                     ?.GetMembers(MaxResponseHeadersLengthPropertyName)
                                     .FirstOrDefault();
 
-                if (propertySymbol is null)
+                var socketClientHandlerPropSymbol = context.Compilation
+                                    .GetOrCreateTypeByMetadataName(WellKnownTypeNames.SystemNetHttpSocketsHttpHandler)
+                                    ?.GetMembers(MaxResponseHeadersLengthPropertyName)
+                                    .FirstOrDefault();
+
+                if (httpClientHandlerPropSymbol is null || socketClientHandlerPropSymbol is null)
                 {
                     return;
                 }
 
-                context.RegisterOperationAction(context => AnalyzeSimpleAssignmentOperationAndCreateDiagnostic(context, propertySymbol), OperationKind.SimpleAssignment);
+                ImmutableArray<ISymbol> symbols = ImmutableArray.Create(httpClientHandlerPropSymbol, socketClientHandlerPropSymbol);
+                context.RegisterOperationAction(context => AnalyzeSimpleAssignmentOperationAndCreateDiagnostic(context, symbols), OperationKind.SimpleAssignment);
             });
         }
 
-        private static void AnalyzeSimpleAssignmentOperationAndCreateDiagnostic(OperationAnalysisContext context, ISymbol propertySymbol)
+        private static void AnalyzeSimpleAssignmentOperationAndCreateDiagnostic(OperationAnalysisContext context, ImmutableArray<ISymbol> propSymbols)
         {
             var assignmentOperation = (ISimpleAssignmentOperation)context.Operation;
 
-            if (!IsValidPropertyAssignmentOperation(assignmentOperation, propertySymbol))
+            if (!IsValidPropertyAssignmentOperation(assignmentOperation, propSymbols))
             {
                 return;
             }
@@ -70,20 +76,20 @@ private static void AnalyzeSimpleAssignmentOperationAndCreateDiagnostic(Operatio
             }
 
             // If the user set the value to int.MaxValue, their intention is to disable the limit, and we shouldn't emit a warning.
-            if (propertyValue > MaxLimitToReport && propertyValue != int.MaxValue)
+            if (propertyValue is > MaxLimitToReport and not int.MaxValue)
             {
                 context.ReportDiagnostic(context.Operation.CreateDiagnostic(EnsureMaxResponseHeaderLengthRule, propertyValue));
             }
         }
 
-        private static bool IsValidPropertyAssignmentOperation(ISimpleAssignmentOperation operation, ISymbol propertySymbol)
+        private static bool IsValidPropertyAssignmentOperation(ISimpleAssignmentOperation operation, ImmutableArray<ISymbol> propSymbols)
         {
             if (operation.Target is not IPropertyReferenceOperation propertyReferenceOperation)
             {
                 return false;
             }
 
-            if (!propertyReferenceOperation.Member.Equals(propertySymbol))
+            if (!propSymbols.Contains(propertyReferenceOperation.Member))
             {
                 return false;
             }

src/NetAnalyzers/UnitTests/Microsoft.NetCore.Analyzers/Usage/ProvideHttpClientHandlerMaxResponseHeaderLengthValueCorrectlyTests.cs

@@ -27,26 +27,42 @@ public class TestClass {
 
                     public void TestMethod() {
 
-                        HttpClientHandler handler3 = new HttpClientHandler()
+                        HttpClientHandler handler = new HttpClientHandler()
                         {
                             MaxResponseHeadersLength = GetValue()
                         };
 
-                        HttpClientHandler handler = new HttpClientHandler()
+                        HttpClientHandler handler2 = new HttpClientHandler()
                         {
                             {|#0:MaxResponseHeadersLength = val|}
                         };
 
-                        HttpClientHandler handler2 = new HttpClientHandler()
+                        HttpClientHandler handler3 = new HttpClientHandler()
                         {
                             {|#1:MaxResponseHeadersLength = 1414|}
                         };
+
+                        HttpClientHandler handler4 = new HttpClientHandler()
+                        {
+                            MaxResponseHeadersLength  = int.MaxValue
+                        };
+      
+                        SocketsHttpHandler handler5 = new SocketsHttpHandler() 
+                        {
+                            MaxResponseHeadersLength  = int.MaxValue
+                        };
+
+                        SocketsHttpHandler handler6 = new SocketsHttpHandler() 
+                        {
+                            {|#2:MaxResponseHeadersLength = 1000|}
+                        };
                     }
                 }
                         
                 ",
             VerifyCS.Diagnostic(ProvideHttpClientHandlerMaxResponseHeaderLengthValueCorrectly.RuleId).WithLocation(0).WithArguments(242424),
-            VerifyCS.Diagnostic(ProvideHttpClientHandlerMaxResponseHeaderLengthValueCorrectly.RuleId).WithLocation(1).WithArguments(1414)
+            VerifyCS.Diagnostic(ProvideHttpClientHandlerMaxResponseHeaderLengthValueCorrectly.RuleId).WithLocation(1).WithArguments(1414),
+            VerifyCS.Diagnostic(ProvideHttpClientHandlerMaxResponseHeaderLengthValueCorrectly.RuleId).WithLocation(2).WithArguments(1000)
             );
 
             await VerifyVB.VerifyAnalyzerAsync(@"

src/Utilities/Compiler/WellKnownTypeNames.cs

@@ -266,6 +266,7 @@ internal static class WellKnownTypeNames
         public const string SystemMemoryExtensions = "System.MemoryExtensions";
         public const string SystemNetHttpHttpClient = "System.Net.Http.HttpClient";
         public const string SystemNetHttpHttpClientHandler = "System.Net.Http.HttpClientHandler";
+        public const string SystemNetHttpSocketsHttpHandler = "System.Net.Http.SocketsHttpHandler";
         public const string SystemNetHttpWinHttpHandler = "System.Net.Http.WinHttpHandler";
         public const string SystemNetSecurityProtocolType = "System.Net.SecurityProtocolType";
         public const string SystemNetSecurityRemoteCertificateValidationCallback = "System.Net.Security.RemoteCertificateValidationCallback";