Skip to content

Commit 1631465

Browse files
authored
Fix servicing of coreclr nuget packages (#75884)
Fixes the failures in the 7.0.1 test servicing build: ``` /__w/1/s/.packages/microsoft.dotnet.build.tasks.packaging/7.0.0-beta.22416.1/build/Packaging.targets(800,5): error : No VersionSuffix was set. Ensure it is set before targets in packaging are ran. [/__w/1/s/src/coreclr/.nuget/Microsoft.NETCore.ILAsm/Microsoft.NETCore.ILAsm.pkgproj] ##[error].packages/microsoft.dotnet.build.tasks.packaging/7.0.0-beta.22416.1/build/Packaging.targets(800,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) No VersionSuffix was set. Ensure it is set before targets in packaging are ran. /__w/1/s/.packages/microsoft.dotnet.build.tasks.packaging/7.0.0-beta.22416.1/build/Packaging.targets(800,5): error : No VersionSuffix was set. Ensure it is set before targets in packaging are ran. [/__w/1/s/src/coreclr/.nuget/Microsoft.NETCore.ILDAsm/Microsoft.NETCore.ILDAsm.pkgproj] ##[error].packages/microsoft.dotnet.build.tasks.packaging/7.0.0-beta.22416.1/build/Packaging.targets(800,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) No VersionSuffix was set. Ensure it is set before targets in packaging are ran. ```
1 parent 20c8ae6 commit 1631465

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/coreclr/.nuget/Directory.Build.props

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@
1717
<!-- coreclr doesn't currently use the index so don't force it to be in sync -->
1818
<SkipIndexCheck>true</SkipIndexCheck>
1919
</PropertyGroup>
20+
21+
<!-- CoreCLR nuget packages shouldn't be published during servicing. -->
22+
<PropertyGroup Condition="'$(PreReleaseVersionLabel)' == 'servicing'">
23+
<IsShipping>false</IsShipping>
24+
</PropertyGroup>
2025

2126
<ItemGroup>
2227
<PackageIndex Condition="'$(MSBuildProjectExtension)' == '.pkgproj'" Include="$(PackageIndexFile)" />

0 commit comments

Comments
 (0)