Remove 1024 character limit on ODBC connection strings (#73149)

Fixes #63630

Author: roji

src/libraries/System.Data.Odbc/src/Resources/Strings.resx

@@ -386,9 +386,6 @@
   <data name="ADP_OdbcNoTypesFromProvider" xml:space="preserve">
     <value>The ODBC provider did not return results from SQLGETTYPEINFO.</value>
   </data>
-  <data name="OdbcConnection_ConnectionStringTooLong" xml:space="preserve">
-    <value>Connection string exceeds maximum allowed length of {0}.</value>
-  </data>
   <data name="Odbc_UnknownSQLType" xml:space="preserve">
     <value>Unknown SQL type - {0}.</value>
   </data>

src/libraries/System.Data.Odbc/src/System/Data/Odbc/Odbc32.cs

@@ -24,18 +24,17 @@ internal static Exception UnknownSQLType(ODBC32.SQL_TYPE sqltype)
         {
             return ADP.Argument(SR.GetString(SR.Odbc_UnknownSQLType, sqltype.ToString()));
         }
-        internal static Exception ConnectionStringTooLong()
-        {
-            return ADP.Argument(SR.GetString(SR.OdbcConnection_ConnectionStringTooLong, ODBC32.MAX_CONNECTION_STRING_LENGTH));
-        }
+
         internal static ArgumentException GetSchemaRestrictionRequired()
         {
             return ADP.Argument(SR.GetString(SR.ODBC_GetSchemaRestrictionRequired));
         }
+
         internal static ArgumentOutOfRangeException NotSupportedEnumerationValue(Type type, int value)
         {
             return ADP.ArgumentOutOfRange(SR.GetString(SR.ODBC_NotSupportedEnumerationValue, type.Name, value.ToString(System.Globalization.CultureInfo.InvariantCulture)), type.Name);
         }
+
         internal static ArgumentOutOfRangeException NotSupportedCommandType(CommandType value)
         {
 #if DEBUG
@@ -664,12 +663,6 @@ internal enum SQL_DRIVER
             COMPLETE_REQUIRED = 3,
         }
 
-        // todo:move
-        // internal const. not odbc specific
-        //
-        // Connection string max length
-        internal const int MAX_CONNECTION_STRING_LENGTH = 1024;
-
         // Column set for SQLPrimaryKeys
         internal enum SQL_PRIMARYKEYS : short
         {

src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcConnectionString.cs

@@ -22,14 +22,6 @@ internal OdbcConnectionString(string connectionString, bool validate) : base(con
                 int position = 0;
                 _expandedConnectionString = ExpandDataDirectories(ref filename, ref position);
             }
-            if (validate || (null == _expandedConnectionString))
-            {
-                // do not check string length if it was expanded because the final result may be shorter than the original
-                if ((null != connectionString) && (ODBC32.MAX_CONNECTION_STRING_LENGTH < connectionString.Length))
-                { // MDAC 83536
-                    throw ODBC.ConnectionStringTooLong();
-                }
-            }
         }
     }
 }