Remove range check in VSB.Append(char) (#82264)

MihaZupan · web-flow · commit a9dcf995cca0 · 2023-02-17T09:37:42.000-08:00
diff --git a/src/libraries/Common/src/System/Text/ValueStringBuilder.cs b/src/libraries/Common/src/System/Text/ValueStringBuilder.cs
@@ -170,9 +170,10 @@ public void Insert(int index, string? s)
         public void Append(char c)
         {
             int pos = _pos;
-            if ((uint)pos < (uint)_chars.Length)
+            Span<char> chars = _chars;
+            if ((uint)pos < (uint)chars.Length)
             {
-                _chars[pos] = c;
+                chars[pos] = c;
                 _pos = pos + 1;
             }
             else

Original file line number	Diff line number	Diff line change
`@@ -170,9 +170,10 @@ public void Insert(int index, string? s)`
`170`	`170`	`public void Append(char c)`
`171`	`171`	`{`
`172`	`172`	`int pos = _pos;`
`173`		`- if ((uint)pos < (uint)_chars.Length)`
	`173`	`+ Span<char> chars = _chars;`
	`174`	`+ if ((uint)pos < (uint)chars.Length)`
`174`	`175`	`{`
`175`		`- _chars[pos] = c;`
	`176`	`+ chars[pos] = c;`
`176`	`177`	`_pos = pos + 1;`
`177`	`178`	`}`
`178`	`179`	`else`