[mono] Pass the pending exception correctly from interp_runtime_invoke (). (#72126)

vargaz · web-flow · commit c895d957227c · 2022-07-21T15:33:53.000-05:00
Fixes #71838.
diff --git a/src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.KeyValuePair.cs b/src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.KeyValuePair.cs
@@ -396,7 +396,6 @@ private class TrailingAngleBracketPolicy : JsonNamingPolicy
         [Theory]
         [InlineData(typeof(KeyNameNullPolicy), "Key")]
         [InlineData(typeof(ValueNameNullPolicy), "Value")]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task InvalidPropertyNameFail(Type policyType, string offendingProperty)
         {
             var options = new JsonSerializerOptions
diff --git a/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.AttributePresence.cs b/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.AttributePresence.cs
@@ -115,7 +115,6 @@ public async Task PublicParameterlessCtor_MultiplePublicParameterizedCtors_WithA
 
 #if !BUILDING_SOURCE_GENERATOR_TESTS // These are compile-time warnings from the source generator.
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task MultipleAttributes_NotSupported()
         {
             async Task RunTestAsync<T>()
diff --git a/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.Exceptions.cs b/src/libraries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.Exceptions.cs
@@ -317,7 +317,6 @@ public async Task CaseInsensitiveFails()
 #if BUILDING_SOURCE_GENERATOR_TESTS
         [ActiveIssue("Multi-dim arrays not supported.")]
 #endif
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task ClassWithUnsupportedCollectionTypes()
         {
             Exception e;
diff --git a/src/libraries/System.Text.Json/tests/Common/ExtensionDataTests.cs b/src/libraries/System.Text.Json/tests/Common/ExtensionDataTests.cs
@@ -324,7 +324,6 @@ public class ClassWithTwoExtensionProperties
 #if BUILDING_SOURCE_GENERATOR_TESTS
         [ActiveIssue("https://github.com/dotnet/runtime/issues/58945")]
 #endif
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task InvalidExtensionPropertyFail()
         {
             // Baseline
@@ -799,7 +798,7 @@ public async Task DeserializeIntoJsonObjectProperty()
 #if BUILDING_SOURCE_GENERATOR_TESTS
         [ActiveIssue("https://github.com/dotnet/runtime/issues/58945")]
 #endif
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
+
         public async Task DeserializeIntoSystemObjectProperty()
         {
             string json = @"{""MyDict"":{""Property1"":1}}";
@@ -1089,7 +1088,6 @@ public class ClassWithInvalidExtensionPropertyStringJsonNode
 #if BUILDING_SOURCE_GENERATOR_TESTS
         [ActiveIssue("https://github.com/dotnet/runtime/issues/58945")]
 #endif
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task ExtensionProperty_InvalidDictionary()
         {
             var obj1 = new ClassWithInvalidExtensionPropertyStringString();
@@ -1149,7 +1147,6 @@ public class ClassWithMultipleDictionaries
 #if BUILDING_SOURCE_GENERATOR_TESTS
         [ActiveIssue("https://github.com/dotnet/runtime/issues/58945")]
 #endif
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task DeserializeIntoImmutableDictionaryProperty()
         {
             // baseline
diff --git a/src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs b/src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs
@@ -64,7 +64,6 @@ public async Task CustomNamePolicy()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task NullNamePolicy()
         {
             var options = new JsonSerializerOptions();
@@ -128,7 +127,6 @@ public async Task JsonPropertyNameAttribute()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task JsonNameAttributeDuplicateDesignTimeFail()
         {
             {
@@ -143,7 +141,6 @@ public async Task JsonNameAttributeDuplicateDesignTimeFail()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task JsonNameConflictOnCamelCasingFail()
         {
             {
diff --git a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.NonPublicAccessors.cs b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.NonPublicAccessors.cs
@@ -325,7 +325,6 @@ public class ClassWithMixedPropertyAccessors_PropertyAttributes
         [InlineData(typeof(ClassWithPrivate_InitOnlyProperty_WithJsonIncludeProperty))]
         [InlineData(typeof(ClassWithInternal_InitOnlyProperty_WithJsonIncludeProperty))]
         [InlineData(typeof(ClassWithProtected_InitOnlyProperty_WithJsonIncludeProperty))]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public virtual async Task NonPublicProperty_WithJsonInclude_Invalid(Type type)
         {
             InvalidOperationException ex = await Assert.ThrowsAsync<InvalidOperationException>(async () => await Serializer.DeserializeWrapper("{}", type));
diff --git a/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs b/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs
@@ -339,7 +339,6 @@ public async Task Ignore_PublicProperty_ConflictWithPublicDuePolicy()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task Throw_PublicProperty_ConflictDueAttributes()
         {
             // Serialize
@@ -354,7 +353,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task Throw_PublicPropertyAndField_ConflictDueAttributes()
         {
             // Serialize
@@ -369,7 +367,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task Throw_PublicProperty_ConflictDueAttributes_SingleInheritance()
         {
             // Serialize
@@ -393,7 +390,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task Throw_PublicPropertyAndField_ConflictDueAttributes_SingleInheritance()
         {
             // Serialize
@@ -417,7 +413,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task Throw_PublicProperty_ConflictDueAttributes_DoubleInheritance()
         {
             // Serialize
@@ -442,7 +437,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task Throw_PublicPropertyAndField_ConflictDueAttributes_DoubleInheritance()
         {
             // Serialize
@@ -467,7 +461,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task Throw_PublicProperty_ConflictDuePolicy()
         {
             var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase };
@@ -484,7 +477,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task Throw_PublicPropertyAndField_ConflictDuePolicy()
         {
             var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase };
@@ -501,7 +493,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task Throw_PublicProperty_ConflictDuePolicy_SingleInheritance()
         {
             var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase };
@@ -528,7 +519,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task Throw_PublicPropertyAndField_ConflictDuePolicy_SingleInheritance()
         {
             var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase };
@@ -555,7 +545,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task Throw_PublicProperty_ConflictDuePolicy_DobuleInheritance()
         {
             var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase };
@@ -583,7 +572,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task Throw_PublicPropertyAndField_ConflictDuePolicy_DobuleInheritance()
         {
             var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase };
@@ -1150,7 +1138,6 @@ public async Task JsonIgnoreAttribute()
         // Needs support for more collections.
         [ActiveIssue("https://github.com/dotnet/runtime/issues/53393")]
 #endif
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71981")]
         public async Task JsonIgnoreAttribute_UnsupportedCollection()
         {
             string json =
@@ -2426,7 +2413,6 @@ public class ClassWithThingsToIgnore_PerProperty
         [Theory]
         [InlineData(typeof(ClassWithBadIgnoreAttribute))]
         [InlineData(typeof(StructWithBadIgnoreAttribute))]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public virtual async Task JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail(Type type)
         {
             InvalidOperationException ex = await Assert.ThrowsAsync<InvalidOperationException>(async () => await Serializer.DeserializeWrapper("{}", type));
@@ -2447,7 +2433,6 @@ public virtual async Task JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail(T
         [Theory]
         [InlineData(typeof(ClassWithBadIgnoreAttribute))]
         [InlineData(typeof(StructWithBadIgnoreAttribute))]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public virtual async Task JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson(Type type)
         {
             InvalidOperationException ex = await Assert.ThrowsAsync<InvalidOperationException>(async () => await Serializer.DeserializeWrapper("", type));
@@ -2760,7 +2745,6 @@ public async Task JsonIgnoreCondition_Polymorphic()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task SerializationMetadataNotComputedWhenMemberIgnored()
         {
             string janePayload = @"{""Name"":""Jane Doe""}";
diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs
@@ -300,7 +300,6 @@ public PropertyVisibilityTests_Default()
         [InlineData(typeof(ClassWithPrivate_InitOnlyProperty_WithJsonIncludeProperty))]
         [InlineData(typeof(ClassWithInternal_InitOnlyProperty_WithJsonIncludeProperty))]
         [InlineData(typeof(ClassWithProtected_InitOnlyProperty_WithJsonIncludeProperty))]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public override async Task NonPublicProperty_WithJsonInclude_Invalid(Type type)
         {
             // Exception messages direct users to use JsonSourceGenerationMode.Metadata to see a more detailed error.
diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/InvalidTypeTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/InvalidTypeTests.cs
@@ -58,7 +58,6 @@ public void DeserializeInvalidType(Type type)
 
         [Theory]
         [MemberData(nameof(TypesWithInvalidMembers_WithMembers))]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task TypeWithInvalidMember(Type classType, Type invalidMemberType, string invalidMemberName)
         {
             static void ValidateException(InvalidOperationException ex, Type classType, Type invalidMemberType, string invalidMemberName)
diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/PropertyNameTests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/PropertyNameTests.cs
@@ -22,7 +22,6 @@ public async Task JsonNullNameAttribute()
         }
 
         [Fact]
-        [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
         public async Task JsonNameConflictOnCaseInsensitiveFail()
         {
             string json = @"{""myInt"":1,""MyInt"":2}";
diff --git a/src/mono/mono/mini/interp/interp.c b/src/mono/mono/mini/interp/interp.c
@@ -2119,13 +2119,13 @@ interp_runtime_invoke (MonoMethod *method, void *obj, void **params, MonoObject
 
 	context->stack_pointer = (guchar*)sp;
 
-	check_pending_unwind (context);
-
 	if (context->has_resume_state) {
 		/*
 		 * This can happen on wasm where native frames cannot be skipped during EH.
 		 * EH processing will continue when control returns to the interpreter.
 		 */
+		if (mono_aot_mode == MONO_AOT_MODE_LLVMONLY_INTERP)
+			mono_llvm_cpp_throw_exception ();
 		return NULL;
 	}
 	// The return value is at the bottom of the stack

Original file line number	Diff line number	Diff line change
`@@ -396,7 +396,6 @@ private class TrailingAngleBracketPolicy : JsonNamingPolicy`
`396`	`396`	`[Theory]`
`397`	`397`	`[InlineData(typeof(KeyNameNullPolicy), "Key")]`
`398`	`398`	`[InlineData(typeof(ValueNameNullPolicy), "Value")]`
`399`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`400`	`399`	`public async Task InvalidPropertyNameFail(Type policyType, string offendingProperty)`
`401`	`400`	`{`
`402`	`401`	`var options = new JsonSerializerOptions`
Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,6 @@ public async Task PublicParameterlessCtor_MultiplePublicParameterizedCtors_WithA`
`115`	`115`
`116`	`116`	`#if !BUILDING_SOURCE_GENERATOR_TESTS // These are compile-time warnings from the source generator.`
`117`	`117`	`[Fact]`
`118`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`119`	`118`	`public async Task MultipleAttributes_NotSupported()`
`120`	`119`	`{`
`121`	`120`	`async Task RunTestAsync<T>()`
Original file line number	Diff line number	Diff line change
`@@ -317,7 +317,6 @@ public async Task CaseInsensitiveFails()`
`317`	`317`	`#if BUILDING_SOURCE_GENERATOR_TESTS`
`318`	`318`	`[ActiveIssue("Multi-dim arrays not supported.")]`
`319`	`319`	`#endif`
`320`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`321`	`320`	`public async Task ClassWithUnsupportedCollectionTypes()`
`322`	`321`	`{`
`323`	`322`	`Exception e;`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,6 @@ public async Task CustomNamePolicy()`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`[Fact]`
`67`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`68`	`67`	`public async Task NullNamePolicy()`
`69`	`68`	`{`
`70`	`69`	`var options = new JsonSerializerOptions();`
`@@ -128,7 +127,6 @@ public async Task JsonPropertyNameAttribute()`
`128`	`127`	`}`
`129`	`128`
`130`	`129`	`[Fact]`
`131`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`132`	`130`	`public async Task JsonNameAttributeDuplicateDesignTimeFail()`
`133`	`131`	`{`
`134`	`132`	`{`
`@@ -143,7 +141,6 @@ public async Task JsonNameAttributeDuplicateDesignTimeFail()`
`143`	`141`	`}`
`144`	`142`
`145`	`143`	`[Fact]`
`146`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`147`	`144`	`public async Task JsonNameConflictOnCamelCasingFail()`
`148`	`145`	`{`
`149`	`146`	`{`
Original file line number	Diff line number	Diff line change
`@@ -325,7 +325,6 @@ public class ClassWithMixedPropertyAccessors_PropertyAttributes`
`325`	`325`	`[InlineData(typeof(ClassWithPrivate_InitOnlyProperty_WithJsonIncludeProperty))]`
`326`	`326`	`[InlineData(typeof(ClassWithInternal_InitOnlyProperty_WithJsonIncludeProperty))]`
`327`	`327`	`[InlineData(typeof(ClassWithProtected_InitOnlyProperty_WithJsonIncludeProperty))]`
`328`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`329`	`328`	`public virtual async Task NonPublicProperty_WithJsonInclude_Invalid(Type type)`
`330`	`329`	`{`
`331`	`330`	`InvalidOperationException ex = await Assert.ThrowsAsync<InvalidOperationException>(async () => await Serializer.DeserializeWrapper("{}", type));`
Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,6 @@ public async Task Ignore_PublicProperty_ConflictWithPublicDuePolicy()`
`339`	`339`	`}`
`340`	`340`
`341`	`341`	`[Fact]`
`342`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`343`	`342`	`public async Task Throw_PublicProperty_ConflictDueAttributes()`
`344`	`343`	`{`
`345`	`344`	`// Serialize`
`@@ -354,7 +353,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(`
`354`	`353`	`}`
`355`	`354`
`356`	`355`	`[Fact]`
`357`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`358`	`356`	`public async Task Throw_PublicPropertyAndField_ConflictDueAttributes()`
`359`	`357`	`{`
`360`	`358`	`// Serialize`
`@@ -369,7 +367,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(`
`369`	`367`	`}`
`370`	`368`
`371`	`369`	`[Fact]`
`372`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`373`	`370`	`public async Task Throw_PublicProperty_ConflictDueAttributes_SingleInheritance()`
`374`	`371`	`{`
`375`	`372`	`// Serialize`
`@@ -393,7 +390,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(`
`393`	`390`	`}`
`394`	`391`
`395`	`392`	`[Fact]`
`396`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`397`	`393`	`public async Task Throw_PublicPropertyAndField_ConflictDueAttributes_SingleInheritance()`
`398`	`394`	`{`
`399`	`395`	`// Serialize`
`@@ -417,7 +413,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(`
`417`	`413`	`}`
`418`	`414`
`419`	`415`	`[Fact]`
`420`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`421`	`416`	`public async Task Throw_PublicProperty_ConflictDueAttributes_DoubleInheritance()`
`422`	`417`	`{`
`423`	`418`	`// Serialize`
`@@ -442,7 +437,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(`
`442`	`437`	`}`
`443`	`438`
`444`	`439`	`[Fact]`
`445`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`446`	`440`	`public async Task Throw_PublicPropertyAndField_ConflictDueAttributes_DoubleInheritance()`
`447`	`441`	`{`
`448`	`442`	`// Serialize`
`@@ -467,7 +461,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(`
`467`	`461`	`}`
`468`	`462`
`469`	`463`	`[Fact]`
`470`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`471`	`464`	`public async Task Throw_PublicProperty_ConflictDuePolicy()`
`472`	`465`	`{`
`473`	`466`	`var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase };`
`@@ -484,7 +477,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(`
`484`	`477`	`}`
`485`	`478`
`486`	`479`	`[Fact]`
`487`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`488`	`480`	`public async Task Throw_PublicPropertyAndField_ConflictDuePolicy()`
`489`	`481`	`{`
`490`	`482`	`var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase };`
`@@ -501,7 +493,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(`
`501`	`493`	`}`
`502`	`494`
`503`	`495`	`[Fact]`
`504`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`505`	`496`	`public async Task Throw_PublicProperty_ConflictDuePolicy_SingleInheritance()`
`506`	`497`	`{`
`507`	`498`	`var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase };`
`@@ -528,7 +519,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(`
`528`	`519`	`}`
`529`	`520`
`530`	`521`	`[Fact]`
`531`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`532`	`522`	`public async Task Throw_PublicPropertyAndField_ConflictDuePolicy_SingleInheritance()`
`533`	`523`	`{`
`534`	`524`	`var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase };`
`@@ -555,7 +545,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(`
`555`	`545`	`}`
`556`	`546`
`557`	`547`	`[Fact]`
`558`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`559`	`548`	`public async Task Throw_PublicProperty_ConflictDuePolicy_DobuleInheritance()`
`560`	`549`	`{`
`561`	`550`	`var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase };`
`@@ -583,7 +572,6 @@ await Assert.ThrowsAsync<InvalidOperationException>(`
`583`	`572`	`}`
`584`	`573`
`585`	`574`	`[Fact]`
`586`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`587`	`575`	`public async Task Throw_PublicPropertyAndField_ConflictDuePolicy_DobuleInheritance()`
`588`	`576`	`{`
`589`	`577`	`var options = new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase };`
`@@ -1150,7 +1138,6 @@ public async Task JsonIgnoreAttribute()`
`1150`	`1138`	`// Needs support for more collections.`
`1151`	`1139`	`[ActiveIssue("https://github.com/dotnet/runtime/issues/53393")]`
`1152`	`1140`	`#endif`
`1153`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71981")]`
`1154`	`1141`	`public async Task JsonIgnoreAttribute_UnsupportedCollection()`
`1155`	`1142`	`{`
`1156`	`1143`	`string json =`
`@@ -2426,7 +2413,6 @@ public class ClassWithThingsToIgnore_PerProperty`
`2426`	`2413`	`[Theory]`
`2427`	`2414`	`[InlineData(typeof(ClassWithBadIgnoreAttribute))]`
`2428`	`2415`	`[InlineData(typeof(StructWithBadIgnoreAttribute))]`
`2429`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`2430`	`2416`	`public virtual async Task JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail(Type type)`
`2431`	`2417`	`{`
`2432`	`2418`	`InvalidOperationException ex = await Assert.ThrowsAsync<InvalidOperationException>(async () => await Serializer.DeserializeWrapper("{}", type));`
`@@ -2447,7 +2433,6 @@ public virtual async Task JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail(T`
`2447`	`2433`	`[Theory]`
`2448`	`2434`	`[InlineData(typeof(ClassWithBadIgnoreAttribute))]`
`2449`	`2435`	`[InlineData(typeof(StructWithBadIgnoreAttribute))]`
`2450`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`2451`	`2436`	`public virtual async Task JsonIgnoreCondition_WhenWritingNull_OnValueType_Fail_EmptyJson(Type type)`
`2452`	`2437`	`{`
`2453`	`2438`	`InvalidOperationException ex = await Assert.ThrowsAsync<InvalidOperationException>(async () => await Serializer.DeserializeWrapper("", type));`
`@@ -2760,7 +2745,6 @@ public async Task JsonIgnoreCondition_Polymorphic()`
`2760`	`2745`	`}`
`2761`	`2746`
`2762`	`2747`	`[Fact]`
`2763`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`2764`	`2748`	`public async Task SerializationMetadataNotComputedWhenMemberIgnored()`
`2765`	`2749`	`{`
`2766`	`2750`	`string janePayload = @"{""Name"":""Jane Doe""}";`
Original file line number	Diff line number	Diff line change
`@@ -300,7 +300,6 @@ public PropertyVisibilityTests_Default()`
`300`	`300`	`[InlineData(typeof(ClassWithPrivate_InitOnlyProperty_WithJsonIncludeProperty))]`
`301`	`301`	`[InlineData(typeof(ClassWithInternal_InitOnlyProperty_WithJsonIncludeProperty))]`
`302`	`302`	`[InlineData(typeof(ClassWithProtected_InitOnlyProperty_WithJsonIncludeProperty))]`
`303`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`304`	`303`	`public override async Task NonPublicProperty_WithJsonInclude_Invalid(Type type)`
`305`	`304`	`{`
`306`	`305`	`// Exception messages direct users to use JsonSourceGenerationMode.Metadata to see a more detailed error.`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,6 @@ public void DeserializeInvalidType(Type type)`
`58`	`58`
`59`	`59`	`[Theory]`
`60`	`60`	`[MemberData(nameof(TypesWithInvalidMembers_WithMembers))]`
`61`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`62`	`61`	`public async Task TypeWithInvalidMember(Type classType, Type invalidMemberType, string invalidMemberName)`
`63`	`62`	`{`
`64`	`63`	`static void ValidateException(InvalidOperationException ex, Type classType, Type invalidMemberType, string invalidMemberName)`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,6 @@ public async Task JsonNullNameAttribute()`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`[Fact]`
`25`		`- [ActiveIssue("https://github.com/dotnet/runtime/issues/71838", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]`
`26`	`25`	`public async Task JsonNameConflictOnCaseInsensitiveFail()`
`27`	`26`	`{`
`28`	`27`	`string json = @"{""myInt"":1,""MyInt"":2}";`