Skip to content

Commit fa2d97d

Browse files
authored
Merge branch 'main' into DefineNetStandardRef
2 parents f8fa9c7 + 0377558 commit fa2d97d

File tree

951 files changed

+21941
-8707
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

951 files changed

+21941
-8707
lines changed

.config/dotnet-tools.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
]
1616
},
1717
"microsoft.dotnet.xharness.cli": {
18-
"version": "1.0.0-prerelease.21276.1",
18+
"version": "1.0.0-prerelease.21307.1",
1919
"commands": [
2020
"xharness"
2121
]

docs/area-owners.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Note: Editing this file doesn't update the mapping used by the `@msftbot` issue
1717
| area-Codegen-JIT-mono | @SamMonoRT | @vargaz | |
1818
| area-Codegen-LLVM-mono | @SamMonoRT | @imhameed | |
1919
| area-Codegen-meta-mono | @SamMonoRT | @vargaz | |
20-
| area-CoreLib-mono | @marek-safar | @vargaz | |
20+
| area-CoreLib-mono | @steveisok | @vargaz | |
2121
| area-CrossGen/NGEN-coreclr | @mangod9 | @nattress | |
2222
| area-crossgen2-coreclr | @mangod9 | @nattress @trylek @dotnet/crossgen-contrib | |
2323
| area-Debugger-mono | @lewing | @thaystg @radical | |
@@ -146,6 +146,7 @@ Note: Editing this file doesn't update the mapping used by the `@msftbot` issue
146146
| os-android | @steveisok | @akoeplinger | |
147147
| os-freebsd | | | |
148148
| os-mac-os-x | @steveisok | | |
149+
| os-maccatalyst | @steveisok | | |
149150
| os-ios | @steveisok | @vargaz | |
150151
| os-tvos | @steveisok | @vargaz | |
151152

docs/coding-guidelines/libraries-packaging.md

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ To add a library to the .NETCore shared framework, that library's `AssemblyName`
88

99
The library should have both a `ref` and `src` project. Its reference assembly will be included in the ref-pack for the Microsoft.NETCore.App shared framework, and its implementation assembly will be included in the runtime pack.
1010

11-
Including a library in the shared framework only includes the best applicable TargetFramework build of that library: `$(NetCoreAppCurrent)` if it exists, but possibly `netstandard2.1` or another if that is best. If a library has builds for other frameworks those will only be shipped if the library also produces a [Nuget package](#nuget-package). If a library ships both in the shared framework and a nuget package, it may decide to exclude its latest `$(NetCoreAppCurrent)` build from the package. This can be done by setting `ExcludeCurrentNetCoreAppFromPackage` to true. Libraries should take care when doing this to ensure that whatever asset in the package that would apply to `$(NetCoreAppCurrent)` is functionally equivalent to that which it replaces from the shared framework, to avoid breaking applications which reference a newer package than the shared framework. If possible, it's preferable to avoid this by choosing to target frameworks which can both ship in the package and shared framework.
11+
Including a library in the shared framework only includes the best applicable TargetFramework build of that library: `$(NetCoreAppCurrent)` if it exists, but possibly `netstandard2.1` or another if that is best. If a library has builds for other frameworks those will only be shipped if the library also produces a [Nuget package](#nuget-package).
1212

1313
In some occasions we may want to include a library in the shared framework, but not expose it publicly. To do so, include the library in the `NetCoreAppLibraryNoReference` property in [NetCoreAppLibrary.props](../../src/libraries/NetCoreAppLibrary.props). The library should also be named in a way to discourage use at runtime, for example using the `System.Private` prefix. We should avoid hiding arbitrary public libraries as it complicates deployment and servicing, though some platform specific libraries are in this state due to historical reasons.
1414

@@ -61,13 +61,6 @@ By default all TargetFrameworks listed in your project will be included in the p
6161
</PropertyGroup>
6262
```
6363

64-
A common pattern is to build for the latest .NET version, for example to include a library in the shared framework or a transport package, but then excluded this from the NuGet package. This can be done to avoid growing the NuGet package in size. To do this set
65-
```xml
66-
<PropertyGroup>
67-
<ExcludeCurrentNetCoreAppFromPackage>true</ExcludeCurrentNetCoreAppFromPackage>
68-
</PropertyGroup>
69-
```
70-
7164
When excluding TargetFrameworks from a package special care should be taken to ensure that the builds included are equivalent to those excluded. Avoid ifdef'ing the implementation only in an excluded TargetFramework. Doing so will result in testing something different than what we ship, or shipping a nuget package that degrades the shared framework.
7265

7366
### Build props / targets and other content

0 commit comments

Comments
 (0)