-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7496163
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a248f40
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 5 commits
- 45 files changed
- 5 contributors
Commits on Jul 4, 2022
-
Refactor JsonPropertyInfo initialization infrastructure and implement…
… JsonPropertyInfo.AttributeProvider (#71514) * Implement JsonPropertyInfo.AttributeProvider and refactor initialization infrastructure * Update src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPropertyInfo.cs * Update src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPropertyInfo.cs * _shouldSerializeIsExplicitlySet set to false when setting IgnoreCondition * Reinstante _converterIsExternalAndPolymorphic * Move unique attribute resolution logic to reflection extensions * address feedback
Configuration menu - View commit details
-
Copy full SHA for 32d0360 - Browse repository at this point
Copy the full SHA 32d0360View commit details -
Add Ubuntu 22.04 to libraries CI run (#67345)
This is to help catch OpenSSL 3.0 issues.
Configuration menu - View commit details
-
Copy full SHA for 210a507 - Browse repository at this point
Copy the full SHA 210a507View commit details -
Fix EventPipe profiler recursion in class_loading under full AOT. (#7…
…1610) Happens in full AOT mode where methods have been compiled as direct calls (happens within an assembly). In that case, the method is not known by the runtime (not present in the JIT info table). When a new class is loading, the class_loading profiler callback is called. The EventPipe implementation of that callback will take a stackwalk (inline with CoreCLR behavior), but taking a stackwalk will look up each managed function on the callstack against the JIT info table, if its not there it will load it, that in turn could case additional recursive class_loading event to fire, that will again take the same callstack, ending up in an infinite recursion. The issue is even a little more problematic, since it turns out you cannot do anything inside the class_loading callback that might end up triggering a class load, since that might lead up to recursively loading the same type, that in turn will assert when outer class_loading call returns and tries to add it into the loaded class cache. Fix will harden the stackwalking logic inside EventPipe to detect recursive stackwalks (doing a stackwalk triggering another stackwalk) and if that is the case, the stackwalk will be done using the async_context stackwalking capabilities since that won't trigger any additional profiler events, breaking recursion. Fix also adds logic to the class_loading profiler callback in EventPipe to prevent recursion making sure it won't trigger any additional profiler events, leading up to potential issues loading the same class twice, that will cause an assert inside the class loader logic. For 1:1 mapping of old Mono profiler events issued into EventPipe, they have been aligned with old Mono log profiler events callstack behaviours, meaning it will only emit callstacks on a few limited profiler events, mitigating the issues seen in the runtime profiler provider.
Configuration menu - View commit details
-
Copy full SHA for 15f67a2 - Browse repository at this point
Copy the full SHA 15f67a2View commit details -
[mono][eventpipe] Write primitive types and UTF-16 strings in little …
…endian order (#68648) * [mono][eventpipe] Add big-endian support.
Configuration menu - View commit details
-
Copy full SHA for 136dfcd - Browse repository at this point
Copy the full SHA 136dfcdView commit details
Commits on Jul 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a248f40 - Browse repository at this point
Copy the full SHA a248f40View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 7496163...a248f40