Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ae723b4c8c3f435f0e0162665726447ed3c3e850
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dd5e1491d71a0ef12c439108c64895c5521c3a8a
Choose a head ref
  • 13 commits
  • 115 files changed
  • 14 contributors

Commits on Feb 27, 2024

  1. Fix the new EH with hot-cold split code (#99012)

    The new EH was not taking into account the fact that with hot-cold split
    methods, the offset used for looking up EH funclets need to be computed
    as if the hot and cold regions were consecutive in memory. That have
    caused failures in a number of tests when the tests themselves were
    compiled with R2R and hot-cold split enabled.
    
    Close #98915, #98916, #98917, #98918
    janvorli authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    195fe45 View commit details
    Browse the repository at this point in the history
  2. JIT: ARM64 SVE format encodings, SVE_GG_3A to SVE_GH_3A (#98316)

    * Added format SVE_GG_3A. Other formats in progress.
    
    * Added SVE_GG_3A to SVE_GH_3A formats
    
    * Add comment
    
    * Fix build. Slightly tweaked emitInsSve_R_R_R_I.
    
    * Feedback and merging with main
    
    * Added unreached
    
    * Formatting
    TIHan authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    7b37b90 View commit details
    Browse the repository at this point in the history
  3. Add most x86 ReadyToRunHelperNode/ReadyToRunGenericHelperNode helpers (

    …#98930)
    
    * Add most x86 ReadyToRunHelperNode/ReadyToRunGenericHelperNode helpers
    
    * Apply suggestions from code review
    
    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    
    ---------
    
    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    filipnavara and jkotas authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    012c490 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    81dfdac View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Configuration menu
    Copy the full SHA
    9108d4b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fc8bb88 View commit details
    Browse the repository at this point in the history
  3. JIT: Use successor edges instead of block targets for remaining block…

    … kinds (#98993)
    
    Part of #93020. Replaces BasicBlock::bbTarget/bbFalseTarget/bbTrueTarget with FlowEdge* members.
    amanasifkhalid authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    40d1c89 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    246cda4 View commit details
    Browse the repository at this point in the history
  5. JIT ARM64-SVE: Add AB_3B to EI_3A (#99017)

    Part of #94549. Adds the following encodings:
    
    IF_SVE_AB_3B
    IF_SVE_HL_3B
    IF_SVE_GI_4A
    IF_SVE_HU_4A
    IF_SVE_GC_3A
    IF_SVE_GF_3A
    IF_SVE_GW_3A
    IF_SVE_HK_3A
    IF_SVE_AT_3B
    IF_SVE_AU_3B
    IF_SVE_BD_3B
    IF_SVE_EF_3A
    IF_SVE_EI_3A
    amanasifkhalid authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0ddd579 View commit details
    Browse the repository at this point in the history
  6. Consolidate LINQ's internal IIListProvider/IPartition into base Itera…

    …tor class (#98969)
    
    * Make Grouped{Result}Enumerable derive from Iterator
    
    * Make OrderedPartition derive from Iterator
    
    * Consolidate LINQ's internal IIListProvider/IPartition into base Iterator
    
    LINQ has an internal base Iterator class that's used when operators manually implement enumeration rather than having the compiler implement it with an iterator. That base class includes several abstract/virtual methods, including a Select and Where virtual method that have been present since the beginning of LINQ: those are used in a case of A().B(), where B is Select or Where and where A can then improve the processing of B by returning a customized implementation aware of some aspect of both A and B (e.g. the enumerable returned from .Where().Select() includes both the where and select functionality in that single object). Over the years, other specialization has been added to LINQ, in the form of additional internal interfaces: IIListProvider and IPartition. These interfaces similarly enable optimizing sequences A().B(), where B is other LINQ methods, e.g. IIListProvider enables optimizing ToArray/ToList/Count, and IPartition enables optimizing Skip/Take/First/Last/ElementAt. There was a complicated venn diagram of which types implemented which interfaces and base type.
    
    This PR merges IIListProvider/IPartition into the base Iterator class. Everything from IPartition is virtual, enabling derivations to specialize just a subset of the functionality, and deduplicating some implementations that were providing the same implementation instead of having it shared in a base. Code that was type testing for the interfaces now type tests for the base class, which means we can delete some type testing where both the interfaces and the base class were previously being tested for.  We no longer have this strange split across multiple optimization-focused internal implementation details, and instead have everything consolidated in the one base class. This also means that all of the calls that were previously interface dispatch are now virtual dispatch.
    
    * Rename Partition.SpeedOpt.cs to SkipTake.SpeedOpt.cs
    
    * Address PR feedback, and revert ElementAt bounds check on IList
    
    * Fill some code coverage test holes
    
    * Disable speed-optimized test on wasm
    stephentoub authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    e101ae2 View commit details
    Browse the repository at this point in the history
  7. Update SDK to preview 1 release (#98476)

    * Update SDK to preview 1 release
    
    * Update runtime-prereqs.proj
    
    * Update runtime-prereqs.proj
    
    * Update global-build.yml
    
    * Update global-build.yml
    
    * Update DotNetBuild.props
    
    * Fix getting test list from "dotnet test"
    
    Due to the new vstest terminal logger we didn't get the test list anymore from stdout. Fix by reverting back to the old logger.
    
    * Update PackageInstaller.cs
    
    React to breaking change in NuGet/NuGet.Client@c9b81ab
    
    ---------
    
    Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
    Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
    3 people authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    8303e25 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    81f0e34 View commit details
    Browse the repository at this point in the history
  9. Replace unaligned casts in SpanHelpers.Memmove

    Fix #83709
    IL size is reduced by ~140 bytes.
    xtqqczze committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    dd5e149 View commit details
    Browse the repository at this point in the history
Loading