Skip to content

[Tar] Fill in the file size even if the file is empty. #106409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 23, 2024
Merged

[Tar] Fill in the file size even if the file is empty. #106409

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6713bab
[Tar] Fill in the file size even if the file is empty.
sobczyk Aug 14, 2024
9f8b4c1
fix tests, set size only when datastream is not null
sobczyk Aug 15, 2024
94f3251
Add unit tests for size header of an empty file
sobczyk Aug 21, 2024
d3f301b
Scope disposables
sobczyk Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[Tar] Fill in the file size even if the file is empty. 
This matches standard behavior.
  • Loading branch information
@sobczyk
sobczyk committed Aug 14, 2024
commit 6713babcedbaac73d28e1b32b43b1e80361d2a0f
2 changes: 1 addition & 1 deletion src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ private int WriteCommonFields(Span<byte> buffer, TarEntryType actualEntryType)
checksum += FormatNumeric(_gid, buffer.Slice(FieldLocations.Gid, FieldLengths.Gid));
}

if (_size > 0)
if (_size >= 0)
{
checksum += FormatNumeric(_size, buffer.Slice(FieldLocations.Size, FieldLengths.Size));
}
Expand Down