Skip to content

Conversation

@agocke
Copy link
Member

@agocke agocke commented Dec 10, 2025

(cherry picked from commit eaafd7c) (cherry picked from commit 1905046)

Copilot AI review requested due to automatic review settings December 10, 2025 23:56
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the default macOS build images from macOS 13 to macOS 15 (with Xcode 16) for public builds, and adds test exclusions for Swift interop stress tests that are incompatible with the new environment.

  • Updates public macOS build pool to use 'macos-15' image
  • Adds documentation comment explaining that build platforms should always use the latest available version
  • Excludes Swift ABI stress tests for mono minijit x64 configuration due to known issues on the new platform

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/pipelines/common/xplat-setup.yml Updates public macOS pool from 'macos-13' to 'macos-15' and adds policy comment about using latest platform versions
src/tests/issues.targets Adds test exclusions for Swift interop stress tests (SwiftRetAbiStress and SwiftCallbackAbiStress) for mono minijit x64 configuration, referencing issue #121983

@agocke agocke changed the title Move default build images to macos 15 (and xcode 16) (#120589) [release/8.0] Move default build images to macos 15 (and xcode 16) (#120589) Dec 11, 2025
@agocke agocke added the Servicing-approved Approved for servicing release label Dec 11, 2025
@agocke
Copy link
Member Author

agocke commented Dec 11, 2025

@steveisok it looks like mono build is failing. Any insight?

@steveisok
Copy link
Member

@steveisok it looks like mono build is failing. Any insight?

Taking a look.

@steveisok steveisok requested review from lewing and removed request for lambdageek December 11, 2025 20:26
lambdageek
lambdageek previously approved these changes Dec 11, 2025
Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is cherrypicking from c48aa81

I don't remember the subtleties anymore, but this seems right

@lambdageek lambdageek dismissed their stale review December 11, 2025 22:16

not quite there yet

@lambdageek
Copy link
Member

lambdageek commented Dec 11, 2025

@steveisok I think you also need c48aa81#diff-b2942ad0f35c702862be561fa03e56f885e6b362b4b5522a21e23cc4d9e444ba the aot-compiler.c changes

@lambdageek
Copy link
Member

lambdageek commented Dec 11, 2025

On main this line

MONO_EMIT_NEW_LCOMPARE_IMM (cfg, ins->sreg1, (-(int)2147483648));

has INT_MIN

MONO_EMIT_NEW_LCOMPARE_IMM (cfg, ins->sreg1, INT_MIN);

fixed here:

c85492f

@steveisok
Copy link
Member

fixed here:

c85492f

Thanks!

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@agocke
Copy link
Member Author

agocke commented Jan 7, 2026

From David: this smells like some sort of corruption, not debuggable from a trace. We'll need a dump and probably access to one of the Helix machines + a live repro.

@janvorli
Copy link
Member

janvorli commented Jan 7, 2026

@janvorli does this stack trace look familiar?

@agocke no, it does not. Can you please share a link to the log file from which you've copied that trace? I can try to repro it locally.

@janvorli
Copy link
Member

janvorli commented Jan 9, 2026

I can repro the issue locally executing the bits from the failed run pulled by runfo. And yet it works perfectly fine if I build it locally using exactly the same XCode tools version, repeating exactly the command lines that CI uses to build the stuff on my arm64 mac running the whole build under rosetta so that it matches build on x64 mac.
So it seems to indicate something is wrong with the build machines.
It is hard to reason about the problem using the build from the CI as the libcoreclr.dylib is missing symbols and there is no libcoreclr.dylib.dwarf file.

@janvorli
Copy link
Member

janvorli commented Jan 9, 2026

Update: I can repro it with local build now, I haven't realized libraries tests on macOS use release build of the runtime.

@steveisok
Copy link
Member

Looks like there is a consistent crash in System.Net.Http.Functional.Tests

@steveisok
Copy link
Member

I believe we are running into #97966 as a result of the bump.

@dotnet/ncl can you please confirm? I'd like to move this forward as 8.0 servicing is blocked until we can get this PR in.

@karelz
Copy link
Member

karelz commented Jan 12, 2026

@steveisok do you have details about the reliable crash? @rzikm @wfurt @liveans should be able to help ...

@steveisok
Copy link
Member

@steveisok do you have details about the reliable crash? @rzikm @wfurt @liveans should be able to help ...

I didn't try to get a managed stack yet, but I think the native one gives a pretty good indicator it's the issue I linked to.

Thread 51 Crashed:: .NET TP Worker
0   libsystem_kernel.dylib        	    0x7ff811555846 __pthread_kill + 10
1   libsystem_pthread.dylib       	    0x7ff811590b66 pthread_kill + 259
2   libsystem_c.dylib             	    0x7ff8114af686 __abort + 145
3   libsystem_c.dylib             	    0x7ff8114af5f5 abort + 141
4   libsystem_malloc.dylib        	    0x7ff8113a6ae8 malloc_vreport + 857
5   libsystem_malloc.dylib        	    0x7ff8113aa589 malloc_report + 151
6   GSS                           	    0x7ff8240fce40 _gss_scram_release_cred + 96
7   GSS                           	    0x7ff8240fb873 _gss_scram_delete_sec_context + 83
8   GSS                           	    0x7ff8240c6a36 gss_delete_sec_context + 166
9   GSS                           	    0x7ff8240cc58d _gss_spnego_internal_delete_sec_context + 237
10  GSS                           	    0x7ff8240cc487 _gss_spnego_delete_sec_context + 87
11  GSS                           	    0x7ff8240c6a36 gss_delete_sec_context + 166
12  libSystem.Net.Security.Native.dylib	       0x1a8e23371 NetSecurityNative_DeleteSecContext + 145 (pal_gssapi.c:190)
13  ???                           	       0x109711430 ???

@wfurt
Copy link
Member

wfurt commented Jan 12, 2026

gssapi was buggy on MacOS and we switched to managed implementation for NTLM. But I think we still use it for Kerberos/Negotiate. It seems like the new MacOS has more problems and that will need to be investigated.

@wfurt
Copy link
Member

wfurt commented Jan 12, 2026

ah, it seems like the comment says it was resolved in .NET 9+ #97966
I'm not sure if the managed implementation is complete in 8.0 and ready to be used.

@steveisok
Copy link
Member

ah, it seems like the comment says it was resolved in .NET 9+ #97966 I'm not sure if the managed implementation is complete in 8.0 and ready to be used.

Do you think it's related to gss and not a runtime issue? If so, I think we can move this forward and decide what to do separately.

@agocke
Copy link
Member Author

agocke commented Jan 12, 2026

I think taking this PR, even with System.Net.Http failing, is better than the alternative. We currently have no working Mac builds. At worst we get a Mac build with a bug in one area.

/ba-g Known issue in HTTP tests and dead letter in other queues

@agocke agocke merged commit 8e8c0c7 into dotnet:release/8.0-staging Jan 12, 2026
182 of 190 checks passed
@agocke agocke deleted the 8.0-macos-build-upgrade branch January 12, 2026 18:09
@steveisok
Copy link
Member

I think taking this PR, even with System.Net.Http failing, is better than the alternative. We currently have no working Mac builds. At worst we get a Mac build with a bug in one area.

/ba-g Known issue in HTTP tests and dead letter in other queues

I agree. No complaints from me :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Infrastructure Servicing-approved Approved for servicing release

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants