From 1027c33f5c694ebbdb2803363926ec63fa9fd642 Mon Sep 17 00:00:00 2001 From: lateralusX Date: Wed, 25 Aug 2021 13:58:01 +0200 Subject: [PATCH 1/5] Run runtime tests marked as JitOptimizationSensitive on Mono. --- eng/pipelines/common/templates/runtimes/run-test-job.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/eng/pipelines/common/templates/runtimes/run-test-job.yml b/eng/pipelines/common/templates/runtimes/run-test-job.yml index b5c95aea87157d..63aac7d0999b5f 100644 --- a/eng/pipelines/common/templates/runtimes/run-test-job.yml +++ b/eng/pipelines/common/templates/runtimes/run-test-job.yml @@ -372,8 +372,7 @@ jobs: ${{ if in(parameters.testGroup, 'innerloop', 'outerloop') }}: scenarios: - normal - - ${{ if eq(parameters.runtimeFlavor, 'coreclr') }}: - - no_tiered_compilation + - no_tiered_compilation ${{ if in(parameters.testGroup, 'jitstress') }}: scenarios: From a9f62f54bc6dc106805fef424c66c544cbb065ac Mon Sep 17 00:00:00 2001 From: lateralusX Date: Thu, 26 Aug 2021 14:00:44 +0200 Subject: [PATCH 2/5] Disable failing JIT tailcall test mutual_recursion on Mono. Have never run on Mono in the past and was enabled when enabling running JIT sensetive tests. --- src/tests/issues.targets | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/tests/issues.targets b/src/tests/issues.targets index 3bc046f28e7547..cab25568bb831c 100644 --- a/src/tests/issues.targets +++ b/src/tests/issues.targets @@ -1254,6 +1254,9 @@ needs triage + + needs triage + needs triage From b2c1dd1b779993a9d5d1c3046829e567b0b8d36a Mon Sep 17 00:00:00 2001 From: lateralusX Date: Fri, 27 Aug 2021 11:21:23 +0200 Subject: [PATCH 3/5] Patch CORE_ROOT before building Cross Compiler. Building Cross Compiler will rebuild S.P.C and patching CORE_ROOT after will replace with S.P.C from Cross Compiler build instead of using the one from donwloaded product build. --- .../templates/runtimes/run-test-job.yml | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/eng/pipelines/common/templates/runtimes/run-test-job.yml b/eng/pipelines/common/templates/runtimes/run-test-job.yml index 63aac7d0999b5f..5729e08972efc1 100644 --- a/eng/pipelines/common/templates/runtimes/run-test-job.yml +++ b/eng/pipelines/common/templates/runtimes/run-test-job.yml @@ -283,6 +283,15 @@ jobs: - script: $(Build.SourcesDirectory)/src/tests/build$(scriptExt) generatelayoutonly $(runtimeFlavorArgs) $(crossgenArg) $(buildConfig) $(archType) $(crossArg) $(priorityArg) $(librariesOverrideArg) displayName: Generate CORE_ROOT + # Overwrite coreclr runtime binaries with mono ones + - ${{ if eq(parameters.runtimeFlavor, 'mono') }}: + - script: $(_msbuildCommand) + $(Build.SourcesDirectory)/src/mono/mono.proj + /t:PatchCoreClrCoreRoot + /p:Configuration=$(buildConfigUpper) + /p:TargetArchitecture=$(archType) + displayName: "Patch dotnet with mono" + # Build a Mono LLVM AOT cross-compiler for non-amd64 targets (in this case, just arm64) - ${{ if and(eq(parameters.runtimeFlavor, 'mono'), eq(parameters.runtimeVariant, 'llvmaot')) }}: - ${{ if eq(parameters.archType, 'arm64') }}: @@ -297,16 +306,6 @@ jobs: /p:MonoAOTLLVMUseCxx11Abi=true displayName: "Build Mono LLVM AOT cross compiler" - - # Overwrite coreclr runtime binaries with mono ones - - ${{ if eq(parameters.runtimeFlavor, 'mono') }}: - - script: $(_msbuildCommand) - $(Build.SourcesDirectory)/src/mono/mono.proj - /t:PatchCoreClrCoreRoot - /p:Configuration=$(buildConfigUpper) - /p:TargetArchitecture=$(archType) - displayName: "Patch dotnet with mono" - - ${{ if and(eq(parameters.runtimeFlavor, 'mono'), eq(parameters.runtimeVariant, 'llvmaot')) }}: - ${{ if eq(parameters.archType, 'x64') }}: - script: $(Build.SourcesDirectory)/src/tests/build$(scriptExt) mono_aot $(buildConfig) $(archType) $(runtimeVariantArg) From 972cbd4f135024645b7a69528a633a1d0f175e4e Mon Sep 17 00:00:00 2001 From: lateralusX Date: Fri, 27 Aug 2021 15:00:04 +0200 Subject: [PATCH 4/5] Enable most EventPipe test on default config, exclude more on llvmaot. --- src/tests/issues.targets | 70 ++++++++++++++++++++++++++-------------- 1 file changed, 46 insertions(+), 24 deletions(-) diff --git a/src/tests/issues.targets b/src/tests/issues.targets index cab25568bb831c..41093b0de64829 100644 --- a/src/tests/issues.targets +++ b/src/tests/issues.targets @@ -1550,18 +1550,6 @@ needs triage - - needs triage - - - needs triage - - - needs triage - - - needs triage - needs triage @@ -1589,18 +1577,6 @@ needs triage - - needs triage - - - needs triage - - - needs triage - - - needs triage - Tests coreclr JIT's debug poisoning of address taken variables @@ -2186,6 +2162,52 @@ https://github.com/dotnet/runtime/issues/54113 + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + From 15f2465f3fe37eaca15aa0ff2ba980d000568fc5 Mon Sep 17 00:00:00 2001 From: lateralusX Date: Mon, 30 Aug 2021 11:30:08 +0200 Subject: [PATCH 5/5] Disable a couple of more EventPipe tests on specific configs. --- src/tests/issues.targets | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/tests/issues.targets b/src/tests/issues.targets index 41093b0de64829..a24194f72da785 100644 --- a/src/tests/issues.targets +++ b/src/tests/issues.targets @@ -2163,6 +2163,9 @@ https://github.com/dotnet/runtime/issues/54113 + + needs triage + needs triage @@ -2358,6 +2361,9 @@ needs triage + + needs triage + @@ -2643,6 +2649,9 @@ needs triage + + needs triage + needs triage @@ -2862,6 +2871,9 @@ https://github.com/dotnet/runtime/issues/54974 + + needs triage + https://github.com/dotnet/runtime/issues/53077