From bb73a3876a1bf5d8538482f840c8c7b5b03d9c85 Mon Sep 17 00:00:00 2001 From: Michael Simons Date: Thu, 2 Sep 2021 14:12:27 +0000 Subject: [PATCH 1/3] Conditionally pack symbols based on keepNativeSymbols --- .../System.IO.Ports/pkg/runtime.native.System.IO.Ports.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props b/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props index 557c2231228086..0b757380fc22fb 100644 --- a/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props +++ b/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props @@ -8,7 +8,7 @@ none true $(SymbolsSuffix) - $(TargetsForTfmSpecificDebugSymbolsInPackage);AddRuntimeSpecificNativeSymbolToPackage + $(TargetsForTfmSpecificDebugSymbolsInPackage);AddRuntimeSpecificNativeSymbolToPackage true $(NoWarn);NU5128 From 9065db0c07db29c76696f275a016242b96da16f8 Mon Sep 17 00:00:00 2001 From: Michael Simons Date: Thu, 2 Sep 2021 15:29:16 +0000 Subject: [PATCH 2/3] Fix casing issue --- .../System.IO.Ports/pkg/runtime.native.System.IO.Ports.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props b/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props index 0b757380fc22fb..6907cdbc5d2de7 100644 --- a/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props +++ b/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props @@ -8,7 +8,7 @@ none true $(SymbolsSuffix) - $(TargetsForTfmSpecificDebugSymbolsInPackage);AddRuntimeSpecificNativeSymbolToPackage + $(TargetsForTfmSpecificDebugSymbolsInPackage);AddRuntimeSpecificNativeSymbolToPackage true $(NoWarn);NU5128 From 875ece3507641845c0bde92f59720590e7be6000 Mon Sep 17 00:00:00 2001 From: Michael Simons Date: Thu, 2 Sep 2021 15:35:27 +0000 Subject: [PATCH 3/3] Add clarifing comment --- .../System.IO.Ports/pkg/runtime.native.System.IO.Ports.props | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props b/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props index 6907cdbc5d2de7..dd4aff2fd0e456 100644 --- a/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props +++ b/src/libraries/System.IO.Ports/pkg/runtime.native.System.IO.Ports.props @@ -8,6 +8,7 @@ none true $(SymbolsSuffix) + $(TargetsForTfmSpecificDebugSymbolsInPackage);AddRuntimeSpecificNativeSymbolToPackage true