From a07555df9d4c91bf083c83b8c79add1312d6cd74 Mon Sep 17 00:00:00 2001 From: Dan Moseley Date: Fri, 21 Jan 2022 13:39:19 -0700 Subject: [PATCH 1/2] Re-enable path too long test --- .../System.IO.FileSystem/tests/Directory/CreateDirectory.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libraries/System.IO.FileSystem/tests/Directory/CreateDirectory.cs b/src/libraries/System.IO.FileSystem/tests/Directory/CreateDirectory.cs index ae0f89d32da08d..c3869a14390940 100644 --- a/src/libraries/System.IO.FileSystem/tests/Directory/CreateDirectory.cs +++ b/src/libraries/System.IO.FileSystem/tests/Directory/CreateDirectory.cs @@ -271,8 +271,10 @@ public void DirectoryLongerThanMaxLongPathWithExtendedSyntax_ThrowsException() { var paths = IOInputs.GetPathsLongerThanMaxLongPath(GetTestFilePath(), useExtendedSyntax: true); + // Ideally this should be PathTooLongException or DirectoryNotFoundException but on some machines + // windows gives us ERROR_INVALID_NAME, producing IOException. Assert.All(paths, path => - AssertExtensions.ThrowsAny(() => Create(path))); + AssertExtensions.ThrowsAny(() => Create(path))); } [ConditionalFact(nameof(LongPathsAreNotBlocked), nameof(UsingNewNormalization))] From 07ead81ec217baa72fa85c22a240fa8b34d8da9e Mon Sep 17 00:00:00 2001 From: Dan Moseley Date: Fri, 21 Jan 2022 13:41:05 -0700 Subject: [PATCH 2/2] enable --- .../System.IO.FileSystem/tests/Directory/CreateDirectory.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/System.IO.FileSystem/tests/Directory/CreateDirectory.cs b/src/libraries/System.IO.FileSystem/tests/Directory/CreateDirectory.cs index c3869a14390940..4e53a93a4e03a9 100644 --- a/src/libraries/System.IO.FileSystem/tests/Directory/CreateDirectory.cs +++ b/src/libraries/System.IO.FileSystem/tests/Directory/CreateDirectory.cs @@ -264,7 +264,6 @@ public void DirectoryLongerThanMaxLongPath_ThrowsPathTooLongException() }); } - [ActiveIssue("https://github.com/dotnet/runtime/issues/64019")] [ConditionalFact(nameof(LongPathsAreNotBlocked), nameof(UsingNewNormalization))] [PlatformSpecific(TestPlatforms.Windows)] public void DirectoryLongerThanMaxLongPathWithExtendedSyntax_ThrowsException()