From f194ba70475192fd964b4e3412c1aae3817a879a Mon Sep 17 00:00:00 2001 From: Seeker186 <101211595+Seeker186@users.noreply.github.com> Date: Wed, 20 Jul 2022 16:43:25 -0700 Subject: [PATCH 1/2] Added a note emphasizing Libraries have to be built in Release mode to generate the Core_Root. --- docs/workflow/building/coreclr/linux-instructions.md | 5 +++-- docs/workflow/building/coreclr/osx-instructions.md | 4 +++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/docs/workflow/building/coreclr/linux-instructions.md b/docs/workflow/building/coreclr/linux-instructions.md index f4166f0f0e49df..09580d0e3fc73e 100644 --- a/docs/workflow/building/coreclr/linux-instructions.md +++ b/docs/workflow/building/coreclr/linux-instructions.md @@ -87,8 +87,9 @@ After the build is completed, there should some files placed in `artifacts/bin/c Create the Core_Root =================== -The Core_Root folder will contain the built binaries, generated by `build.sh`, as well as the library packages required to run tests. Note that you need to build -the libraries subset (`-subset libs`) before this command can be run. +The Core_Root folder will contain the built binaries, generated by `build.sh`, as well as the library packages required to run tests. It is required that you build +the libraries subset in Release mode (`-subset libs -c Release`) before this command can be run. Note that the Release Libraries are required, regardless of which +runtime configuration you want to use for your Core_Root. ``` ./src/tests/build.sh generatelayoutonly diff --git a/docs/workflow/building/coreclr/osx-instructions.md b/docs/workflow/building/coreclr/osx-instructions.md index 41e8d87de1a7ec..78b13752cb45cc 100644 --- a/docs/workflow/building/coreclr/osx-instructions.md +++ b/docs/workflow/building/coreclr/osx-instructions.md @@ -26,7 +26,9 @@ After the build has completed, there should some files placed in `artifacts/bin/ Create the Core_Root =================== -The Core_Root folder will have the built binaries, from `src/coreclr/build.sh` and it will also include the CoreFX packages required to run tests. +The Core_Root folder will contain the built binaries, generated by `build.sh`, as well as the library packages required to run tests. It is required that you build +the libraries subset in Release mode (`-subset libs -c Release`) before this command can be run. Note that the Release Libraries are required, regardless of which +runtime configuration you want to use for your Core_Root. ``` ./src/tests/build.sh generatelayoutonly From e2bd23ed06566e90c98d8c0107a28de9e9af825d Mon Sep 17 00:00:00 2001 From: Seeker186 <101211595+Seeker186@users.noreply.github.com> Date: Thu, 21 Jul 2022 13:41:35 -0700 Subject: [PATCH 2/2] Corrected a statement regarding libraries' configuration. --- docs/workflow/building/coreclr/linux-instructions.md | 4 ++-- docs/workflow/building/coreclr/osx-instructions.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/workflow/building/coreclr/linux-instructions.md b/docs/workflow/building/coreclr/linux-instructions.md index 09580d0e3fc73e..dac415c3da1b52 100644 --- a/docs/workflow/building/coreclr/linux-instructions.md +++ b/docs/workflow/building/coreclr/linux-instructions.md @@ -88,8 +88,8 @@ Create the Core_Root =================== The Core_Root folder will contain the built binaries, generated by `build.sh`, as well as the library packages required to run tests. It is required that you build -the libraries subset in Release mode (`-subset libs -c Release`) before this command can be run. Note that the Release Libraries are required, regardless of which -runtime configuration you want to use for your Core_Root. +the libraries subset (`-subset libs`) before this command can be run. Note that this by default searches the libraries in Release mode, regardless of the runtime +configuration you specify. If you built your libs in another configuration, then you have to pass down the appropriate flag `/p:LibrariesConfiguration=`. ``` ./src/tests/build.sh generatelayoutonly diff --git a/docs/workflow/building/coreclr/osx-instructions.md b/docs/workflow/building/coreclr/osx-instructions.md index 78b13752cb45cc..283dab9ac68862 100644 --- a/docs/workflow/building/coreclr/osx-instructions.md +++ b/docs/workflow/building/coreclr/osx-instructions.md @@ -27,8 +27,8 @@ Create the Core_Root =================== The Core_Root folder will contain the built binaries, generated by `build.sh`, as well as the library packages required to run tests. It is required that you build -the libraries subset in Release mode (`-subset libs -c Release`) before this command can be run. Note that the Release Libraries are required, regardless of which -runtime configuration you want to use for your Core_Root. +the libraries subset (`-subset libs`) before this command can be run. Note that this by default searches the libraries in Release mode, regardless of the runtime +configuration you specify. If you built your libs in another configuration, then you have to pass down the appropriate flag `/p:LibrariesConfiguration=`. ``` ./src/tests/build.sh generatelayoutonly