From 6e00ad2756b1f8021734ad37ad708092d254c1b5 Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Thu, 21 Jul 2022 10:54:57 -0400 Subject: [PATCH 1/2] Disable NamedPipeTest_ServerInOut_ClientInOut_Synchronous test configuration This variation was named pipes stream conformance tests was just introduced and appears to be unstable, resulting in multiple tests hanging frequently. --- .../tests/PipeStreamConformanceTests.cs | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs b/src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs index dd68ad0b4867d6..b9417e3404cd93 100644 --- a/src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs +++ b/src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs @@ -804,15 +804,12 @@ public sealed class NamedPipeTest_ServerIn_ClientOut_Asynchronous : NamedPipeTes protected override PipeOptions Options => PipeOptions.Asynchronous; } - public sealed class NamedPipeTest_ServerInOut_ClientInOut_Synchronous : NamedPipeTest_ServerInOut_ClientInOut - { - protected override PipeOptions Options => PipeOptions.None; - - // TODO https://github.com/dotnet/runtime/issues/72526: - // The ConcurrentBidirectionalReadsWrites_Success test hangs on Windows with PipeOptions.None and InOut named pipes. - // Disabling for now. - protected override bool SupportsConcurrentBidirectionalUse => !OperatingSystem.IsWindows(); - } + // [ActiveIssue("https://github.com/dotnet/runtime/issues/72526")] + // Multiple tests hang in this configuration. + //public sealed class NamedPipeTest_ServerInOut_ClientInOut_Synchronous : NamedPipeTest_ServerInOut_ClientInOut + //{ + // protected override PipeOptions Options => PipeOptions.None; + //} public sealed class NamedPipeTest_ServerInOut_ClientInOut_Asynchronous : NamedPipeTest_ServerInOut_ClientInOut { From bc3f8ea0473ef01f503a7e15d9c22925373c9400 Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Thu, 21 Jul 2022 11:46:22 -0400 Subject: [PATCH 2/2] Update PipeStreamConformanceTests.cs --- .../tests/PipeStreamConformanceTests.cs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs b/src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs index b9417e3404cd93..1073cf37771d51 100644 --- a/src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs +++ b/src/libraries/System.IO.Pipes/tests/PipeStreamConformanceTests.cs @@ -804,12 +804,11 @@ public sealed class NamedPipeTest_ServerIn_ClientOut_Asynchronous : NamedPipeTes protected override PipeOptions Options => PipeOptions.Asynchronous; } - // [ActiveIssue("https://github.com/dotnet/runtime/issues/72526")] - // Multiple tests hang in this configuration. - //public sealed class NamedPipeTest_ServerInOut_ClientInOut_Synchronous : NamedPipeTest_ServerInOut_ClientInOut - //{ - // protected override PipeOptions Options => PipeOptions.None; - //} + [ActiveIssue("https://github.com/dotnet/runtime/issues/72526")] + public sealed class NamedPipeTest_ServerInOut_ClientInOut_Synchronous : NamedPipeTest_ServerInOut_ClientInOut + { + protected override PipeOptions Options => PipeOptions.None; + } public sealed class NamedPipeTest_ServerInOut_ClientInOut_Asynchronous : NamedPipeTest_ServerInOut_ClientInOut {