From 7bfbbcedaab05c1950fd5454cd08abf4b946f868 Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Fri, 3 Feb 2023 18:15:13 +0100 Subject: [PATCH 01/18] Adjust Native AOT build integration targets to include ios and iossimulator --- ...soft.DotNet.ILCompiler.SingleEntry.targets | 2 ++ .../Microsoft.NETCore.Native.targets | 29 ++++++++++--------- 2 files changed, 18 insertions(+), 13 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets index 1fae5ebf4d444f..e02b65bd505f12 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets @@ -4,6 +4,8 @@ win osx + ios + iossimulator freebsd linux-musl linux diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets index 5caefcd10b26f1..154ec115be4657 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets @@ -17,12 +17,14 @@ The .NET Foundation licenses this file to you under the MIT license. Shared - $(IntermediateOutputPath)native\ - $(OutputPath)native\ + $(IntermediateOutputPath)obj\native\ + $(OutputPath)obj\native\ true $(MSBuildThisFileDirectory)..\tools\netstandard\ILCompiler.Build.Tasks.dll windows osx + ios + iossimulator freebsd linux true @@ -63,14 +65,14 @@ The .NET Foundation licenses this file to you under the MIT license. .exe .dll - .dylib - .so + .dylib + .so .lib .a - .dwarf + .dwarf .pdb - .dbg + .dbg .def .exports @@ -196,6 +198,7 @@ The .NET Foundation licenses this file to you under the MIT license. + @@ -304,12 +307,12 @@ The .NET Foundation licenses this file to you under the MIT license. - - + + - + @@ -324,8 +327,8 @@ The .NET Foundation licenses this file to you under the MIT license. <_IgnoreLinkerWarnings>false - <_IgnoreLinkerWarnings Condition="'$(TargetOS)' == 'osx'">true - -x + <_IgnoreLinkerWarnings Condition="'$(TargetOS)' == 'osx' or '$(TargetOS)' == 'ios' or '$(TargetOS)' == 'iossimulator'">true + -x @@ -340,13 +343,13 @@ The .NET Foundation licenses this file to you under the MIT license. - - From 28412d768b04876d47e910b79734f8e4cb359b8e Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Tue, 14 Feb 2023 11:48:12 +0100 Subject: [PATCH 02/18] Resolve conflicts --- .../BuildIntegration/Microsoft.NETCore.Native.targets | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets index 154ec115be4657..ebe9fe981291d2 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets @@ -17,8 +17,8 @@ The .NET Foundation licenses this file to you under the MIT license. Shared - $(IntermediateOutputPath)obj\native\ - $(OutputPath)obj\native\ + $(IntermediateOutputPath)native\ + $(OutputPath)native\ true $(MSBuildThisFileDirectory)..\tools\netstandard\ILCompiler.Build.Tasks.dll windows @@ -198,7 +198,6 @@ The .NET Foundation licenses this file to you under the MIT license. - From 9c7e5d89605532ff333c0facc9d097fb4968e97f Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Tue, 14 Feb 2023 12:29:53 +0100 Subject: [PATCH 03/18] Fix TargetOS for iossimulator in build integration targets --- .../nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets index ebe9fe981291d2..72492713ffb23a 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets @@ -24,7 +24,7 @@ The .NET Foundation licenses this file to you under the MIT license. windows osx ios - iossimulator + iossimulator freebsd linux true From e1c255d128ce4d51c1e13463d51c1edeb1d8e54b Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Tue, 14 Feb 2023 14:37:49 +0100 Subject: [PATCH 04/18] Revert conditions for linux targets --- .../BuildIntegration/Microsoft.NETCore.Native.targets | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets index 72492713ffb23a..caab6ea0de3400 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets @@ -66,13 +66,13 @@ The .NET Foundation licenses this file to you under the MIT license. .dll .dylib - .so + .so .lib .a .dwarf .pdb - .dbg + .dbg .def .exports @@ -307,11 +307,11 @@ The .NET Foundation licenses this file to you under the MIT license. - + - + @@ -342,7 +342,7 @@ The .NET Foundation licenses this file to you under the MIT license. - + <_IsApplePlatform Condition="'$(TargetOS)' == 'osx' or $(TargetOS.StartsWith('ios'))">true - gcc + gcc clang $(CppCompilerAndLinker) ar - --flat - <_SymbolPrefix Condition="'$(TargetOS)' == 'osx'">_ + --flat + <_SymbolPrefix Condition="'$(_IsApplePlatform)' == 'true'">_ true @@ -35,16 +36,16 @@ The .NET Foundation licenses this file to you under the MIT license. x86_64 - aarch64 - arm64 + aarch64 + arm64 $(CrossCompileArch)-linux-gnu $(CrossCompileArch)-alpine-linux-musl $(CrossCompileArch)-unknown-freebsd12 - $ORIGIN - @executable_path + $ORIGIN + @executable_path libeventpipe-disabled libeventpipe-enabled @@ -66,7 +67,7 @@ The .NET Foundation licenses this file to you under the MIT license. - + @@ -100,7 +101,7 @@ The .NET Foundation licenses this file to you under the MIT license. - + @@ -112,40 +113,40 @@ The .NET Foundation licenses this file to you under the MIT license. - - + + - + - - - - + + + + - - - + + + - - - + + + - - + + - - + + - + - - + + - + @@ -173,24 +174,24 @@ The .NET Foundation licenses this file to you under the MIT license. <_WhereLinker>0 - + objcopy llvm-objcopy objcopy - + - - + - + @@ -201,16 +202,16 @@ The .NET Foundation licenses this file to you under the MIT license. - - + - - + @@ -220,7 +221,7 @@ The .NET Foundation licenses this file to you under the MIT license. - + $(DsymUtilOptions) --minimize diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets index caab6ea0de3400..140eb200063c00 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets @@ -32,6 +32,7 @@ The .NET Foundation licenses this file to you under the MIT license. false true false + <_IsApplePlatform Condition="'$(TargetOS)' == 'osx' or $(TargetOS.StartsWith('ios'))">true @@ -65,14 +66,14 @@ The .NET Foundation licenses this file to you under the MIT license. .exe .dll - .dylib - .so + .dylib + .so .lib .a - .dwarf + .dwarf .pdb - .dbg + .dbg .def .exports @@ -306,12 +307,12 @@ The .NET Foundation licenses this file to you under the MIT license. - - + + - + @@ -326,8 +327,8 @@ The .NET Foundation licenses this file to you under the MIT license. <_IgnoreLinkerWarnings>false - <_IgnoreLinkerWarnings Condition="'$(TargetOS)' == 'osx' or '$(TargetOS)' == 'ios' or '$(TargetOS)' == 'iossimulator'">true - -x + <_IgnoreLinkerWarnings Condition="'$(_IsApplePlatform)' == 'true'">true + -x @@ -342,13 +343,13 @@ The .NET Foundation licenses this file to you under the MIT license. - - From 1acfce50eaa2bbcfdd227c96be47d9665471058a Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Wed, 15 Feb 2023 11:12:03 +0100 Subject: [PATCH 06/18] Add tvos, tvossimulator, and maccatalyst to _IsApplePlatform --- .../BuildIntegration/Microsoft.NETCore.Native.Unix.targets | 2 +- .../nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets index 0db2a09494dc65..42e8732a41639a 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets @@ -14,7 +14,7 @@ The .NET Foundation licenses this file to you under the MIT license. --> - <_IsApplePlatform Condition="'$(TargetOS)' == 'osx' or $(TargetOS.StartsWith('ios'))">true + <_IsApplePlatform Condition="'$(TargetOS)' == 'osx' or '$(TargetOS)' == 'maccatalyst' or $(TargetOS.StartsWith('ios')) or $(TargetOS.StartsWith('tvos'))">true gcc clang diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets index 140eb200063c00..3c44f118869f2f 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets @@ -32,7 +32,7 @@ The .NET Foundation licenses this file to you under the MIT license. false true false - <_IsApplePlatform Condition="'$(TargetOS)' == 'osx' or $(TargetOS.StartsWith('ios'))">true + <_IsApplePlatform Condition="'$(TargetOS)' == 'osx' or '$(TargetOS)' == 'maccatalyst' or $(TargetOS.StartsWith('ios')) or $(TargetOS.StartsWith('tvos'))">true From 9dd50675eefba6625adcf58b9ce75bf36f103526 Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Wed, 15 Feb 2023 13:15:13 +0100 Subject: [PATCH 07/18] Remove _IsApplePlatform from Native.Unix.targets --- .../BuildIntegration/Microsoft.NETCore.Native.Unix.targets | 1 - 1 file changed, 1 deletion(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets index 42e8732a41639a..80f19c6d24014b 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets @@ -14,7 +14,6 @@ The .NET Foundation licenses this file to you under the MIT license. --> - <_IsApplePlatform Condition="'$(TargetOS)' == 'osx' or '$(TargetOS)' == 'maccatalyst' or $(TargetOS.StartsWith('ios')) or $(TargetOS.StartsWith('tvos'))">true gcc clang From 8363dc5c7b071b43dc5e449939bdfba5f690061a Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Wed, 15 Feb 2023 15:19:27 +0100 Subject: [PATCH 08/18] Add a condition to OSIdentifier to respect the order of the checks --- .../Microsoft.DotNet.ILCompiler.SingleEntry.targets | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets index e02b65bd505f12..1828d91f386f63 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets @@ -2,12 +2,12 @@ - win - osx - ios - iossimulator - freebsd - linux-musl + win + osx + ios + iossimulator + freebsd + linux-musl linux From efb53b568e446ae6fda6a6563800a80a096e7984 Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Wed, 15 Feb 2023 15:24:21 +0100 Subject: [PATCH 09/18] Update src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets Co-authored-by: Filip Navara --- .../Microsoft.DotNet.ILCompiler.SingleEntry.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets index 1828d91f386f63..a49c673eb67e49 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets @@ -4,8 +4,8 @@ win osx - ios iossimulator + ios freebsd linux-musl linux From 25df2fc7cfb69c21a7814effd6f339f72a4a6f78 Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Wed, 15 Feb 2023 16:17:36 +0100 Subject: [PATCH 10/18] Update src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> --- .../BuildIntegration/Microsoft.NETCore.Native.targets | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets index 065b489ca67df5..9985640b2efd24 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets @@ -23,8 +23,11 @@ The .NET Foundation licenses this file to you under the MIT license. $(MSBuildThisFileDirectory)..\tools\netstandard\ILCompiler.Build.Tasks.dll windows osx - ios + maccatalyst iossimulator + ios + tvossimulator + tvos freebsd linux true From 6e6765638320a8d994d08bc5b1c623bb25e68999 Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Wed, 15 Feb 2023 16:17:43 +0100 Subject: [PATCH 11/18] Update src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> --- .../Microsoft.DotNet.ILCompiler.SingleEntry.targets | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets index a49c673eb67e49..424cada8a544c7 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets @@ -4,8 +4,11 @@ win osx + maccatalyst iossimulator ios + tvossimulator + tvos freebsd linux-musl linux From 70126502db6de91cd3f8b8ecc4e89bf6fa6a0e57 Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Wed, 15 Feb 2023 19:30:01 +0100 Subject: [PATCH 12/18] Update src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> --- .../Microsoft.DotNet.ILCompiler.SingleEntry.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets index 424cada8a544c7..21df8496d17f55 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets @@ -10,7 +10,7 @@ tvossimulator tvos freebsd - linux-musl + linux-musl linux From a3035e5fb030ea19e9795a6bb51565ca80f67010 Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Thu, 16 Feb 2023 15:27:59 +0100 Subject: [PATCH 13/18] Exclude for tvOS[simulator] --- .../BuildIntegration/Microsoft.NETCore.Native.Unix.targets | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets index bf80ba2d37cfc7..17bafc5753a300 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets @@ -105,7 +105,8 @@ The .NET Foundation licenses this file to you under the MIT license. - + + From ee8832ad15fb2412a2f458e200696c1876f74761 Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Thu, 16 Feb 2023 16:17:19 +0100 Subject: [PATCH 14/18] Exclude System.Globalization.Native and System.Security.Cryptography.Native.OpenSsl for iOS platforms --- .../BuildIntegration/Microsoft.NETCore.Native.Unix.targets | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets index 17bafc5753a300..56c512d9b74023 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets @@ -63,11 +63,13 @@ The .NET Foundation licenses this file to you under the MIT license. - + + - + + From 675b5a057272279b20d66ccaf72114eabc84c6f0 Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Thu, 16 Feb 2023 16:17:58 +0100 Subject: [PATCH 15/18] Fix tvOS condition for GSS --- .../BuildIntegration/Microsoft.NETCore.Native.Unix.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets index 56c512d9b74023..bacbcd3e47b2f6 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets @@ -108,7 +108,7 @@ The .NET Foundation licenses this file to you under the MIT license. - + From 32833727876125b5b2efe359a4a15d7544debf77 Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Thu, 16 Feb 2023 16:33:00 +0100 Subject: [PATCH 16/18] Exclude System.Globalization.Native and System.Security.Cryptography.Native.OpenSsl for iOSLike platforms --- .../BuildIntegration/Microsoft.NETCore.Native.Unix.targets | 4 ++-- .../BuildIntegration/Microsoft.NETCore.Native.targets | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets index bacbcd3e47b2f6..d7b888288f858d 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets @@ -64,12 +64,12 @@ The .NET Foundation licenses this file to you under the MIT license. - + - + diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets index 9985640b2efd24..3882bd6b71a64f 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets @@ -35,7 +35,8 @@ The .NET Foundation licenses this file to you under the MIT license. false true false - <_IsApplePlatform Condition="'$(TargetOS)' == 'osx' or '$(TargetOS)' == 'maccatalyst' or $(TargetOS.StartsWith('ios')) or $(TargetOS.StartsWith('tvos'))">true + <_IsiOSLikePlatform Condition="'$(TargetOS)' == 'maccatalyst' or $(TargetOS.StartsWith('ios')) or $(TargetOS.StartsWith('tvos'))">true + <_IsApplePlatform Condition="'$(TargetOS)' == 'osx' or '$(_IsiOSLikePlatform)' == 'true'">true From 407edf3e4213d4d7958ab5bd8814df2e96421a58 Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Fri, 17 Feb 2023 11:14:51 +0100 Subject: [PATCH 17/18] Add condition to TargetOS property --- .../Microsoft.NETCore.Native.targets | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets index 3882bd6b71a64f..a1f03c0a6d2ed9 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets @@ -21,14 +21,14 @@ The .NET Foundation licenses this file to you under the MIT license. $(OutputPath)native\ true $(MSBuildThisFileDirectory)..\tools\netstandard\ILCompiler.Build.Tasks.dll - windows - osx - maccatalyst - iossimulator - ios - tvossimulator - tvos - freebsd + windows + osx + maccatalyst + iossimulator + ios + tvossimulator + tvos + freebsd linux true From f2b51ecd3be26baf6759041cb180c8df0ba85b6a Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Fri, 17 Feb 2023 11:18:18 +0100 Subject: [PATCH 18/18] Update tvOS condition --- .../BuildIntegration/Microsoft.NETCore.Native.Unix.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets index d7b888288f858d..0d6271a0fae15b 100644 --- a/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets +++ b/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets @@ -108,7 +108,7 @@ The .NET Foundation licenses this file to you under the MIT license. - +