Skip to content

Commit 0a6301c

Browse files
authored
Remove ILLink version override workaround (#31551)
1 parent 3e643ca commit 0a6301c

File tree

2 files changed

+3
-11
lines changed

2 files changed

+3
-11
lines changed

src/Layout/redist/targets/OverlaySdkOnLKG.targets

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@
6262
<OverrideAndCreateBundledNETCoreAppPackageVersion
6363
Stage0MicrosoftNETCoreAppRefPackageVersionPath="$(_DotNetHiveRoot)/sdk/$(Stage0SdkVersion)/Microsoft.NETCoreSdk.BundledVersions.props"
6464
MicrosoftNETCoreAppRefPackageVersion="$(MicrosoftNETCoreAppRefPackageVersion)"
65-
MicrosoftNETILLinkTasksPackageVersion="$(MicrosoftNETILLinkTasksPackageVersion)"
6665
NewSDKVersion="$(Version)"
6766
OutputPath="$(SdkOutputDirectory)/Microsoft.NETCoreSdk.BundledVersions.props"/>
6867

src/Layout/toolset-tasks/OverrideAndCreateBundledNETCoreAppPackageVersion.cs

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Licensed to the .NET Foundation under one or more agreements.
1+
// Licensed to the .NET Foundation under one or more agreements.
22
// The .NET Foundation licenses this file to you under the MIT license.
33
// See the LICENSE file in the project root for more information.
44

@@ -36,10 +36,6 @@ public sealed class OverrideAndCreateBundledNETCoreAppPackageVersion : Task
3636

3737
[Required] public string MicrosoftNETCoreAppRefPackageVersion { get; set; }
3838

39-
// TODO: remove this once linker packages are produced from dotnet/runtime
40-
// and replace it with MicrosoftNETCoreAppRefPackageVersion.
41-
[Required] public string MicrosoftNETILLinkTasksPackageVersion { get; set; }
42-
4339
[Required] public string NewSDKVersion { get; set; }
4440

4541
[Required] public string OutputPath { get; set; }
@@ -50,15 +46,13 @@ public override bool Execute()
5046
ExecuteInternal(
5147
File.ReadAllText(Stage0MicrosoftNETCoreAppRefPackageVersionPath),
5248
MicrosoftNETCoreAppRefPackageVersion,
53-
MicrosoftNETILLinkTasksPackageVersion,
5449
NewSDKVersion));
5550
return true;
5651
}
5752

5853
public static string ExecuteInternal(
5954
string stage0MicrosoftNETCoreAppRefPackageVersionContent,
6055
string microsoftNETCoreAppRefPackageVersion,
61-
string microsoftNETILLinkTasksPackageVersion,
6256
string newSDKVersion)
6357
{
6458
var projectXml = XDocument.Parse(stage0MicrosoftNETCoreAppRefPackageVersionContent);
@@ -123,9 +117,8 @@ void CheckAndReplaceAttribute(XAttribute attribute)
123117
.Elements(ns + "KnownCrossgen2Pack").First().Attribute("Crossgen2PackVersion"));
124118
CheckAndReplaceAttribute(itemGroup
125119
.Elements(ns + "KnownILCompilerPack").First().Attribute("ILCompilerPackVersion"));
126-
127-
// TODO: replace this with CheckAndReplaceAttribute once linker packages are produced from dotnet/runtime.
128-
itemGroup.Elements(ns + "KnownILLinkPack").First().Attribute("ILLinkPackVersion").Value = microsoftNETILLinkTasksPackageVersion;
120+
CheckAndReplaceAttribute(itemGroup
121+
.Elements(ns + "KnownILLinkPack").First().Attribute("ILLinkPackVersion"));
129122

130123
CheckAndReplaceAttribute(itemGroup
131124
.Elements(ns + "KnownRuntimePack").First().Attribute("LatestRuntimeFrameworkVersion"));

0 commit comments

Comments
 (0)