diff --git a/src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/Macros/Config/GeneratePortNumberConfig.cs b/src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/Macros/Config/GeneratePortNumberConfig.cs index 1c5fe874558..0ad7b6d4e33 100644 --- a/src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/Macros/Config/GeneratePortNumberConfig.cs +++ b/src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/Macros/Config/GeneratePortNumberConfig.cs @@ -10,17 +10,31 @@ namespace Microsoft.TemplateEngine.Orchestrator.RunnableProjects.Macros.Config { internal class GeneratePortNumberConfig : IMacroConfig { + // sources of unsafe ports: + // * chrome: https://chromium.googlesource.com/chromium/src.git/+/refs/heads/master/net/base/port_util.cc#27 + // * firefox: https://www-archive.mozilla.org/projects/netlib/portbanning#portlist + // * safari: https://github.com/WebKit/WebKit/blob/42f5a93823a7f087a800cd65c6bc0551dbeb55d3/Source/WTF/wtf/URL.cpp#L969 private static readonly HashSet UnsafePorts = new HashSet() { - 2049, // nfs - 3659, // apple-sasl / PasswordServer - 4045, // lockd - 6000, // X11 - 6665, // Alternate IRC [Apple addition] - 6666, // Alternate IRC [Apple addition] - 6667, // Standard IRC [Apple addition] - 6668, // Alternate IRC [Apple addition] - 6669, // Alternate IRC [Apple addition] + 1719, // H323 (RAS) + 1720, // H323 (Q931) + 1723, // H323 (H245) + 2049, // NFS + 3659, // apple-sasl / PasswordServer [Apple addition] + 4045, // lockd + 4190, // ManageSieve [Apple addition] + 5060, // SIP + 5061, // SIPS + 6000, // X11 + 6566, // SANE + 6665, // Alternate IRC [Apple addition] + 6666, // Alternate IRC [Apple addition] + 6667, // Standard IRC [Apple addition] + 6668, // Alternate IRC [Apple addition] + 6669, // Alternate IRC [Apple addition] + 6679, // Alternate IRC SSL [Apple addition] + 6697, // IRC+SSL [Apple addition] + 10080, // amanda }; internal GeneratePortNumberConfig(string variableName, string? dataType, int fallback, int low, int high)