Fix/accss fixes (wix#634)

* Deleted unneeded button icon accessibilityRole

* Switch accessibility fix

* Switch accessibility fix

* Added  accessibilityRole to PickerDialog's done and cancel buttons

Author: ArnonZ

src/components/picker/PickerDialog.android.js

@@ -56,10 +56,10 @@ class PickerDialog extends BaseComponent {
 
     return (
       <View style={styles.footer}>
-        <Text text80 blue30 onPress={onCancel} style={cancelLabelStyle}>
+        <Text text80 blue30 onPress={onCancel} accessibilityRole={onCancel ? 'button' : undefined} style={cancelLabelStyle}>
           {cancelLabel}
         </Text>
-        <Text text80 blue30 marginL-15 onPress={onDone} style={selectLabelStyle}>
+        <Text text80 blue30 marginL-15 onPress={onDone} accessibilityRole={onDone ? 'button' : undefined} style={selectLabelStyle}>
           {doneLabel}
         </Text>
       </View>

src/components/picker/PickerDialog.ios.js

@@ -27,10 +27,10 @@ class PickerDialog extends BaseComponent {
 
     return (
       <View style={styles.header}>
-        <Text text70 blue30 onPress={onCancel}>
+        <Text text70 blue30 onPress={onCancel} accessibilityRole={onCancel ? 'button' : undefined}>
           {_.get(topBarProps, 'cancelLabel', 'Cancel')}
         </Text>
-        <Text text70 blue30 onPress={onDone}>
+        <Text text70 blue30 onPress={onDone} accessibilityRole={onDone ? 'button' : undefined}>
           {_.get(topBarProps, 'doneLabel', 'Done')}
         </Text>
       </View>

src/components/switch/index.js

@@ -81,14 +81,12 @@ class Switch extends BaseComponent {
   }
 
   getAccessibilityProps() {
-    const {accessibilityLabel, disabled, value} = this.getThemeProps();
-    const switchState = value ? 'on' : 'off';
+    const {disabled, value} = this.getThemeProps();
 
     return {
       accessible: true,
-      accessibilityLabel: accessibilityLabel ? `${accessibilityLabel} ${switchState}` : `switch ${switchState}`, //TODO: RN60 fix label and role and convert to accessibilityActions
-      accessibilityRole: 'button',
-      accessibilityStates: disabled ? ['disabled'] : undefined
+      accessibilityRole: 'switch',
+      accessibilityStates: disabled ? ['disabled'] : value ? ['checked'] : ['unchecked']
     };
   }