Skip to content

Commit 3d7d8b9

Browse files
committed
Errors and warnings are commented to avoid out-of-sram error.
Related errors should be managed on the client side. TODO : Uncomment this lines when F("...") function supported. See http://playground.arduino.cc/Learning/Memory for more infos.
1 parent dc237a2 commit 3d7d8b9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

utility/EncoderFirmata.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ void EncoderFirmata::attachEncoder(byte encoderNum, byte pinANum, byte pinBNum)
3737
{
3838
if (isEncoderAttached(encoderNum))
3939
{
40-
Firmata.sendString("Encoder Warning: encoder is already attached. Operation cancelled.");
40+
//Firmata.sendString("Encoder Warning: encoder is already attached. Operation cancelled.");
4141
return;
4242
}
4343

4444
if (!IS_PIN_INTERRUPT(pinANum) || !IS_PIN_INTERRUPT(pinBNum))
4545
{
46-
Firmata.sendString("Encoder Warning: For better performences, you should only use Interrput pins.");
46+
//Firmata.sendString("Encoder Warning: For better performences, you should only use Interrput pins.");
4747
}
4848
encoders[encoderNum] = new Encoder(pinANum, pinBNum);
4949
}
@@ -128,7 +128,7 @@ boolean EncoderFirmata::handleSysex(byte command, byte argc, byte *argv)
128128
return true;
129129
}
130130

131-
Firmata.sendString("Encoder Error: Invalid command");
131+
//Firmata.sendString("Encoder Error: Invalid command");
132132
}
133133
return false;
134134
}
@@ -159,7 +159,7 @@ boolean EncoderFirmata::isEncoderAttached(byte encoderNum)
159159
{
160160
if (encoderNum>=MAX_ENCODERS)
161161
{
162-
Firmata.sendString("Encoder Error: encoder number should be less than 5. Operation cancelled.");
162+
//Firmata.sendString("Encoder Error: encoder number should be less than 5. Operation cancelled.");
163163
return false;
164164
}
165165
if (encoders[encoderNum])

0 commit comments

Comments
 (0)