Fixes bug when checking for failure in php_stream_gets

michael-grunder · michael-grunder · commit 7f27e2e39c33 · 2015-12-17T21:41:24.000-08:00
Addresses phpredis#672
diff --git a/library.c b/library.c
@@ -2252,7 +2252,7 @@ redis_read_reply_type(RedisSock *redis_sock, REDIS_REPLY_TYPE *reply_type,
         char inbuf[255];
 
 		/* Read up to our newline */
-		if(php_stream_gets(redis_sock->stream, inbuf, sizeof(inbuf)) < 0) {
+		if(php_stream_gets(redis_sock->stream, inbuf, sizeof(inbuf)) == NULL) {
 			return -1;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -2252,7 +2252,7 @@ redis_read_reply_type(RedisSock redis_sock, REDIS_REPLY_TYPE reply_type,`
`2252`	`2252`	`char inbuf[255];`
`2253`	`2253`
`2254`	`2254`	`/* Read up to our newline */`
`2255`		`- if(php_stream_gets(redis_sock->stream, inbuf, sizeof(inbuf)) < 0) {`
	`2255`	`+ if(php_stream_gets(redis_sock->stream, inbuf, sizeof(inbuf)) == NULL) {`
`2256`	`2256`	`return -1;`
`2257`	`2257`	`}`
`2258`	`2258`