Fix issue paquettg#166

Author: paquettg

src/PHPHtmlParser/Dom.php

@@ -192,7 +192,7 @@ public function loadFromUrl(string $url, array $options = [], CurlInterface $cur
      * @return Dom
      * @chainable
      */
-    public function loadStr(string $str, array $option): Dom
+    public function loadStr(string $str, array $option = []): Dom
     {
         $this->options = new Options;
         $this->options->setOptions($this->globalOptions)

src/PHPHtmlParser/Dom/InnerNode.php

@@ -357,9 +357,15 @@ public function replaceChild(int $childId, AbstractNode $newChild): void
      *
      * @return AbstractNode
      * @uses $this->getChild()
+     * @throws ChildNotFoundException
      */
     public function firstChild(): AbstractNode
     {
+        if (count($this->children) == 0) {
+            // no children
+            throw new ChildNotFoundException("No children found in node.");
+        }
+
         reset($this->children);
         $key = key($this->children);
 
@@ -370,9 +376,16 @@ public function firstChild(): AbstractNode
      * Attempts to get the last child.
      *
      * @return AbstractNode
+     * @uses $this->getChild()
+     * @throws ChildNotFoundException
      */
     public function lastChild(): AbstractNode
     {
+        if (count($this->children) == 0) {
+            // no children
+            throw new ChildNotFoundException("No children found in node.");
+        }
+
         end($this->children);
         $key = key($this->children);
 

tests/DomTest.php

@@ -397,4 +397,14 @@ public function testGetComplexAttribute()
         $href = $dom->find('a', 0)->href;
         $this->assertEquals('?search=Fort+William&session_type=face&distance=100&uqs=119846&page=4', $href);
     }
+
+    public function testGetChildrenNoChildren()
+    {
+        $dom = new Dom();
+        $dom->loadStr('<div>Test <img src="test.jpg"></div>');
+
+        $imgNode = $dom->root->find('img');
+        $children = $imgNode->getChildren();
+        $this->assertTrue(count($children) === 0);
+    }
 }