Skip to content

Commit 93bab6e

Browse files
committed
Make valid() return a boolean instead of 0 or 1. Fixes jquery-validation#109 - valid() does not return boolean value
1 parent cef7bdf commit 93bab6e

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

jquery.validate.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ $.extend($.fn, {
103103
var valid = true;
104104
var validator = $(this[0].form).validate();
105105
this.each(function() {
106-
valid &= validator.element(this);
106+
valid = valid && validator.element(this);
107107
});
108108
return valid;
109109
}

test/test.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@ test("valid() plugin method", function() {
6262
var inputs = form.find("input");
6363
ok( !inputs.valid(), "all invalid" );
6464
inputs.not(":first").val("ok");
65-
ok( !inputs.valid(), "just one invalid" );
65+
strictEqual( inputs.valid(), false, "just one invalid" );
6666
inputs.val("ok");
67-
ok( inputs.valid(), "all valid" );
67+
strictEqual( inputs.valid(), true, "all valid" );
6868
});
6969

7070
test("valid() plugin method, special handling for checkable groups", function() {
@@ -824,19 +824,19 @@ test('bypassing validation on form submission',function () {
824824
var $v = form.validate({
825825
debug : true
826826
});
827-
827+
828828
bypassSubmitWithCancel.click();
829829
equal($v.numberOfInvalids(), 0, "Validation was bypassed using CSS 'cancel' class.");
830830
$v.resetForm();
831-
831+
832832
bypassSubmitWithNoValidate1.click();
833833
equal($v.numberOfInvalids(), 0, "Validation was bypassed using blank 'formnovalidate' attribute.");
834834
$v.resetForm();
835-
835+
836836
bypassSubmitWithNoValidate2.click();
837837
equal($v.numberOfInvalids(), 0, "Validation was bypassed using 'formnovalidate=\"formnovalidate\"' attribute.");
838838
$v.resetForm();
839-
839+
840840
normalSubmission.click();
841841
equal($v.numberOfInvalids(), 1, "Validation failed correctly");
842842
});

0 commit comments

Comments
 (0)