From 8faee735933e15f36b23686a46f78666916c8ea7 Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Tue, 18 Dec 2018 17:00:46 -0800 Subject: [PATCH] chore: fix headers for M71 v8 7.1 split out v8-internal, but the hacky node header script i wrote gets its header list from node's v8, which is older --- filenames.json | 2 +- tools/generate_gn_filenames_json.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/filenames.json b/filenames.json index 83bb130efdc..65190a998fc 100644 --- a/filenames.json +++ b/filenames.json @@ -16,6 +16,7 @@ { "dest_dir": "include/node//", "files": [ + "//v8/include/v8-internal.h", "//v8/include/v8-platform.h", "//v8/include/v8-profiler.h", "//v8/include/v8-testing.h", @@ -137,7 +138,6 @@ "lib/internal/crypto/cipher.js", "lib/internal/crypto/diffiehellman.js", "lib/internal/crypto/hash.js", - "lib/internal/crypto/keygen.js", "lib/internal/crypto/pbkdf2.js", "lib/internal/crypto/random.js", "lib/internal/crypto/scrypt.js", diff --git a/tools/generate_gn_filenames_json.py b/tools/generate_gn_filenames_json.py index 28e97bcb9ae..95d5fdac989 100755 --- a/tools/generate_gn_filenames_json.py +++ b/tools/generate_gn_filenames_json.py @@ -52,6 +52,10 @@ def add_headers(files, dest_dir): files = [f for f in files if f.endswith('.h')] elif any(f.startswith('deps/v8/') for f in files): files = [f.replace('deps/v8/', '//v8/', 1) for f in files] + + # For compatibility with V8 7.1 + if not any('libplatform' in f for f in files): + files += ['//v8/include/v8-internal.h'] hs = {'files': sorted(files), 'dest_dir': dest_dir} out['headers'].append(hs)