Skip to content

fix: add @malept/cross-spawn-promise to dependencies#1810

Merged
dsanders11 merged 1 commit intoelectron:mainfrom
Agritite:fix-ghost-deps
Aug 14, 2025
Merged

fix: add @malept/cross-spawn-promise to dependencies#1810
dsanders11 merged 1 commit intoelectron:mainfrom
Agritite:fix-ghost-deps

Conversation

@Agritite
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
fixes #1809

@Agritite Agritite requested a review from a team as a code owner August 11, 2025 03:50
@welcome
Copy link

welcome bot commented Aug 11, 2025

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

@Agritite Agritite force-pushed the fix-ghost-deps branch 3 times, most recently from 7860274 to 6d76181 Compare August 11, 2025 03:55
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this :)

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.78%. Comparing base (7a13a40) to head (bd6b5df).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1810      +/-   ##
==========================================
- Coverage   88.88%   86.78%   -2.11%     
==========================================
  Files          17       18       +1     
  Lines         909      976      +67     
  Branches      188      207      +19     
==========================================
+ Hits          808      847      +39     
- Misses         63       88      +25     
- Partials       38       41       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dsanders11 dsanders11 changed the title fix: icon-composer ghost dependency fix: add @malept/cross-spawn-promise to dependencies Aug 14, 2025
@dsanders11 dsanders11 merged commit 6b39b49 into electron:main Aug 14, 2025
15 of 16 checks passed
@welcome
Copy link

welcome bot commented Aug 14, 2025

Thanks for your contribution! 🎉

@continuous-auth
Copy link

🎉 This PR is included in version 18.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ghost dependency "@malept/cross-spawn-promise"

3 participants