fix: correct return value for serialHooks helper#1867
Merged
Conversation
Member
|
I don't suppose there's a reasonable way to add a regression test for this? |
Member
Author
|
@malept I think I just wrote the Lines 45 to 53 in b25e5bc |
Member
|
Ah OK, that makes sense. |
dsanders11
approved these changes
Jan 15, 2026
serialHooks helper
|
🎉 This PR is included in version 19.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewrites
serialHooksto actually work as intended (by passing the resulting arg as a single mega-hook into Packager's options).Usage would look something like this: