Cleanup of test file + TODO

eliben · eliben · commit 63ef84a99e87 · 2025-09-19T07:18:40.000-07:00
diff --git a/2025/consistent-hashing/consistenthasher_test.go b/2025/consistent-hashing/consistenthasher_test.go
@@ -23,7 +23,7 @@ func generateRandomString(rnd *rand.Rand, length int) string {
 	return string(b)
 }
 
-func TestSmokeConsistentHasher(t *testing.T) {
+func TestSmoke(t *testing.T) {
 	ch := NewConsistentHasher(1024)
 
 	// Add nodes named "node-N"
@@ -40,7 +40,7 @@ func TestSmokeConsistentHasher(t *testing.T) {
 	ch.FindNodeFor(s)
 }
 
-func TestConsistentHasher(t *testing.T) {
+func TestFindsCorrectNode(t *testing.T) {
 	rnd := makeLoggedRand(t)
 	ch := NewConsistentHasher(1024 * 1024)
 
@@ -90,3 +90,6 @@ func TestConsistentHasher(t *testing.T) {
 		}
 	}
 }
+
+// TODO: tests for consistency - (same nodes assigned after nodes are added,
+// etc)

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ func generateRandomString(rnd *rand.Rand, length int) string {`
`23`	`23`	`return string(b)`
`24`	`24`	`}`
`25`	`25`
`26`		`-func TestSmokeConsistentHasher(t *testing.T) {`
	`26`	`+func TestSmoke(t *testing.T) {`
`27`	`27`	`ch := NewConsistentHasher(1024)`
`28`	`28`
`29`	`29`	`// Add nodes named "node-N"`
`@@ -40,7 +40,7 @@ func TestSmokeConsistentHasher(t *testing.T) {`
`40`	`40`	`ch.FindNodeFor(s)`
`41`	`41`	`}`
`42`	`42`
`43`		`-func TestConsistentHasher(t *testing.T) {`
	`43`	`+func TestFindsCorrectNode(t *testing.T) {`
`44`	`44`	`rnd := makeLoggedRand(t)`
`45`	`45`	`ch := NewConsistentHasher(1024 * 1024)`
`46`	`46`
`@@ -90,3 +90,6 @@ func TestConsistentHasher(t *testing.T) {`
`90`	`90`	`}`
`91`	`91`	`}`
`92`	`92`	`}`
	`93`	`+`
	`94`	`+// TODO: tests for consistency - (same nodes assigned after nodes are added,`
	`95`	`+// etc)`