Fix -Wlogical-not-parentheses warning (arduino-libraries#79)

vaipatel · web-flow · commit 9a5afdfc741a · 2021-02-26T11:01:05.000+01:00
* Fix -Wlogical-not-parentheses warning

The warning occurs because `operator!()` has higher precedence than `operator&gt;()`.

Alternatively, we can use:
```
iClient-&gt;connect(iServerAddress, iServerPort) &lt;= 0
```
diff --git a/src/HttpClient.cpp b/src/HttpClient.cpp
@@ -84,7 +84,7 @@ int HttpClient::startRequest(const char* aURLPath, const char* aHttpMethod,
     {
         if (iServerName)
         {
-            if (!iClient->connect(iServerName, iServerPort) > 0)
+            if (!(iClient->connect(iServerName, iServerPort) > 0))
             {
 #ifdef LOGGING
                 Serial.println("Connection failed");
@@ -94,7 +94,7 @@ int HttpClient::startRequest(const char* aURLPath, const char* aHttpMethod,
         }
         else
         {
-            if (!iClient->connect(iServerAddress, iServerPort) > 0)
+            if (!(iClient->connect(iServerAddress, iServerPort) > 0))
             {
 #ifdef LOGGING
                 Serial.println("Connection failed");

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ int HttpClient::startRequest(const char* aURLPath, const char* aHttpMethod,`
`84`	`84`	`{`
`85`	`85`	`if (iServerName)`
`86`	`86`	`{`
`87`		`- if (!iClient->connect(iServerName, iServerPort) > 0)`
	`87`	`+ if (!(iClient->connect(iServerName, iServerPort) > 0))`
`88`	`88`	`{`
`89`	`89`	`#ifdef LOGGING`
`90`	`90`	`Serial.println("Connection failed");`
`@@ -94,7 +94,7 @@ int HttpClient::startRequest(const char* aURLPath, const char* aHttpMethod,`
`94`	`94`	`}`
`95`	`95`	`else`
`96`	`96`	`{`
`97`		`- if (!iClient->connect(iServerAddress, iServerPort) > 0)`
	`97`	`+ if (!(iClient->connect(iServerAddress, iServerPort) > 0))`
`98`	`98`	`{`
`99`	`99`	`#ifdef LOGGING`
`100`	`100`	`Serial.println("Connection failed");`