[macOS] Disable FlutterEngineTest.BackgroundColor (flutter#52341)

cbracken · web-flow · commit 7f89b4367338 · 2024-04-23T23:21:05.000Z
This was re-enabled in flutter#124677 after fixing leaks in flutter/engine#50832. Since this test involves an NSWindow, there are separate fixes that should be landed to reduce flakes related to lack of NSWindow close calls in the tests. See related AppKit bug report filed at http://www.openradar.me/FB13291861. Issue: flutter#145728 Related issue: flutter#124677 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
diff --git a/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm b/shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm
@@ -223,7 +223,7 @@ @implementation MockableFlutterEngine
   EXPECT_TRUE(stdout_capture.GetOutput().find("Hello logging") != std::string::npos);
 }
 
-TEST_F(FlutterEngineTest, BackgroundIsBlack) {
+TEST_F(FlutterEngineTest, DISABLED_BackgroundIsBlack) {
   FlutterEngine* engine = GetFlutterEngine();
 
   // Latch to ensure the entire layer tree has been generated and presented.

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,7 @@ @implementation MockableFlutterEngine`
`223`	`223`	`EXPECT_TRUE(stdout_capture.GetOutput().find("Hello logging") != std::string::npos);`
`224`	`224`	`}`
`225`	`225`
`226`		`-TEST_F(FlutterEngineTest, BackgroundIsBlack) {`
	`226`	`+TEST_F(FlutterEngineTest, DISABLED_BackgroundIsBlack) {`
`227`	`227`	`FlutterEngine* engine = GetFlutterEngine();`
`228`	`228`
`229`	`229`	`// Latch to ensure the entire layer tree has been generated and presented.`