Commit 8e1406f
authored
Fix the local-only lint errors due to an unexpected
Remove `android/**/GeneratedPluginRegistrant.java` from the global
`.gitignore`.
This file should never exist in the source tree, locally or on CI, and
it existing/being hidden causes lint errors.
## Background
Here is what we _think_ happens:
- Someone opens `$ENGINE/src/flutter/testing/scenario_app` in VS Code
- VS Code picks this up as a "Flutter package", running `flutter
packages get`
- The Flutter tool generates `../GeneratedPluginRegistrant.java`,
thinking this is a Flutter app
- The lint error fails on `GeneratedPluginRegistrant`
```txt
$ ninja -j100 -C out/android_debug_unopt_arm64/
FAILED: scenario_app/reports/lint-results.xml
vpython3 ../../flutter/testing/rules/run_gradle.py /Users/aaclarke/dev/engine/src/flutter/testing/scenario_app/android lint --no-daemon -Pflutter_jar=/Users/aaclarke/dev/engine/src/out/android_debug_unopt_arm64/flutter.jar -Pout_dir=/Users/aaclarke/dev/engine/src/out/android_debug_unopt_arm64/scenario_app --project-cache-dir=/Users/aaclarke/dev/engine/src/out/android_debug_unopt_arm64/scenario_app/.gradle --gradle-user-home=/Users/aaclarke/dev/engine/src/out/android_debug_unopt_arm64/scenario_app/.gradle
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':app:lintDebug'.
> Lint found errors in the project; aborting build.
Fix the issues identified by lint, or create a baseline to see only new errors:
'''
android {
lint {
baseline = file("lint-baseline.xml")
}
}
'''
For more details, see https://developer.android.com/studio/write/lint#snapshot
Lint found 1 errors, 0 warnings. First failure:
```
/cc @christopherfujino for any other theories.GeneratedPluginRegistrant.java (flutter#50795)1 parent db49661 commit 8e1406f
1 file changed
+0
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
38 | 37 | | |
39 | 38 | | |
40 | 39 | | |
| |||
76 | 75 | | |
77 | 76 | | |
78 | 77 | | |
79 | | - | |
80 | 78 | | |
81 | 79 | | |
82 | 80 | | |
| |||
0 commit comments